From 868f6243bc6021465938a7b764bef8fd001cb39c Mon Sep 17 00:00:00 2001 From: Paul Jensen Date: Mon, 18 May 2015 12:48:28 -0400 Subject: Don't leak NetworkListens in captive portal app. Bug:21146632 Change-Id: I934044a2eec89a47185add881a74de5669cd0f89 --- .../captiveportallogin/CaptivePortalLoginActivity.java | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'packages/CaptivePortalLogin') diff --git a/packages/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java b/packages/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java index 1019e6c..c7b7e6a 100644 --- a/packages/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java +++ b/packages/CaptivePortalLogin/src/com/android/captiveportallogin/CaptivePortalLoginActivity.java @@ -146,6 +146,7 @@ public class CaptivePortalLoginActivity extends Activity { private void done(Result result) { if (mNetworkCallback != null) { mCm.unregisterNetworkCallback(mNetworkCallback); + mNetworkCallback = null; } switch (result) { case DISMISSED: @@ -191,6 +192,16 @@ public class CaptivePortalLoginActivity extends Activity { return super.onOptionsItemSelected(item); } + @Override + public void onDestroy() { + super.onDestroy(); + + if (mNetworkCallback != null) { + mCm.unregisterNetworkCallback(mNetworkCallback); + mNetworkCallback = null; + } + } + private void testForCaptivePortal() { new Thread(new Runnable() { public void run() { -- cgit v1.1