From 56f9e6f8d5436d50530807950661e66ca5efe2bb Mon Sep 17 00:00:00 2001 From: Tim Murray Date: Fri, 16 May 2014 11:47:26 -0700 Subject: Add support for mixed 32/64 APKs using RenderScript. Change-Id: I8901a1547d180c9dcef320f86d07a5b82551fb5c --- rs/java/android/renderscript/FieldPacker.java | 14 ++++++++--- rs/java/android/renderscript/RenderScript.java | 7 ++++++ rs/java/android/renderscript/ScriptC.java | 33 ++++++++++++++++++++++++++ rs/jni/android_renderscript_RenderScript.cpp | 7 ++++++ 4 files changed, 58 insertions(+), 3 deletions(-) (limited to 'rs') diff --git a/rs/java/android/renderscript/FieldPacker.java b/rs/java/android/renderscript/FieldPacker.java index 723ab24..0e57232 100644 --- a/rs/java/android/renderscript/FieldPacker.java +++ b/rs/java/android/renderscript/FieldPacker.java @@ -231,10 +231,18 @@ public class FieldPacker { public void addObj(BaseObj obj) { if (obj != null) { - // FIXME: this is fine for 32-bit but needs a path for 64-bit - addI32((int)obj.getID(null)); + if (RenderScript.sPointerSize == 8) { + addI64(obj.getID(null)); + } + else { + addI32((int)obj.getID(null)); + } } else { - addI32(0); + if (RenderScript.sPointerSize == 8) { + addI64(0); + } else { + addI32(0); + } } } diff --git a/rs/java/android/renderscript/RenderScript.java b/rs/java/android/renderscript/RenderScript.java index 2222d2c..8cac22d 100644 --- a/rs/java/android/renderscript/RenderScript.java +++ b/rs/java/android/renderscript/RenderScript.java @@ -82,6 +82,12 @@ public class RenderScript { */ public static final long CREATE_FLAG_LOW_POWER = 0x0004; + /* + * Detect the bitness of the VM to allow FieldPacker to do the right thing. + */ + static native int rsnSystemGetPointerSize(); + static int sPointerSize; + static { sInitialized = false; if (!SystemProperties.getBoolean("config.disable_renderscript", false)) { @@ -99,6 +105,7 @@ public class RenderScript { System.loadLibrary("rs_jni"); _nInit(); sInitialized = true; + sPointerSize = rsnSystemGetPointerSize(); } catch (UnsatisfiedLinkError e) { Log.e(LOG_TAG, "Error loading RS jni library: " + e); throw new RSRuntimeException("Error loading RS jni library: " + e); diff --git a/rs/java/android/renderscript/ScriptC.java b/rs/java/android/renderscript/ScriptC.java index 9e76f52..3176e28 100644 --- a/rs/java/android/renderscript/ScriptC.java +++ b/rs/java/android/renderscript/ScriptC.java @@ -67,6 +67,26 @@ public class ScriptC extends Script { } /** + * Only intended for use by the generated derived classes. + * + * @param rs + * @hide + */ + protected ScriptC(RenderScript rs, String resName, byte[] bitcode32, byte[] bitcode64) { + super(0, rs); + long id = 0; + if (RenderScript.sPointerSize == 4) { + id = internalStringCreate(rs, resName, bitcode32); + } else { + id = internalStringCreate(rs, resName, bitcode64); + } + if (id == 0) { + throw new RSRuntimeException("Loading of ScriptC script failed."); + } + setID(id); + } + + /** * Name of the file that holds the object cache. */ private static final String CACHE_PATH = "com.android.renderscript.cache"; @@ -113,4 +133,17 @@ public class ScriptC extends Script { // Log.v(TAG, "Create script for resource = " + resName); return rs.nScriptCCreate(resName, mCachePath, pgm, pgmLength); } + + private static synchronized long internalStringCreate(RenderScript rs, String resName, byte[] bitcode) { + // Create the RS cache path if we haven't done so already. + if (mCachePath == null) { + File f = new File(rs.mCacheDir, CACHE_PATH); + mCachePath = f.getAbsolutePath(); + f.mkdirs(); + } + // Log.v(TAG, "Create script for resource = " + resName); + return rs.nScriptCCreate(resName, mCachePath, bitcode, bitcode.length); + } + + } diff --git a/rs/jni/android_renderscript_RenderScript.cpp b/rs/jni/android_renderscript_RenderScript.cpp index 18a2e31..ae39b05 100644 --- a/rs/jni/android_renderscript_RenderScript.cpp +++ b/rs/jni/android_renderscript_RenderScript.cpp @@ -1573,6 +1573,12 @@ nMeshGetIndices(JNIEnv *_env, jobject _this, jlong con, jlong mesh, jlongArray _ free(prims); } +static jint +nSystemGetPointerSize(JNIEnv *_env, jobject _this) { + return (jint)sizeof(void*); +} + + // --------------------------------------------------------------------------- @@ -1708,6 +1714,7 @@ static JNINativeMethod methods[] = { {"rsnMeshGetVertices", "(JJ[JI)V", (void*)nMeshGetVertices }, {"rsnMeshGetIndices", "(JJ[J[II)V", (void*)nMeshGetIndices }, +{"rsnSystemGetPointerSize", "()I", (void*)nSystemGetPointerSize }, }; static int registerFuncs(JNIEnv *_env) -- cgit v1.1