From e87e9506ba130c89a2b76f8ad4677d01d1918dc0 Mon Sep 17 00:00:00 2001 From: Tammo Spalink Date: Wed, 15 Apr 2009 18:50:38 +0800 Subject: eliminate seemingly pointless conversion to and then from hex string --- .../android/internal/telephony/gsm/SIMRecords.java | 25 ++++++---------------- 1 file changed, 6 insertions(+), 19 deletions(-) (limited to 'telephony/java/com') diff --git a/telephony/java/com/android/internal/telephony/gsm/SIMRecords.java b/telephony/java/com/android/internal/telephony/gsm/SIMRecords.java index 09a17f5..f9015d9 100644 --- a/telephony/java/com/android/internal/telephony/gsm/SIMRecords.java +++ b/telephony/java/com/android/internal/telephony/gsm/SIMRecords.java @@ -1099,14 +1099,9 @@ public final class SIMRecords extends IccRecords { // Note: Data may include trailing FF's. That's OK; message // should still parse correctly. - byte[] nba = new byte[n - 1]; - System.arraycopy(ba, 1, nba, 0, n - 1); - - String pdu = IccUtils.bytesToHexString(nba); - // XXX first line is bogus - SmsMessage message = SmsMessage.newFromCMT( - new String[] { "", pdu }); - + byte[] pdu = new byte[n - 1]; + System.arraycopy(ba, 1, pdu, 0, n - 1); + SmsMessage message = SmsMessage.createFromPdu(pdu); ((GSMPhone) phone).mSMS.dispatchMessage(message); } @@ -1130,14 +1125,9 @@ public final class SIMRecords extends IccRecords { // Note: Data may include trailing FF's. That's OK; message // should still parse correctly. - byte[] nba = new byte[n - 1]; - System.arraycopy(ba, 1, nba, 0, n - 1); - - String pdu = IccUtils.bytesToHexString(nba); - // XXX first line is bogus - SmsMessage message = SmsMessage.newFromCMT( - new String[] { "", pdu }); - + byte[] pdu = new byte[n - 1]; + System.arraycopy(ba, 1, pdu, 0, n - 1); + SmsMessage message = SmsMessage.createFromPdu(pdu); ((GSMPhone) phone).mSMS.dispatchMessage(message); @@ -1499,6 +1489,3 @@ public final class SIMRecords extends IccRecords { } } - - - -- cgit v1.1