diff options
| author | Dave Burke <daveburke@google.com> | 2012-10-06 23:20:00 -0700 |
|---|---|---|
| committer | Android (Google) Code Review <android-gerrit@google.com> | 2012-10-06 23:20:00 -0700 |
| commit | 0bed1f541d5a8284691d2296754604cde0723787 (patch) | |
| tree | dabb6a7a6d0d4c41014e856c7a56e8d23fb0da27 | |
| parent | 0845d0245e09548110cacb0f20e9934753388aab (diff) | |
| download | frameworks_native-0bed1f541d5a8284691d2296754604cde0723787.zip frameworks_native-0bed1f541d5a8284691d2296754604cde0723787.tar.gz frameworks_native-0bed1f541d5a8284691d2296754604cde0723787.tar.bz2 | |
Revert "ugly, temporary, workaroung for a problem where a binder thread spins forever"
This reverts commit 0845d0245e09548110cacb0f20e9934753388aab
Change-Id: I395037cb9427cd11f7de6bb78fbdfa917fc6263a
| -rw-r--r-- | libs/binder/IPCThreadState.cpp | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/libs/binder/IPCThreadState.cpp b/libs/binder/IPCThreadState.cpp index 03c1082..6e83faa 100644 --- a/libs/binder/IPCThreadState.cpp +++ b/libs/binder/IPCThreadState.cpp @@ -482,18 +482,6 @@ void IPCThreadState::joinThreadPool(bool isMain) if(result == TIMED_OUT && !isMain) { break; } - - // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK - // FIXME: we sometimes get unexplained EINVAL which causes this - // thread to spin forever. TEMPORARILY allow it to exit. - // We should probably assert on eng builds - if(result == -EINVAL && !isMain) { - ALOGE("**** THREAD %p (PID %d) ERROR (%d) LEAVING THE THREAD POOL\n", - (void*)pthread_self(), getpid(), result); - break; - } - // HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK HACK - } while (result != -ECONNREFUSED && result != -EBADF); LOG_THREADPOOL("**** THREAD %p (PID %d) IS LEAVING THE THREAD POOL err=%p\n", |