summaryrefslogtreecommitdiffstats
path: root/libs
Commit message (Collapse)AuthorAgeFilesLines
...
* | | | | | | | am a161b6ce: am c02377e6: am 4d769d8b: Merge "libui: Clean up Fence and ↵Dan Stoza2015-04-152-16/+35
|\ \ \ \ \ \ \ \ | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Region flattening" * commit 'a161b6cee9253a17be6b8dc232b05a41fde0030a': libui: Clean up Fence and Region flattening
| * | | | | | | Merge "libui: Clean up Fence and Region flattening"Dan Stoza2015-04-152-16/+35
| |\ \ \ \ \ \ \
| | * | | | | | | libui: Clean up Fence and Region flatteningDan Stoza2015-04-152-16/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fence was flattening incorrectly, causing issues with any fields flattened after it, and Region was relying on being the last object flattened. This change addresses both. Change-Id: If49de061de6e2f11f4d846b4d8c18627dfb7e109
* | | | | | | | | Added IPCThreadState::blockUntilThreadAvailable() method.Wale Ogunwale2015-04-142-3/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Will be used by the system_server watchdog to monitor the availability of binder threads in the process to handle incoming IPC requests. Bug: 19297165 Change-Id: I39175f3869ad14da5620fddb47f454e6e4ee2b25
* | | | | | | | | am 6ea912c0: am ddabf640: am a3f8c2aa: Merge "Fix a memory corruption issue ↵Dan Stoza2015-04-141-18/+17
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when vector resize" * commit '6ea912c0494fe67d342224b737078dd90b991db6': Fix a memory corruption issue when vector resize
| * | | | | | | | Merge "Fix a memory corruption issue when vector resize"Dan Stoza2015-04-141-18/+17
| |\ \ \ \ \ \ \ \ | | |/ / / / / / / | |/| | | | | | |
| | * | | | | | | Fix a memory corruption issue when vector resizeywen2015-04-101-18/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is memory corruption in below code const Rect* prev = &dst[prevIndex]; dst.add(Rect(prev->right, top, right, bottom)); prev points to a memory of vector dst, when dst resize in add() call, the memory that prev points to will be copy to the new allocated vector memory and the old memory will become undefined Avoid pointer in this case, use a local copy instead Change-Id: I4d95ceedd00c8fb615ac153082ade1b1ce0d0fa8
* | | | | | | | | Pass through availability of audio mic for input devices.Tim Kilbourn2015-04-091-5/+8
| |_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 15374820 Change-Id: Id2ca6da10165e3a887ebfbb18f663a3bf316ac79
* | | | | | | | am 172ff24c: am 5977851b: am 00afb817: Merge "libgui: Plumb detachBuffer ↵Dan Stoza2015-04-071-0/+15
|\ \ \ \ \ \ \ \ | |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | through ConsumerBase" * commit '172ff24ccbc232cdf244a2bcbbb51df754929521': libgui: Plumb detachBuffer through ConsumerBase
| * | | | | | | libgui: Plumb detachBuffer through ConsumerBaseDan Stoza2015-04-071-0/+15
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Exposes IGraphicBufferConsumer::detachBuffer as a ConsumerBase method. attachBuffer is not currently exposed, because all current clients will be recycling buffers through the allocator. Bug: 19628705 Change-Id: I3e519767fa43d5d880c1d5695e31b60f6ad588af
| * | | | | | DO NOT MERGE libgui: Plumb attach/detach through SurfaceDan Stoza2015-04-021-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Exposes the attachBuffer and detachNextBuffer calls from IGraphicBufferProducer to the public Surface interface. Also moves the version of connect that takes a producer callback from protected to public. Bug: 19628705 Change-Id: I9ebc3013c4d9c84c4e8ef150c00e03f8af80319e (cherry picked from commit c14ecb9de243af8864610fd3c74342e3ca2cb4bc)
| * | | | | | DO NOT MERGE libgui: Remove IGBC::BufferItemDan Stoza2015-03-207-257/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes IGraphicBufferConsumer::BufferItem. Depends on the following changes: I187b3a7d05196b6289596afac8fb9a9d4aebff76 I0ddd38df37500cfd6b21d1e768ed14e39c5cd9fc Cherry-pick of Id1fa56d092188f2cb712768d5d2fc6a9027fb73c Change-Id: I3edf0db8fba656fd78e18a5a7f1137f0fb6b237d
| * | | | | | DO NOT MERGE libgui: Prepare for IGBC::BufferItem removalDan Stoza2015-03-1910-13/+100
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, there are two instances of BufferItem: one inside of IGraphicBufferConsumer, and a standalone one inside of libgui. They only differ in the name of one of the fields, and we want to remove the IGBC version. This changes things so that client code may be incrementally switched over to the libgui version. This is a squashed commit containing the following changes: I64f495105f56cbf5803cea4aa6b072ea29b70cf5 I1394e693314429ada93427889f10b7b01c948053 I9c3bc8037fa9438d4d9080b8afb694219ef2f71f I699ed0a6837076867ca756b28d1ffb2238f7a0d9 Iac8425e1241774304a131da2fb9dec6e82922f13 Change-Id: Ic4d51f5df6dbc70b376d13fceba2335b9bae4f3d
| * | | | | | DO NOT MERGE Add dataSpace to buffer queues; remove old format enums.Eino-Ville Talvala2015-03-1918-35/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Wire up new dataSpace parameter through buffer queue stack - Update tests to include the parameter - Switch eglApi to using dataSpace to indicate sRGB gamma/linear difference - Remove RAW_SENSOR in favor of RAW16 - Remove use of sRGB format enums - Add default dataspace to buffer queue core - Add query for default dataspace Cherry pick of I070bd2e7c56506055c419004c29e2e3feac725df Change-Id: I461952389c18051176c6b75e664f20ad369f5760
| * | | | | | Merge "Surface: Permit an IProducerListener on connect"Dan Stoza2015-03-191-1/+5
| |\ \ \ \ \ \
| | * | | | | | Surface: Permit an IProducerListener on connectDan Stoza2015-03-181-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change allows clients of Surface to provide an IProducerListener callback object to Surface::connect, which will be passed down to the underlying IGraphicBufferProducer. Cherry pick of I5ea5229bf3a329bf02c6bd20e7247039c75d136b Change-Id: I6f8f52c72654e4cee649721383819bafe378f964
| * | | | | | | libgui: Only allow one return from useFenceSyncDan Stoza2015-03-191-1/+2
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An #ifdef was causing multiple returns in this function, which was triggering an unreachable code error on some build targets. This adds an #else to ensure that only one return is exposed in any given build. Cherry pick of I9ed7c3e769bc9094ad31d810944227d1d8302886 Change-Id: Ibddc5706159d168031d1805fcce3eedc068296cf
| * | | | | | GLConsumer: Fix unsigned subtraction during cropDan Stoza2015-03-181-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since some variables had been switched from signed to unsigned, there was a section of code that was guaranteed to be incorrect because it effectively did 'if (a < b) { c = a - b; }'. This change fixes it. Cherry pick of I9cdd6c9a0179801addebb5d6dc1fbaddf8f53c62 Bug: 19346631 Change-Id: Id13a46f74c9ae7278463ce22b586f4dc21b5e453
| * | | | | | Update maxNumber to be smaller.Michael Lentine2015-03-181-1/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There shouldn't be more than 4096 fds (probably signficantly smaller) and there shouldn't be more than 4096 ints. Cherry pick of I3a3e50ee3078a4710e9737114e65afc923ed0573 Bug: 18076253 Change-Id: I82a883572b401f115d252dcd3d00aa7252b49b0e
| * | | | | | libgui: Enable -Weverything and -WerrorDan Stoza2015-03-1829-406/+517
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Enables -Weverything and -Werror, with just a few exceptions for warnings we can't (or shouldn't need to) work around. Cherry pick of I034abec27bf4020d84af60d7acc1939c59986dd6 plus a couple of minor changes to CpuConsumer.cpp to make it work with a prior change: Uncomment CC_LOGV on line 46 Change C-style cast to static_cast on line 71 Change-Id: Iaec610477ea0122317b0578fb74caf2383d4cf08
* | | | | | | Merge "Revert "libgui: Plumb attach/detach through CpuConsumer""Dan Stoza2015-04-022-61/+2
|\ \ \ \ \ \ \
| * | | | | | | Revert "libgui: Plumb attach/detach through CpuConsumer"Dan Stoza2015-04-022-61/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 20c5672883796c0dedf38f51dc2fc6f140b09ae6.
* | | | | | | | Parcel.cpp: reject size_t arguments greater than INT32_MAXNick Kralevich2015-04-021-13/+137
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's a security best practice for size_t values to be rejected if they are greater than INT32_SIZE. This is intended to prevent the common error of inadvertently passing a negative int value to a function, which after conversion to an unsigned type, becomes a huge number, defeating the purpose of bounds checking. This patch also addresses a bug where the call to: Parcel::write(buf, (size_t) -1); would call writeInPlace() which uses PAD_SIZE on the supplied argument. This would then cause an integer overflow, with PAD_SIZE returning a small value, but the memcpy in Parcel::write using the old large length value. Bug: 19573085 Change-Id: Ib11bfb3dae4f3be91cd17b2c676926700972c7b8
* | | | | | | Merge "Add backwards compatible versions of IInterface::asBinder()"Marco Nelissen2015-03-311-0/+21
|\ \ \ \ \ \ \
| * | | | | | | Add backwards compatible versions of IInterface::asBinder()Marco Nelissen2015-03-311-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes apps linked against the previous non-static versions work with the new libbinder. Bug: 19060033 Bug: 19773812 Change-Id: I3b5c78cbb4f4c0681ca1042e4d8503d98f969502
* | | | | | | | Support restricted mode in SensorService.Aravind Akella2015-03-242-4/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In restricted mode, only CTS tests can register for sensors or call flush() on them. The requests from other applications will be ignored. Change-Id: Ieb923df3e0cfe3390fe2d052af776da79589744b
* | | | | | | | binder: add uint64 support to Parcel.Ronghua Wu2015-03-191-0/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug: 19620911 Change-Id: Ifce5319e4e35afd344dead67ab7ba1cd399476a3
* | | | | | | | Merge "libgui: Plumb attach/detach through Surface"Dan Stoza2015-03-191-0/+49
|\ \ \ \ \ \ \ \
| * | | | | | | | libgui: Plumb attach/detach through SurfaceDan Stoza2015-03-161-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Exposes the attachBuffer and detachNextBuffer calls from IGraphicBufferProducer to the public Surface interface. Also moves the version of connect that takes a producer callback from protected to public. Bug: 19628705 Change-Id: I9ebc3013c4d9c84c4e8ef150c00e03f8af80319e
* | | | | | | | | libgui: Plumb attach/detach through CpuConsumerDan Stoza2015-03-172-2/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds CpuConsumer::{detachNextBuffer,attachAndReleaseBuffer}, which can be used to more carefully manage the ownership of GraphicBuffers. Bug: 19628705 Change-Id: Ia7a7e30da6d81eb2367241998f14988db0afc3bf
* | | | | | | | | Revert "libgui: Plumb attach/detach through CpuConsumer"Dan Stoza2015-03-172-61/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43078e2827211139f0614719c920f3c5bff6c3fa. Change-Id: Ifef774d9922bb90450384e810e4767b56cc29de3
* | | | | | | | | libgui: Plumb attach/detach through CpuConsumerDan Stoza2015-03-162-2/+61
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds CpuConsumer::{detachNextBuffer,attachAndReleaseBuffer}, which can be used to more carefully manage the ownership of GraphicBuffers. Bug: 19628705 Change-Id: Ia7aa1ac59c2f768f2d8a0f35ad23067936a7427c
* | | | | | | | | libgui: Remove IGBC::BufferItemDan Stoza2015-03-167-257/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removes IGraphicBufferConsumer::BufferItem. Depends on the following changes: I187b3a7d05196b6289596afac8fb9a9d4aebff76 I0ddd38df37500cfd6b21d1e768ed14e39c5cd9fc Change-Id: Id1fa56d092188f2cb712768d5d2fc6a9027fb73c
* | | | | | | | | libgui: Fix infinite recursionDan Stoza2015-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the overloads of BufferQueueConsumer::acquireBuffer was calling itself infinitely instead of calling the other overload. This fixes that issue. Bug: 19733425 Change-Id: Iac8425e1241774304a131da2fb9dec6e82922f13
* | | | | | | | | libgui: Prepare for IGBC::BufferItem removalDan Stoza2015-03-127-13/+53
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Switches some dependencies from IGraphicBufferConsumer::BufferItem to android::BufferItem and adds some methods to facilitate incrementally changing client code to do the same. Change-Id: I699ed0a6837076867ca756b28d1ffb2238f7a0d9
* | | | | | | | | libgui: Add a BufferItem overload to IGBC::acquireDan Stoza2015-03-112-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds an overload of IGraphicBufferConsumer::acquireBuffer which takes an android::BufferItem instead of an IGBC::BufferItem. Change-Id: I9c3bc8037fa9438d4d9080b8afb694219ef2f71f
* | | | | | | | | libgui: Add BufferItem(IGBC::BufferItem)Dan Stoza2015-03-111-0/+15
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a constructor for building a BufferItem from an IGraphicBufferConsumer::BufferItem. Change-Id: I1394e693314429ada93427889f10b7b01c948053
* | | | | | | | Merge "Add dataSpace to buffer queues; remove old format enums."Eino-Ville Talvala2015-03-0618-35/+168
|\ \ \ \ \ \ \ \
| * | | | | | | | Add dataSpace to buffer queues; remove old format enums.Eino-Ville Talvala2015-03-0418-35/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Wire up new dataSpace parameter through buffer queue stack - Update tests to include the parameter - Switch eglApi to using dataSpace to indicate sRGB gamma/linear difference - Remove RAW_SENSOR in favor of RAW16 - Remove use of sRGB format enums - Add default dataspace to buffer queue core - Add query for default dataspace Change-Id: I070bd2e7c56506055c419004c29e2e3feac725df
* | | | | | | | | Merge "Surface: Permit an IProducerListener on connect"Dan Stoza2015-03-061-1/+5
|\ \ \ \ \ \ \ \ \
| * | | | | | | | | Surface: Permit an IProducerListener on connectDan Stoza2015-03-021-1/+5
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change allows clients of Surface to provide an IProducerListener callback object to Surface::connect, which will be passed down to the underlying IGraphicBufferProducer. Change-Id: I5ea5229bf3a329bf02c6bd20e7247039c75d136b
* | | | | | | | | GLConsumer: Fix unsigned subtraction during cropDan Stoza2015-03-041-6/+6
|/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since some variables had been switched from signed to unsigned, there was a section of code that was guaranteed to be incorrect because it effectively did 'if (a < b) { c = a - b; }'. This change fixes it. Bug: 19346631 Change-Id: I9cdd6c9a0179801addebb5d6dc1fbaddf8f53c62
* | | | | | | | am 58573ecd: am 485d3730: am f3f22e55: Merge "Add missing <unistd.h> include ↵Elliott Hughes2015-02-201-0/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | for close." * commit '58573ecdd201f3c678a68377f682e64ddaef0be6': Add missing <unistd.h> include for close.
| * \ \ \ \ \ \ \ am 485d3730: am f3f22e55: Merge "Add missing <unistd.h> include for close."Elliott Hughes2015-02-201-0/+1
| |\ \ \ \ \ \ \ \ | | | |/ / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | * commit '485d3730042381ed203e312ad70fec9cb0d2d934': Add missing <unistd.h> include for close.
| | * | | | | | | am f3f22e55: Merge "Add missing <unistd.h> include for close."Elliott Hughes2015-02-201-0/+1
| | |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * commit 'f3f22e555bae8e362f3cac1efb289ca321266035': Add missing <unistd.h> include for close.
| | | * | | | | | | Add missing <unistd.h> include for close.Elliott Hughes2015-02-191-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Iebce6d74eecb8c275e800b7f47f74bbd4374860d
* | | | | | | | | | am a4201c10: am 592cc33c: am e86f7e96: am 3c0272ba: am dc2d031a: am ↵Michael Lentine2015-02-191-1/+5
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | da9fd70d: am 2758eb2e: am fde92eb0: Update maxNumber to be smaller. * commit 'a4201c10aeb977a6e4e8c1bcb9ceca5ab591d0ad': Update maxNumber to be smaller.
| * | | | | | | | | am 592cc33c: am e86f7e96: am 3c0272ba: am dc2d031a: am da9fd70d: am ↵Michael Lentine2015-02-191-1/+5
| |\ \ \ \ \ \ \ \ \ | | |/ / / / / / / / | |/| | | / / / / / | | | |_|/ / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | 2758eb2e: am fde92eb0: Update maxNumber to be smaller. * commit '592cc33c408d5c91ad87e1a51d72269d4525a10b': Update maxNumber to be smaller.
| | * | | | | | | am e86f7e96: am 3c0272ba: am dc2d031a: am da9fd70d: am 2758eb2e: am ↵Michael Lentine2015-02-191-1/+5
| | |\ \ \ \ \ \ \ | | | | |_|/ / / / | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fde92eb0: Update maxNumber to be smaller. * commit 'e86f7e96a75a7bf7bfa85d52cd9f2145fe25878c': Update maxNumber to be smaller.
| | | * | | | | | am 3c0272ba: am dc2d031a: am da9fd70d: am 2758eb2e: am fde92eb0: Update ↵Michael Lentine2015-02-191-1/+5
| | | |\ \ \ \ \ \ | | | | | |_|/ / / | | | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | maxNumber to be smaller. * commit '3c0272ba8fbb98b5f1d45c52b1ae5292a8978e7d': Update maxNumber to be smaller.