| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Check that passed buffer is in current buffer
source list. If no, return the buffer to caller
instead of getting out of range.
Change-Id: I3acef6514049d1e1009f91ec4ec62688974223a1
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It is impossible to use some V4L devices (e.g. uvc) using blocking API.
In order to avoid deadlocks while recording video we have to use
non-blocking dequeue in a loop.
Change-Id: I7d41170c188b412a0a06553ab64ae53eb56ba3af
Signed-off-by: Nikita Borodikhin <nikita.borodikhin@ti.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Weaken camera strong dependency on orientation sensor which causes it to
crash in case the sensor is absent, e.g. on Panda.
Change-Id: I276c862878e0a99abb52122fa98c50e067f54f22
Signed-off-by: Nikita Borodikhin <nikita.borodikhin@ti.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes a problem introduced in commit e9bf3ac2. Instead of
specialized method getPictureBufferSize base classes stub is being
always. That led to allocating zero-length snapshot data buffer and
failure to get snapshot.
Change-Id: I36585d7801a788c19be753e2fdbe0f2d056509d9
Signed-off-by: Nikita Borodikhin <nikita.borodikhin@ti.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This patch restores
"CameraHal: Omit flush buffers when disabling image capture"
which was lost after merge of p-jb-release into d-jb-release
because of conflict in OMXCapture.cpp.
Change-Id: I6c9bc02bc6c08dba72f44c4e028b3244dd8d6401
Signed-off-by: Andrii Kulian <andrii.kulian@ti.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Introduce mPendingReprocessSettings, so we can setFormat inside
UseBuffersReprocess instead of setParametersReprocess. We will
later use this mechanism to determine if port settings need to
be reconfigured in NPA-like mode.
Change-Id: I8fc485fc0f84c11bb293a49894090ea6a28b3c47
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Move decision to disable capture port from setParameters to functions
called in the state machine (getPictureBufferSize and
UseBuffersCapture). This will help avoid calling the disable port code
multiple times if user changes settings. It will also keep the capture
from being disabled asynchronously from state changes.
Since decision to disable port is moved to UseBuffersCapture, logic to
skip UseBuffers for subsequent captures changes slightly. Instead of
skipping if capture port is configured, we skip if no settings have
changes that require SetParam have changed.
As part of code movement, capture is no longer disabling reprocess.
The decision to disable reprocess will be moved to the reprocess
file.
Change-Id: I878c4cc1cc4985a762afcae686ba51a072c25836
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
- Added missing initialization of the buffer tracking counters:
'mCapturedFrames', 'mBurstFramesAccum' and 'mBurstFramesQueued'.
Change-Id: I2788c7f9f82c7e806c2817f603381ad2e095eecb
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| |\
| | |
| | |
| | | |
Change-Id: I1808c4a4eff20f987643072d1f560e4fe85e9717
|
| |\ \
| | | |
| | | |
| | | | |
Change-Id: I5846453a07de05891544684fd524c546579d957c
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit cd6eeab5eada7354dad580d91e801f9681514f5d.
Fixes an instability seen with image capture robustness tests
"flushBuffers - Exiting function flushBuffers because of ret -1
eError=0"
Change-Id: Ic1dee320429397d28d48d16faa91991b843c9572
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Initially queued preview buffers were triggering false
"Buffer was never with Ducati" error in debug build.
Change-Id: I70c310d02bd284c0c532a3b72157c651eb68a20b
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| |\ \ \
| | | | |
| | | | |
| | | | | |
Change-Id: I0760b135e56d22fc02e49d1344af734e0dcf81be
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
This patch improves the PPM numbers for Camera
Change-Id: I1ca1aaaee1ea37992a2717530361429b012377c9
Signed-off-by: Georgi Georgiev <x0154504@ti.com>
|
| |\ \ \ \
| | | | | |
| | | | | |
| | | | | | |
Change-Id: I649b0c53d1c0e8f56e059a3cb24a38089d8fccc4
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- Set the crop rectangle for surface texture, so
surface texture can compute transform matrix
that will be used by applications.
Change-Id: I6e245c99ac3196518d8a9ee83c162d3ce380b7e9
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
- AppCallbackNotifier was trying to copy and crop
compressed image frames during reprocessing. This
might lead to arithmetic faults when the frame
fields are not fully initialized as in the case of
compressed images.
Change-Id: Ic7d6eb71aee546d7f5619075a6070a861ebcacb0
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
|
| |\ \ \ \ \
| | | | | | |
| | | | | | |
| | | | | | | |
Change-Id: Iec5798f854fdcac8bdbe6f5ab2ef8d17c7224696
|
| |\ \ \ \ \ \
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
omap-mirror/d-jb-release
Conflicts:
camera/ANativeWindowDisplayAdapter.cpp
Change-Id: Ia08eb7c3eb8bedefbc1cff49487e57e26a827765
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| |\ \ \ \ \ \ \
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Conflicts:
camera/inc/CameraHal.h
Change-Id: I826ef084fe01e8b5682d8a78c7cec76b39043d45
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Use a common MemoryManager instance in the various OMXCameraAdapter
modules that use it.
Change-Id: I5a2e957345dafb3ccbd305b8e589ed1822a289fe
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Fill format field in the BufferProviders (MemoryManager,
ANativeWindowAdapter, BufferSourceAdapter), so the format of the
buffer is known to the consumers.
Change-Id: I7b5fbb3e7da107735de98669d3d9889a4bff6097
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Need to account for bytes per pixel when sending stride received
from CameraAdapter to BufferProvider. CameraAdapter will send stride
in bytes but BufferProvider expects stride in pixels.
Change-Id: I80512e888b385a42cc9345da34c77fb0e2c19f78
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Missed the JPEG format in the getPixFormatConstant method.
Change-Id: I5a36bc3f0cf8fffdebb2b6dc39f01854be7ed34d
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Move logic to get x, y crop position for a given offset
and format to a common utility function.
Change-Id: I6e900ee7938f012c70939ccdfaf3b4a252bd7957
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Use common functions for calculating buffer size and
getting image format constant since they are used in several
places in CameraHal. The common functions are implemented
as static functions in the CameraHal class.
Change-Id: I242435ebcdebea0bc9a7452a5dc38e3f96f5be11
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Add functionality in AppCallbackNotifier to send cropped
NV12 raw frame callback. We hit this when doing NV12
capture or reprocess with LDC/NSF.
Change-Id: I72d0322a267fd2aecfeb7daebb312e571d955a52
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Changing the behavior of the self restart mechanism when display
is in paused mode. Previously, we were just triggering the stopPreview
call. Now, preview is restarted but with the display in paused mode.
Change-Id: Iba39a3533244f54cf9d795b28722a6c73d499f9a
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Threads in buffer source adapter were not being released correctly,
which lead to them being orphaned. Previous logic relied on the
Thread destructors getting called to wake up the threads for them
to exit, but the destructors were not getting called since it still
had child threads.
This patch implements the virtual requestExit function for each
Thread class. Each implementation wakes its respective thread if
it is waiting, so the thread can exit.
Change-Id: I95c42a05ce76d6241b073c5927ecb81365562066
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Will use condition and mutex in ReturnFrame class
instead of semaphore.
Change-Id: I78cf9be12615596ae31f88f908935761f861d413
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Add IPP to list of settings that can trigger a
preview restart. OMXCameraAdapter needs to be
in loaded state for IPP to take effect.
Change-Id: I5f5aa9a99c33ad7711cb25349be767714398041f
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
- The parameters to 'getExtraData()' did change
recently so the OMX profiling modification needs
be updated accordingly.
Change-Id: I4d051ec0836af2c47d15446825d835baf40402a0
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
This approach should display the PPMs before queuing
the buffer to display.This is also done even the display is
not started or paused.
Change-Id: Id4a4e125f805f84a419c29f1a58793b2301d075f
Signed-off-by: Georgi Georgiev <x0154504@ti.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Currently, following case is not handled properly
in CameraHal::setParameters():
1. Preview is not running.
2. There are changed any parameters that required
an update inside camera adapter.
3. There are changed any parameters that required
a preview restart.
Change-Id: I57cd9b970ec0678dffcd002dcd65ffc754784c10
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
- 'mBufferSourceAdapter_Out' and 'mBufferSourceAdapter_In'
were not being cleared and as a result the reference count
to their associated BufferSoruceAdapters was kept above
zero throughout CameraHals destructor. The count goes to
zero upon leaving the destructor, which triggers their
destruction but at this point the CameraAdapter reference
is invalid ( the CameraAdapter got destroyed before that)
and every access or call to it will result in a segfault.
Change-Id: I23b2c59789eb47ba02884a46982ae10a18e4916b
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
- Fixes an issue with CTS test testSceneMode
Change-Id: I2aebb2f9894d5f31351b29de161b8f5dade035a8
Signed-off-by: Dimitar Borisov <x0152684@ti.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Fixes regression introduced with change I3e5eec25:
Revert "CameraHAL: Adds support for controlling
the FD update interval"
Currently, CameraHal is emmiting preview metadata callbacks
to the Camera application with every preview frame.
But in most cases, there is no any difference between the metadata
of two consecutive frames. So, tracking of metadata changes
would be used in order to send metadata callbacks only if
metadata is different compared to one already sent to
the application. Ie93c6ae5 (Adds support for controlling the FD
update interval) had a disadvantage to add undesired delay when
sending metadata in range (0 ~ 400 ms).
Change-Id: I481a78020a040153f792a3ef9e095b59ea7003e0
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Move mLock to protect mBuffers check in handleFrameCallback.
need to protect the check in case mBuffers is freed.
Change-Id: I1849cca245c2ed57380e615cd916db2d7d9400b4
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Flush the buffers before calling FreeBuffer on them to
prevent FillBufferDone call to access the buffers after/
during FreeBuffer call.
Change-Id: I026c9c99095649888acb28bbf7d9f06cd776eea3
Signed-off-by: Tyler Luu <tluu@ti.com>
Signed-off-by: Vladimir Petrov <vppetrov@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
OMX convergence is applied only on preview port, not on all OMX ports.
Change-Id: If84665671a761c08da34a1f5e8f4461394c1929d
Signed-off-by: Pavel Nedev <pnedev@mm-sol.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
- The new capture mode is added through a compile
time flag for OMAP5 exclusively.
Change-Id: Ida43b611783ce15a2c34371ef4cad98bfa03f379
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Using mBuffersWithDucati simultaneously from separate threads
causes race condition in debug mode.
Change-Id: Ie24546dce12ff6f516a74fcf4887c4e8073ff8e0
Signed-off-by: Daniel Levin <dendy@ti.com>
|
|\ \ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Conflicts:
camera/Android.mk
camera/MemoryManager.cpp
Change-Id: Ibe1f6706293903b50cc7d48d7de8dd9448b981e4
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| | |_|_|_|_|_|_|/
| |/| | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: Ic4dac15142d1947f66d316934100adabea046c47
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| |\ \ \ \ \ \ \ \
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Change-Id: I3e635112ca07a956e7c57619e05bc9413106792e
Signed-off-by: Daniel Levin <dendy@ti.com>
|
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | |
| | | | | | | | | | |
Fixes an issue with robustness test case where
flushBuffers returns error and the test case hangs
Change-Id: I83c2b1bc79a580fc32c490d47018b3084d305e5e
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
|
| |/ / / / / / / /
| | | | | | | | |
| | | | | | | | |
| | | | | | | | |
| | | | | | | | | |
Change-Id: I40cd8ec280da435ef00ba619f06fa37204df0197
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
|
| |\ \ \ \ \ \ \ \
| | | |_|_|_|_|/ /
| | |/| | | | | /
| | |_|_|_|_|_|/
| |/| | | | | | |
Change-Id: Ie8a95e38ecb9f9a6b59de6f1df962df071cc55ab
|
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | |
| | | | | | | | |
- Switching states of the OMX Component is no longer
needed for camera capability query.
- Move DCC loading to HAL layer from DOMX to expose
it to customer.
Change-Id: Iec65757526933b26f7bdd9f4cb4bead527ff5f84
Signed-off-by: Keidy Kim <keidy.kim@ti.com>
Signed-off-by: Emilian Peev <epeev@mm-sol.com>
|
| | |_|_|_|_|/
| |/| | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
Rotation cannot be applyed on unconfigured preview port due to
it has non nv12 default pixel format. Therefore - set orientation
will return error and unexpected dimensions will be returned to
frame allocator.
Change-Id: I31c755c3da68ac65fd61daeaa69861ae18f01798
Signed-off-by: Andriy Chepurnyy <x0155536@ti.com>
|