diff options
| author | NeilBrown <neilb@suse.de> | 2012-02-19 13:11:32 +1100 |
|---|---|---|
| committer | Paul Kocialkowski <contact@paulk.fr> | 2013-05-05 11:32:02 +0200 |
| commit | 5885de04caf2af83c60957c9413e49129b2a9cb3 (patch) | |
| tree | c6ec880db75f3c6b44602bf2cc4af2cff0350389 | |
| parent | de93b64e31ab906db27f5495cfc3e395af933e35 (diff) | |
| download | kernel_goldelico_gta04-5885de04caf2af83c60957c9413e49129b2a9cb3.zip kernel_goldelico_gta04-5885de04caf2af83c60957c9413e49129b2a9cb3.tar.gz kernel_goldelico_gta04-5885de04caf2af83c60957c9413e49129b2a9cb3.tar.bz2 | |
bq27x00 - don't report power-supply change so often.
A power_supply_changed should only be reported on significant changes
such as transition between charging and not. Incremental changes
such as charge increasing should not be reported - that can easily
be polled for.
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/power/bq27x00_battery.c | 15 |
1 files changed, 12 insertions, 3 deletions
diff --git a/drivers/power/bq27x00_battery.c b/drivers/power/bq27x00_battery.c index bb16f5b..7993a17 100644 --- a/drivers/power/bq27x00_battery.c +++ b/drivers/power/bq27x00_battery.c @@ -57,11 +57,15 @@ #define BQ27000_FLAG_CHGS BIT(7) #define BQ27000_FLAG_FC BIT(5) +#define BQ27000_FLAGS_IMPORTANT (BQ27000_FLAG_FC|BQ27000_FLAG_CHGS|BIT(31)) + #define BQ27500_REG_SOC 0x2C #define BQ27500_REG_DCAP 0x3C /* Design capacity */ #define BQ27500_FLAG_DSC BIT(0) #define BQ27500_FLAG_FC BIT(9) +#define BQ27500_FLAGS_IMPORTANT (BQ27500_FLAG_FC|BQ27500_FLAG_DSC|BIT(31)) + #define BQ27000_RS 20 /* Resistor sense */ struct bq27x00_device_info; @@ -259,6 +263,7 @@ static void bq27x00_update(struct bq27x00_device_info *di) { struct bq27x00_reg_cache cache = {0, }; bool is_bq27500 = di->chip == BQ27500; + int flags_changed; cache.flags = bq27x00_read(di, BQ27x00_REG_FLAGS, is_bq27500); if (cache.flags >= 0) { @@ -280,10 +285,14 @@ static void bq27x00_update(struct bq27x00_device_info *di) /* Ignore current_now which is a snapshot of the current battery state * and is likely to be different even between two consecutive reads */ - if (memcmp(&di->cache, &cache, sizeof(cache) - sizeof(int)) != 0) { - di->cache = cache; + flags_changed = di->cache.flags ^ cache.flags; + di->cache = cache; + if (is_bq27500) + flags_changed &= BQ27500_FLAGS_IMPORTANT; + else + flags_changed &= BQ27000_FLAGS_IMPORTANT; + if (flags_changed) power_supply_changed(&di->bat); - } di->last_update = jiffies; } |