Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | block: Fix overrun in lcm() and move it to lib | Martin K. Petersen | 2010-03-15 | 1 | -0/+15 |
lcm() was defined to take integer-sized arguments. The supplied arguments are multiplied, however, causing us to overflow given sufficiently large input. That in turn led to incorrect optimal I/O size reporting in some cases (RAID over RAID). Switch lcm() over to unsigned long similar to gcd() and move the function from blk-settings.c to lib. Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> Signed-off-by: Jens Axboe <jens.axboe@oracle.com> |