From d61975fc6b40dadd2cd61fc9535499c7d7b806de Mon Sep 17 00:00:00 2001 From: Eugene Teo Date: Fri, 17 Mar 2006 16:32:52 +0100 Subject: [ALSA] Fix gus_pcm dereference before NULL Modules: GUS Library The NULL check of substream is simply superfluous. It is guaranteed to receive non-NULL substream. Thanks Takashi. Coverity bug #861 Signed-off-by: Eugene Teo Signed-off-by: Takashi Iwai --- sound/isa/gus/gus_pcm.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'sound/isa/gus') diff --git a/sound/isa/gus/gus_pcm.c b/sound/isa/gus/gus_pcm.c index d082939..c7f95e7 100644 --- a/sound/isa/gus/gus_pcm.c +++ b/sound/isa/gus/gus_pcm.c @@ -114,8 +114,6 @@ static void snd_gf1_pcm_trigger_up(struct snd_pcm_substream *substream) unsigned char pan; unsigned int voice; - if (substream == NULL) - return; spin_lock_irqsave(&pcmp->lock, flags); if (pcmp->flags & SNDRV_GF1_PCM_PFLG_ACTIVE) { spin_unlock_irqrestore(&pcmp->lock, flags); -- cgit v1.1