From 082e24d702a87372e43fac4da1da104a7326ebb0 Mon Sep 17 00:00:00 2001 From: "Mike J. Chen" Date: Fri, 10 Jun 2011 12:22:49 -0700 Subject: OMAP: mcbsp: Fix error checks of rx_irq. rx_irq is intialized via a call to platform_get_irq_byname(), which can return a negative error value. Also, zero is a valid irq. Fix checks that assumed non-zero values were the only valid rx_irq values. Change-Id: I6be171eefa5923021e4adccf71f21baad3383554 Signed-off-by: Mike J. Chen Signed-off-by: Ruslan Bilovol --- arch/arm/plat-omap/mcbsp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'arch/arm/plat-omap') diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index eb1ae5b..7b0d9b7 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -833,7 +833,7 @@ int omap_mcbsp_request(unsigned int id) goto err_clk_disable; } - if (mcbsp->rx_irq) { + if (mcbsp->rx_irq >= 0) { init_completion(&mcbsp->rx_irq_completion); err = request_irq(mcbsp->rx_irq, omap_mcbsp_rx_irq_handler, @@ -891,7 +891,7 @@ void omap_mcbsp_free(unsigned int id) if (mcbsp->io_type == OMAP_MCBSP_IRQ_IO) { /* Free IRQs */ - if (mcbsp->rx_irq) + if (mcbsp->rx_irq >= 0) free_irq(mcbsp->rx_irq, (void *)mcbsp); free_irq(mcbsp->tx_irq, (void *)mcbsp); } -- cgit v1.1