| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
CharsetDecoderICU and CharsetEncoderICU special-case array-backed ByteBuffers
and CharBuffers for performance reasons, but they shouldn't assume that the
backing array always has offset 0.
An external user hit this while using the jAudioTagger library.
Test cases from user submission:
http://code.google.com/p/android/issues/detail?id=4237
See also: 2234697
|
|
|
|
| |
A lunchtime run of the full suite turned up more.
|
| |
|
|\
| |
| |
| |
| | |
* changes:
Remove @KnownFailure from a bunch of tests that now pass.
|
| |
| |
| |
| | |
Looks like we got some of our Locales back.
|
|/ |
|
| |
|
|
|
|
|
|
|
|
| |
dalvikvm sets "user.name" to $USER, but that environment variable isn't set
when we run the tests. I was looking at our DatagramSocketTest failure, and
it turns out it's another instance of "root can do stuff other users can't".
The typical way harmony tests check whether they're running as root is to
compare "user.name" against "root", but from run-core-tests they see "".
|
|\
| |
| |
| |
| | |
* changes:
Kill OSNetworkSystem.inheritedChannelImpl.
|
| |
| |
| |
| |
| |
| |
| |
| | |
This code is broken (and more broken than upstream), and not obviously relevant
to our platform. Let's make it clear that all this currently does is return
null.
The changes in the Java side bring us back in sync with upstream.
|
|\ \
| | |
| | |
| | |
| | | |
* changes:
Supporting expected results for the jtreg test runner.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This is necessary to suppress false positives when dalvik
intentionally differs from the RI. This came up in the fix
for issue 2224903.
Also adding additional features to the jtreg runner to make
it useful as an iterative development tool:
- debugger support, to debug through running tests
- verbose output, to aid in diagnosing hangs
Also adding a few ".expected" files for known test failures.
Hopefully this is scalable.
Renaming Run to TestRun and extracting Result as a top-level enum.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* changes:
Fixing PipedWriters/PipedOutputStreams silent failures during close().
|
| |/ /
| | |
| | |
| | | |
See bug 2224903 and jtreg test java.io.BufferedWriter.Cleanup.
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
* changes:
Jit - optimized inline string compareto, indexof; fill_array_data bug fix
|
| | |
| | |
| | |
| | |
| | | |
Added flushAllRegs() prior to C handlers in preparation for upcoming support
for holding live/dirty values in physical registers.
|
| | |
| | |
| | |
| | | |
Change-Id: I5e33c3db160ae3af6e324492e0b6a7a0dfb9719b
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* changes:
More OSNetworkSystem cleanup.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
valgrind didn't like what we were doing here, specifically the way we
were setting ss_family to AF_INET if getsockopt IP_MULTICAST_IF didn't
return an AF_INET address, and ignoring the fact that the rest of
the sockaddr_storage doesn't necessarily correspond to an AF_INET address.
Linux seems to return an AF_UNSPEC address (rather than INADDR_ANY) if we
haven't set a multicast interface, so we have to do the conversion ourselves.
More disturbingly (and unfixed by this patch) we sometimes see ss_family
come back as 127 (when AF_MAX is 32 on our system). My guess is that the
kernel is just handing back bad data we gave it earlier, but I'll come back
to see about fixing multicast properly later.
I've inlined socketAddressToString into osNetworkSystem_byteArrayToIpString,
its only caller, because it's clearer that way now we've simplified the
division of error handling between the two.
I've brought getSocketLocalAddressImpl and getSocketLocalPortImpl in line
with each other and changed them to at least log errors. I've also added
a new test that fails, to demonstrate that this implementation is broken
as designed.
I've changed the name of JAVASOCKOPT_IP_MULTICAST_IF to match the Java
constant.
I've fixed the exception we throw if we're asked to convert a bad address
family's address from code that can't throw IOException --- AssertionError
doesn't have a String constructor. Really, we need to kill this code, so
I've added a TODO.
I've also made a real push to get rid of most of the SOCKERR_*-based error
reporting. (I had a transient failure with a meaningless error message
that sent me to the source to work out which errno it was actually
trying to report.)
I've changed setTTL to call setTimeToLive, and change the implementation
of the latter to pass Integer rather than Byte to the native implementation,
since that's what the native code needs anyway and native Byte support was
only for TTL.
Bug: 2225748
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* changes:
Update logging to r820767
|
| | | | |
|
|\ \ \ \
| |_|/ /
|/| | |
| | | |
| | | | |
* changes:
Fixing 1 of the 4 BufferedReader test failures in bug 2224903.
|
| | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This CL includes the following functional changes:
- changing read to not clear the mark upon reading EOF
- changing read(char[], int, int) to use the 'read
directly from the source stream' shortcut when the
mark has exceeded its limit. Previously we took the
shortcut only when the mark was unset.
And these nonfunctional changes
- rewrote read(char[], int, int) dramatically. The new
revision contains only one call to 'System.arrayCopy'
and the related bookkeeping. Previously there was one call
before the loop, and another call in the loop.
- renamed markpos to mark
- renamed marklimit to markLimit
- renamed count to end (it isn't a count, it's a position)
- simplifying conditions that used >= when > was impossible
- reducing the number of field reads where convenient
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* changes:
Rewrite NativeBN_twosCompFitsIntoBytes.
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
valgrind complains about invalid 4-byte reads, caused by "case 8" in the
BNInterface.c function I'm removing here, which assumed that if we're checking
whether a BIGNUM fits in 8 bytes, it must require more than 4 bytes (and so
accessing d[1] is acceptable).
We can implement this in Java using the existing BigInteger.bitLength
method (which may call down to native code, but that native code looks okay).
Also remove a related commented-out method.
Bugs: 2223213, 2225642
|
| | | |
|
|\ \ \
| |/ /
|/| |
| | |
| | | |
* changes:
Major registor allocation rework - stage 1.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Direct usage of registers abstracted out.
Live values tracked locally. Redundant loads and stores suppressed.
Address of registers and register pairs unified w/ single "location" mechanism
Register types inferred using existing dataflow analysis pass.
Interim (i.e. Hack) mechanism for storing register liveness info. Rewrite TBD.
Stubbed-out code for linear scan allocation (for loop and long traces)
Moved optimistic lock check for monitor-enter/exit inline for Thumb2
Minor restructuring, renaming and general cleanup of codegen
Renaming of enums to follow coding convention
Formatting fixes introduced by the enum renaming
Rewrite of RallocUtil.c and addition of linear scan to come in stage 2.
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* changes:
Remove broken .so and fix bogus test.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
valgrind doesn't like this because the .so *only* exists for x86 (contrary to
the claim in the @AndroidOnly annotation) but it's broken there, returning
a char* instead of a jstring.
I'm not really sure what they were trying to test here, but let's assume it
was that Runtime.getRuntime().load behaves like System.load, and fix the
tests that way.
Bug: 2223234
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
* changes:
Change the jtreg tool to perform both building and running steps.
|
| | | | |
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
* changes:
Make run-core-tests with no arguments equivalent to tests.AllTests.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Previous behavior would run the same set of tests, but without going through
the regular pre- and post-processing, and without initializing the command-line
flags to their default values.
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
* changes:
Script for compiling and dexing jtreg tests for Dalvik.
|
| | |/
| |/| |
|
|\ \ \
| |_|/
|/| |
| | |
| | | |
* changes:
Implement ProcessBuilder.redirectErrorStream.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Also simplify and correct the security to ensure that the user can't modify
the command to be executed after the SecurityManager has approved it.
Bug: 2180063
|
| |/
|/|
| |
| | |
Bugs: 2099642, 2099637
|
|/
|
|
|
|
|
|
|
|
|
|
| |
Removing OSNetworkSystem.sendStream brings us in line with harmony. I've
also rewritten writeSocketImpl to not make a temporary copy of the data it's
going to send.
The weird code in writeSocketDirectImpl that threw ErrorCodeException turns out
to be a very awkward way of returning zero to the only two callers that are
paying attention. (Harmony actually calls the equivalent of this code every
time it throws SocketException from native code, but these two callers were
the only places that checked for the special case.)
|
|
|
|
| |
Change-Id: Ie157d9305df5f9b86a09ea2224666fd2c054cda4
|
|\
| |
| |
| |
| | |
* changes:
Clone TEMP_FAILURE_RETRY in JNIHelp.h, to make up for (take your pick) laggard libc implementations not keeping up with the times or (perhaps) agressively modern libc implementations too eagerly expanding upon the standard.
|
| |
| |
| |
| |
| |
| |
| |
| | |
laggard libc implementations not keeping up with the times or
(perhaps) agressively modern libc implementations too eagerly
expanding upon the standard.
Change-Id: I4c4d050d15a00f4e82f8beb2b9c386b7c652f495
|
|\ \
| |/
|/|
| |
| | |
* changes:
Remove dead native org.apache.harmony.nio.AddressUtils code.
|
| |
| |
| |
| |
| |
| | |
This code is dead at the moment, and were it ever to become live, I'm pretty
sure we'd want to start again from scratch rather than do whatever the author
of this had in mind.
|
|\ \
| |/
|/|
| |
| | |
* changes:
Split libcore/Android.mk into two files, one for Java code and one for native code, and make each have a set of rules for building on the host.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
native code, and make each have a set of rules for building on the host.
I also tightened up how sub.mk processing works and documented it
a little better.
Change-Id: I8a7a4c5697b2f22c4d69941dba381d6452200911
|
|\ \
| | |
| | |
| | |
| | | |
* changes:
Switch ProcessManager and System over to C++.
|
| | |
| | |
| | |
| | |
| | | |
Bug 2180063 will require changes to ProcessManager, so now's a good time
to make the switch in this directory.
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| | |
Should fix VM crashes in tests.java.sql.StressTest, which can now be
re-enabled.
I've also added a "throwoom" to the one place where this code
calls malloc but doesn't check the result.
Bug: 2213053
|