| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
The test is broken and is being suppressed:
com.android.org.apache.harmony.sql.tests.java.sql.DataTruncationTest
Bug: 17342415
Change-Id: I5dd2f506400fff7c290e27adf4d3bd34f0624044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the apache-harmony serialization tests is
package-sensitive.
The other tests suppressed probably broke due to a
fix in the Android fork of harmony (commit
19a270e90b1e992c1f6639f355ae13564c2f3a6a).
The code may be incorrect but if so it has
been broken subtly since Dec 2010. Bug 17433734
has been created to investigate.
Bug: 17394106
Change-Id: I654d82b607e5487e0e6614ec4bcc5be98a9394e9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed SocketHandler to re-introduce a "socket != 0"
check unintentionally removed by commit
232c91dce1760b180155256d1896d0d80375ff6d.
Some failures are the result of the test code being newer
than the libcore code. Android took its last libcore update
from apache-harmony some time after r820767 but before r929953
and its test-code update at r1097236. This explains a few
things.
Updated FileHandler to deal with null system properties.
This is an equivalent change to
http://svn.apache.org/viewvc?view=revision&revision=935099
Updated XMLFormatter to handle basic XML escaping. This is
an equivalent change to
http://svn.apache.org/viewvc?view=revision&revision=929953
Unsuppress tests that are fixed by this.
Bug: 13882147
Change-Id: I36321b488da6d4e08fbb0d28d0e366f9b06e6371
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add test suppression entries for differences known to be
caused by Android changes and failures that involve
java code fixes.
Some failures are the result of the test code being newer
than the libcore code. Android took its last libcore update
from apache-harmony some time after r820767 but before r929953
and its test-code update at r1097236. This explains a few
things.
java package fixes will be applied via a separate commit.
Bug: 13882147
Change-Id: Ie5f3d1e5bb80a6aa8e3341a3bceacc65a58b2ca3
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These are long-standing failures that we don't intend to
fix in the foreseeable future.
Developers have been encouraged to use android classes
for database access.
Bug: 17342415
Bug: 17321262
Bug: 17320961
Bug: 17093235
Change-Id: I30ed5576471253f58a63162347966dc11056cb31
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These all appear to work on host now given the correct classpath.
Bug: 3041920
Bug: 2931959
Bug: 3032875
Change-Id: Id1687652803df925d529ee4f3250b54d023c3f8f
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Scanner had no mechanism for recovering buffer space it didn't
need.
Now, if the buffer is more than 50% full of ignorable characters
the remaining characters are shuffled to the beginning to recover
space. For most expected usecases this means that the buffer will
stay 1k and contain up to 512 characters of useful data. A
growable, circular character buffer could have been introduced
to avoid the copy but is not worth the effort.
Previously the buffer would double in size until the data or memory
was exhausted, and each read would also double in size to fill the
empty half of the buffer. This was fine providing the input
could fit in memory.
On top of that the 1k, 2k, 4k, etc. buffer was repeatedly turned
into a String and passed to the (native) matcher, and then the
matcher was told to ignore more than half of it.
As a consequence of keeping the buffer a fixed size (and only
filling 50% of it at a time), this change may cause a performance
regression: for most usecases where delimiters are closer together
than 512 bytes, reads after the first will now usually be 512 bytes
and not the 1k, 2k, 4k, etc. it was previously.
Having fixed the test so it doesn't OOM, the test now
takes 6 minutes to pass on host and so is unsuitable for inclusion
in CTS tests and so is being suppressed.
This change also includes so tidy up changes to the test and the
Scanner class.
The implementation could no doubt be improved but the API makes
it inherently slow. It would be surprising if anybody uses the
Scanner class on Android with so many better alternatives.
Bug: 14865710
Change-Id: I40a7fc0c2bfaf6db4e42108efe417303e76bde24
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many of the tests were testing that the SqlLite Java API works.
Android does not ship with the SQLLite code as a public API
so these have been removed.
Some of the tests were testing JDBC APIs associated with Connection,
Driver and DriverManager behavior so these have been retained and
moved to libcore/java/sql/DriverTest.java / ConnectionTest.java
Change-Id: I97ec05591019505f527ee134177c5637bbd08538
|
|
|
|
|
|
|
|
|
|
| |
The _getInstance test was suppressed previously because it took
too long to complete. This re-enables parts of the test but
temporarily skips the DH algorithm until it can be investigated
further.
Bug: 5513723
Change-Id: Ia211de51f8def5b710c1d2a164f1ec70e474fc7a
|
|
|
|
|
| |
Bug: 5513723
Change-Id: Ied74f464faa88eef5d3c4d852a26bbdb60e415d4
|
|
|
|
|
|
|
|
| |
It was re-enabled by
If829a83cfcf82cac9a0301733b724716087fea05
but does appear to fail still.
Change-Id: If4c4c595856de111be228baaabe0598d102330c3
|
|
|
|
|
|
|
|
|
| |
Use expectations files instead.
(cherry picked from commit 6a6b612286976cc185c898803fe51e4e062bd9eb)
Bug: 12924356
Change-Id: I9b7e71805a80176c873cffe46bed65f81de1903d
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reasons I can do this are:
1) Fixes for other bugs / updates, etc. have made tests pass.
2) Bugs were fixed without removing suppressions.
3) Tests may have been suppressed by accident.
Tested on a local device running a master build.
Bug: 14808340
Change-Id: I7c6600c89ff1cc4ca5337ee952c972bdbf5467e8
|
|
|
|
|
|
|
|
|
|
|
| |
Most removals fit into these categories:
1) Test classes or methods that no longer exist / have been renamed
2) Various odd entries that are not for Junit
tests. Some appear to correspond with some Open-JDK tests so
may share a common heritage.
Bug: 14808340
Change-Id: If829a83cfcf82cac9a0301733b724716087fea05
|
|
|
|
|
|
|
|
| |
This is a removal of tests from org.apache.harmony.luni.tests
that no longer exist (under that package name).
Bug: 14808340
Change-Id: I99e87fc43018596e4be0f4b352cc9a7cc33da4cc
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issues here relate to how we deal with ambiguous wall
clock times, i.e, wall clock values that we "skip" when we
move the clock forward when transitioning into daylight
savings, and wall clock times that occur twice when we
move the clock backward
This isn't a regression. We've never handled this correctly.
bug: 12778197
Change-Id: Ida79583c02c6895096a8afdd8f59b1002b282d32
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- First, the test was broken pretty badly. It would pass a
Jar style URL to a FileURLConnection and expect it to
work, this is out of spec and seems wrong in general
(file:///foo.apk!resources/foo.txt).
- The RI supports various "headers" on file URL connections
(sigh). As if the getHeaderField(int) and getHeaderFieldKey(int)
APIs weren't bad enough. This has now been implemented with
a naive implementation.
- Fixes FileURLConnection to populate a header map for
information it provides (content length, content type
etc.)
bug: 11664881
Change-Id: I7a3e9aaa79bf125abbcfe8367574115ce54718e3
|
|\ \ |
|
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
org.apache.harmony.tests.java.util.ControlTest
The test is probably broken, but the code under test also looks
broken. Unpicking it all and fixing it all is low priority.
Marking it as known-broken until it can be given the attention it
deserves.
Change-Id: I0e2784aa505ace4ab86149741c2faf94d8432df9
Bug: 13747957
|
|/
|
|
|
|
|
|
| |
This fails on the RI and Android now. Add it to the known failures since
we don't deal with CRLs anyway.
Bug: 12905370
Change-Id: Id21af237aaa2709d71ffd3268a730fc4cf102d92
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The serialization tests revealed that some DecimalFormat instances
could not be round-tripped. The reason is that the setRoundingMode()
method was setting a non-zero rounding increment, which cannot
be persisted, and also creates patterns that are outside of the
DecimalFormat spec.
Addressed the fact that ICU4C appears to support
RoundingMode.UNNECESSARY now by deleting special-case code.
Changed SerializationStressTest to use canonical DecimalFormat
patterns:
The ones chosen had a couple things that were not ideal:
1) Putting '-' in quotes causes ICU (for non-obvious reasons)
treat the negative pattern prefix as not being default. Default
in this case means "the positive prefix with a preceding '-'.
Removing the quotes meant it would recognize the pattern as
not needing everything after ;., so the pattern would be shrunk.
2) The positive pattern was also not one ICU could deal with
fully. ICU changed "#.#" to "#0.#" at parse time (which can be
corrected with a setMinimumIntegerDigits(0)). It's not clear why
ICU cannot deal with parsing "#.#" when it can produce it, but
there is a long comment in decimfmt.cc suggesting it is
intentional and to avoid format producing empty strings.
The pattern has been changed to one that ICU can handle and would
choose when the various serialized fields are read back. This is
necessary because NativeDecimalFormat compares the patterns and
not just the serialized fields. Leaving the pattern check part of
equals() means that two non-spec patterns will not be considered
equal(), which is important while Android allows non-spec patterns.
Restricting support in DecimalFormat to the documented subset of
characters is not worth the effort and may cause problems
elsewhere.
Change-Id: I2de588458b86619733c0dc1692d526f179059910
Bug: 11668227
|
| |
| |
| |
| |
| |
| |
| | |
Our new OpenSSL-based SSLEngine supports all the new stuff and no longer
fails tests.
Change-Id: I7db8e5134ca36ebd963c7081cd7ba79d91b3e5e2
|
|/
|
|
|
|
|
|
|
|
| |
The tests could not work given the arrangement of classloaders
in Android apps. This also fixes a known failure case in
ClassLoaderTest which was due to missing resources. Also updated
ClassTest.
Change-Id: I114aa9b1a177911aed0aef87819d93a260f0b8d1
Bug: 12491655
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces NetworkChannel, but only bind() and
getLocalAddress() methods. To avoid breaking existing Android
applications that extend ServerSocketChannel, DatagramChannel and
SocketChannel the methods have been added with concrete
implementations that throw exceptions rather than leaving them
abstract.
In channel tests, usages of channel.socket().bind() and
channel.socket().getLocalSocketAddress() have been changed to
channel.bind() and channel.getLocalAddress(), since the behavior is
close enough and the tests should be written against the channel APIs
as much as possible. Tests have been added for new methods.
Removed further overriding in
DatagramChannelImpl.DatagramSocketAdapter and
SocketChannelImpl.SocketAdapter which revealed some bugs and lack of
clarity in the docs for the socket methods:
Improved the documentation for DatagramSocket.getLocalAddress(),
DatagramSocket.getLocalSocketAddress(),
ServerSocket.getInetAddress(), ServerSocket.getLocalPort(),
ServerSocket.getLocalSocketAddress(), Socket.getLocalAddress(),
Socket.getLocalPort(), Socket.getLocalSocketAddress(). These methods
treat special cases differently.
Fixed a bug in DatagramSocket.getLocalSocketAddress() where it would
incorrect throw an exception if the socket has been closed, which
contradicts the (updated) documentation and the RI. It now returns
null. Added tests.
Fixed a bug in Socket.close(): a closed socket would still report as
being connected. Added tests.
Fixed a bug in Socket.startupSocket() - the socket was recording it
was being bound, but was not updating the cached local address. This
method is called during ServerSocketChannel.accept() and would cause
the socket to report its local address as being the wildcard address,
when it is not. Added a test.
Change-Id: Ibec8527e1c72597e268d23e6c1f03eb16e46cdc4
Bug: 12464155
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support_PortManager didn't really work, so rewrite all tests
that use it.
Also, dedup OldDatagramSocketTest with the harmony DatagramSocketTest.
Fix various broken test cases and terribly written tests.
bug: 11689863
Change-Id: I4efb9e02eb88517273fff50a0dec1d0262feafb2
|
|
|
|
|
|
|
|
|
|
| |
We explicitly disallow setLevel or setStrategy after
setInput. (It's clearly documented in the method docs).
Presumably, this is to prevent users from shooting
themselves in the foot & causing issues by changing
the strategy / level after we've started deflating.
Change-Id: Ifd65728ff0ec7e47aeec716aeb6f44242573c491
|
|
|
|
| |
Change-Id: I15c25ff373b1ca4acb5e530f75d028b971779549
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- We now guarantee that available() returns 0 iff.
deflater.finished() == true. Note that this is still
inconsistent with the specification of InputStream#available.
- Remove an unnecessary array copy in DeflaterInputStream#read.
- Remove tests that expect an IllegalArgumentException for
negative skip count values. The InputStream spec doesn't mandate
that we must throw here, and it's better to be consistent with
every othem InputStream specialization in the code.
- Remove obsolete failures from brokentests.txt.
bug: 12189307
Change-Id: Ie9b1ad5d7c050b005b5f6f44a5a283bfdaeb1e81
|
|
|
|
|
|
|
| |
Also moves a couple of tests from luni/src/test to
harmony-tests/ where they belong.
Change-Id: I0b441b1fcbd355bd3c66551d16732a671fb64f54
|
|
|
|
|
|
| |
Several failures have already been fixed.
Change-Id: I2f372ec27c8b283ac5afaf3dcdcdc23ade07b4c7
|
|\
| |
| |
| |
| |
| |
| | |
(Take 2)"
* commit 'cfeab7b3523347cdfa1ce1f7fffc922f2cc0ab65':
Move tests from tests/api to harmony-tests. (Take 2)
|
| |
| |
| |
| |
| |
| |
| | |
This reverts commit d5e281743e55e1daa297fd8043b2d9b6e8e1bed2.
The makefile issue that caused the original build break
has been resolved.
|
|\ \
| |/
| |
| |
| |
| |
| | |
harmony-tests.""
* commit '24053344dd64bef9f2ed1c1e7577b48352396688':
Revert "Move tests from tests/api to harmony-tests."
|
| |
| |
| |
| |
| |
| |
| |
| | |
This reverts commit 81bf28ad31131815d0a36a43a0eca3c29aefdfcd.
Breaks build
Change-Id: I3f1562921ffe8fdbec36971dd65db398c27c92db
|
|\ \
| |/
| |
| |
| | |
* commit '15e00b6ef3092d5fe6c94e328aa6da210c941d1d':
Move tests from tests/api to harmony-tests.
|
| |
| |
| |
| |
| |
| |
| | |
The vast majority of cleaned up harmony tests
are now in harmony-tests/src/test/org/apache/harmony/tests/
Change-Id: I56c2e484ff434b5618cf6751d602ae9f0db96b30
|
|\ \
| |/
| |
| |
| |
| |
| | |
tests."
* commit '643f400d45af3ea66a5481c20be33dc09c457999':
Use a consistent package path for harmony tests.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Harmony was never consistent about where they put their
tests. There's no reason we have to be the same.
Also, there's no need to have separate subtrees for nio,
nio_char etc. etc.
This change makes all existing apache harmony tests
subpackages of "org.apache.harmony.tests" and put them under
libcore/harmony-tests.
We somehow managed to end up with two vastly different
copies of CharsetDecoderTest & CharsetEncoderTest. I've
renamed the copies CharsetDecoder2Test & CharsetEncoder2Test
to avoid having to go in and resolve the complicated
diffs or speculate about the reasons for their
divergence.
Change-Id: Ic34e69c2faab8893edd54e05eccd7091f4a09abd
|
|\ \
| |/
| |
| |
| |
| |
| | |
failures list."
* commit 'ce055efbc8285b6ecfbbaee39f3b13fbb0b735bb':
Add remaining harmony failures to the known failures list.
|
| |
| |
| |
| |
| |
| |
| | |
I've erred on the side of caution and treated possibly
broken tests as failures.
Change-Id: Iebb49e5cee11f6e514da70e6c6bc7ac97964b0aa
|
|\ \
| |/
| |
| |
| |
| |
| | |
list."
* commit '3dd7d89465d0c21f4216e614d5eb75d7dba1d8dc':
Add a harmony test case to known failures list.
|
| |
| |
| |
| |
| |
| | |
bug: 11650799
Change-Id: If1df4f8de4cdbf827d6159aa9ba29fe19d207f66
|
|/
|
|
|
|
| |
(cherry picked from commit 1aab8425f2c1eafbbdb2ead2632177d7ddee658b)
Change-Id: I676705ab19fffa526473f3546583b0c4e1c5a9e0
|
|
|
|
|
|
|
|
| |
Allow them only before we've started parsing any
XML elements.
bug: 3452274
Change-Id: I7b146e4dae8c7aa23a0a227538ec02604f828400
|
|
|
|
|
|
| |
Bug: 10837242
Bug: 10729779
Change-Id: I014f8646b8782973c13a3a327b4fba8b90e8d0cb
|
|
|
|
|
|
|
| |
failures.
Bug: 10666742
Change-Id: I3f93546f814c5b493ad3738eebf8e792f661970c
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There were plenty of bad tests here, but there were some real bugs too.
* DecimalFormat was only handling RoundingMode.UNNECESSARY for double
formatting.
* DecimalFormat was not ensuring that it's superclass' fields were
being correctly updated.
* NumberFormat was throwing NPE for a null object because of an
improved detail message, despite being specified to throw IAE.
* We weren't mapping NumberFormat.Field instances to the corresponding icu4c
UNUM_x_FIELD constant, so we weren't actually setting FieldPosition
objects correctly.
* SimpleDateFormat was not formatting milliseconds correctly with 'S'.
* NativeDecimalFormat wasn't handling JNI NewString OOME correctly.
Bug: 2528220
Bug: 3056865
Bug: 3057080
Bug: 3057090
Change-Id: Iac11f902f2e9649e596e7e7b7bc501b13e956fca
|