| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
As of ICU 53, rule strings must begin with a reset '&'.
http://www.unicode.org/reports/tr35/tr35-35/tr35-collation.html#Rules
Also, fewer collation elements exist in ICU 53 because ae-ligature maps to
two rather than three logical collation elements. Now the last one
yields only one CollationElementIterator value rather than two.
Finally, it's no longer possible to switch from forward to backward iteration
without calling reset/setOffset/setText. This used to be undefined behavior
but is now checked.
Change-Id: I663a2b229e551cd6f5753ddae0660f813dbbf866
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | | |
* commit 'a435c8d3869592ea86c7ecf73e273e1c4ff0e047':
Fix broken CTS test
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The fix is in test_isJavaIdentifierPartC() and reverses
the assertion for Character.isJavaIdentifierPart('\u200b')
from false to true. The test method below it
(isIdentifierPart(int)) was already asserting this and
the behavior has been confirmed against the RI.
Other changes made:
Uncommented some assertions that now pass, removed unnecessary /
incorrect comments, added missing braces, some reformatting to 100
chars to improve readability, removed empty lines at the beginning of
methods . Converted all assertTrue(msg, !condition); to
assertFalse(msg, condition).
Change-Id: I0a339df3cd594252a13083e4d4319260ce43fa5d
Bug: 13748395
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | | |
* commit '1e527edc0c3e9483104a76f4917aafc379d5b5c6':
Fix for ClassLoaderTest under CTS
|
| |\ \ \ \ |
|
| | |/ / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
The tests could not work given the arrangement of classloaders
in Android apps. This also fixes a known failure case in
ClassLoaderTest which was due to missing resources. Also updated
ClassTest.
Change-Id: I114aa9b1a177911aed0aef87819d93a260f0b8d1
Bug: 12491655
|
|\ \ \ \ \
| |/ / / /
| | | | |
| | | | |
| | | | | |
* commit 'e05b49cc2e55d4e23135a69f199b5fb09d94c4f5':
Fix broken CTS HttpCookie test
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Added some test cases and corrected the test to conform
to the RI behavior.
Change-Id: Ib32baf2e923c50fca1a5a4cb7cbd7f55ed70e760
Bug: 13748507
|
|\ \ \ \
| |/ / /
| | | |
| | | |
| | | | |
* commit '9079159a43b4a39126ae709c7abf327a86a6501b':
Fix test failures due to the ICU-52 update.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Some of the failures were due to the fact that we stopped
parsing numbers like "36-" for RTL locales, and others were
due to the fact that we were using reference equality for
comparing minusSign.
Change-Id: I239e6b8b77165a4665c554e46e6fb652beec2ec2
|
|\ \ \ \
| |/ / /
|/| | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Use expectations files instead.
Bug: 12924356
Change-Id: I0ea7917384adf7849404b6da5b7704e6f0c0c1c7
|
|\ \ \ \ |
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Adding isHttpOnly() and setHttpOnly(). Added more
documentation around the specifications supported since
the HttpOnly attribute was added by RFC 6265. Improved
documentation around toString() because I found the method
confusing, plus RFC 6265 goes back to a simpler format
than the RFC it obsoletes meaning callers should use
version 0 not version 1.
Change-Id: Ie52ea80dc5bd7d1575fcaccde70976ed29729817
|
|/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Note: ProtocolFamily / StandardProtocolFamily /
DatagramChannel.open(ProtocolFamily) have not been
implemented.
There is a related change to libnativehelper that
must be merged at the same time to avoid
build breakage. See
https://android-review.googlesource.com/#/c/81371/
Bug: 12464155
Change-Id: I07fc049b429a2d373e9bd7b07149632f5cd69f9d
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The bug report states that the behaviour of ZipFile has changed between 4.3 and
4.4 when opening an empty zip file. I did some investigation and it appears as
though the reference implementation also throws an exception in that case so I
decided that 4.4 is working as designed. However, to make it clearer I made a
minor change to explicitly check for an empty zip file so that we can report a
slightly improved message explaining that they are not supported. I added a
test for various forms of empty streams and zip files and removed part of an
older test from harmony tests as it is no longer necessary.
Bug: https://code.google.com/p/android/issues/detail?id=65380
Change-Id: I1f2fcbf6bbaedb7dbccf8dd4f1cec4e330274524
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Most failures were because tests were trying to
open files relative to the current working directory,
instead of in a temp directory.
FileTest was failing because it didn't construct
paths correctly. It would add an additional separator
char even if the path already ended with one.
Change-Id: Ie90aed84f81275924558e9dba43d71748dbb4076
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
URLConnection.getHeaderLong() and
URLConnection.getContentLengthLong().
These methods are required by okhttp.
Changed JarURLConnectionImpl.getContentLength() to return -1
when the size of an entry cannot be represented as an int.
Previously it would have returned a corrupted, possibly
negative, value due to a cast.
Changed FileURLConnection.getContentLength() to return -1
when the size of the file cannot be represented as an int.
Previously it would have returned a corrupted, possibly
negative, value due to a cast.
Change-Id: Ib43e68a2536c2602b4c7ee0cda68fa1f90045f57
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Get rid of Support_PlatformFile, use File.createTempFile
instead.
- Replace numerous uses of "user.dir" / "user.home" etc. with
File.createTempFile
- Replace calls to Process / chmod with Libcore.os.chmod. The
calls wouldn't have worked anyway, since chmod on android
doesn't understand the incremental (+w, -x) syntax.
Change-Id: Ic6944568bbee6a548da6dcb4364b882636f2959f
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A test case was using HashTable.get instead of
Properties.getProperty.
The problem is that Properties.propertyNames will
enumerate all properties from the object as well as
from the "default" Properties object it was constructed
with. The get method derived from HashTable isn't
aware of default properties though, so it will fail.
Using composition instead of inheritance would've
resulted in a cleaner design.
Change-Id: I58323767e6872ed1722167d2a4a6d89a98d26ec7
|
|\ \ \ |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Use a more specific exception type. The use of
IOException led me to believe that the constructor
was performing i/o ops on the underlying file
descriptors. (They were not.)
- Delete a test that asserted that System.console() was
always non-null. It will be non-null only for command
line apps (tests run from vogar), and not for
"regular" android apps (tests run from CTS) because
stdin / stdout will not be TTY devices regular apps.
bug: 12490236
Change-Id: I8c1e37bcb21de5862dc8ea198852995a020437a7
|
|\ \ \ \ |
|
| |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
We're going through the trouble of accounting for
DST changes in GregorianCalendar.add(int, int) (as per
the spec), so adjust our tests to agree.
bug: 12778197
Change-Id: Ie98cc11c2a2f7f6d9c7be8d725960552309f4f5d
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
ICU4C data (see icu4c/data/misc/supplementalData.txt)
as well as the RI agree that the minimum number of days
in the first week of the year should be 1 in canada.
(I'm not a 100% convinced that this is correct, the
canadian standards board claims to have implemented
ISO 8601, which requires a 4 day minimum. However, that
site links to several documents such as CSA Z234.5 that
are not publicly accessible).
Change-Id: I1d62c7f94d5f059b6ba2ad60bcf8434cdea0d9ce
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This change introduces NetworkChannel, but only bind() and
getLocalAddress() methods. To avoid breaking existing Android
applications that extend ServerSocketChannel, DatagramChannel and
SocketChannel the methods have been added with concrete
implementations that throw exceptions rather than leaving them
abstract.
In channel tests, usages of channel.socket().bind() and
channel.socket().getLocalSocketAddress() have been changed to
channel.bind() and channel.getLocalAddress(), since the behavior is
close enough and the tests should be written against the channel APIs
as much as possible. Tests have been added for new methods.
Removed further overriding in
DatagramChannelImpl.DatagramSocketAdapter and
SocketChannelImpl.SocketAdapter which revealed some bugs and lack of
clarity in the docs for the socket methods:
Improved the documentation for DatagramSocket.getLocalAddress(),
DatagramSocket.getLocalSocketAddress(),
ServerSocket.getInetAddress(), ServerSocket.getLocalPort(),
ServerSocket.getLocalSocketAddress(), Socket.getLocalAddress(),
Socket.getLocalPort(), Socket.getLocalSocketAddress(). These methods
treat special cases differently.
Fixed a bug in DatagramSocket.getLocalSocketAddress() where it would
incorrect throw an exception if the socket has been closed, which
contradicts the (updated) documentation and the RI. It now returns
null. Added tests.
Fixed a bug in Socket.close(): a closed socket would still report as
being connected. Added tests.
Fixed a bug in Socket.startupSocket() - the socket was recording it
was being bound, but was not updating the cached local address. This
method is called during ServerSocketChannel.accept() and would cause
the socket to report its local address as being the wildcard address,
when it is not. Added a test.
Change-Id: Ibec8527e1c72597e268d23e6c1f03eb16e46cdc4
Bug: 12464155
|
|\ \ \
| |/ /
|/| | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Making the various Socket/Channel classes more consistent with each
other for synchronizing state between the Channel, Socket and the OS.
This is in preparation for NetworkChannel.bind().
Synchronizing state revealed a test that relied upon a Socket from a
channel not reporting isConnected() properly after a connect(). Tests
have been updated.
Reading the local address back from the OS revealed that Android is
using IPv6 and reports the string equivalent of IPv4's 0.0.0.0 as
"::". Updated a test that was relying on the string form.
Calling connect() twice on a DatagramSocket appears inconsistent with
itself and Channel and other Sockets. A pure DatagramSocket switches
over to the new remote address. I have changed the Channel-backed
DatagramSocket to throw an IllegalStateException exception, and have
created a bug to discuss making the calls more consistent.
Socket has been modified to avoid using the address field to store
the local address after a bind(). This field is documented as holding
the remote address, not the local.
Changed implementation of SocketChannelImpl.socket().getInputStream()
and SocketChannelImpl.socket().getOutputStream() to use the one that
is implemented by Socket and not a custom NIO-based implementation.
The use of NIO provided two parallel implementations for the same
thing. This change alters behavior when attempting to read zero bytes
and when a Channel is in non-blocking mode: now it throws
IllegalBlockingModeException rather than
ArrayIndexOutOfBoundsException. The tests have been updated.
Various tidying up changes to introduce @Override, remove
unnecessarily initialized local variables, fields, semi-colons,
javadocs and imports. Added close() calls for objects during tests
that were cluttering the logs.
Modified IoBridge.connect() to be void. Adjusted SocketChannelImpl
accordingly and tidied up impossible cases. Modified
SocketChannel.connect() so that it always returns false in
non-blocking mode. This looks like an existing bug:
it would previously have returned true, even though the connection
was potentially still pending. Tests have been added.
Also tidied up SocketChannelImpl.finishConnect() - it was potentially
resetting the isBound state.
Change-Id: Ic7943615b4b763f77e74397e0e91a62edc7d7017
bug: 12464155
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The old golden files were referring to the wrong class,
and contained serial version UIDs that didn't match those
generated by any version of android (or the RI).
This change deletes the golden files and switches to
direct assertions in the test. All tests pass on
aosp-master, v4.xx of android and the RI.
bug: 12490445
Change-Id: Ia65b6d65bc9a3d4cbc62a7a0f7bdfc004e7315e2
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A previous file move changed the class name for various classes used
in the EnumTest. That broke the tests as they relied on files
containing serialized forms of those classes and so had hard coded
references to the old class names which no longer existed. The fix
was two part:
- Use the correct class names in the serialized files
- Remove duplicate serialized files that are no longer used
Bug: 12491225
Change-Id: I60b503bb2509071ccac5fec7b05dd5160d9dd7d0
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
As said in AttributeValue, DC and emailAddress should be encoded in
IA5String as specified by RFC5280.
Also the canonical encoding of a T61String could be PrintableString when
the string is only 'A' according to b/2102191 but this could be a
mistake.
Consecutive spaces and leading and trailing runs of spaces should be
escaped for RFC 1779.
Also the RFC 2259 doesn't specify anything other than the beginning or
end spaces, but the RI escapes the beginning and ending runs of spaces.
Bug: 12490346
Bug: 12490876
Change-Id: I6591156ba0a27a894241b039570488f89c885242
|
|\ \ \ |
|
| |/ /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since commit 086002299f96dbbec18a061e812dc1cb79cb1f10
ObjectOutputStream.writeObject() no longer throws StreamCorruptedException when
encountering an IOException during serialization. It now throws the actual
IOException.
bug: 6447733
Change-Id: I2b4add330cbb67d6d1db159940cb2e1fe2216bcc
|
|/ /
| |
| |
| |
| |
| |
| |
| | |
The breakage was caused by the SSLSessionTest assuming that TLS/SSL
connections by default handshake to the SSL_RSA_WITH_RC4_128_MD5 cipher suite.
Bug: 11220570
Change-Id: Ib1ac44f83c968ec3dc7432339e1fc0f64d63733f
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Support_PortManager didn't really work, so rewrite all tests
that use it.
Also, dedup OldDatagramSocketTest with the harmony DatagramSocketTest.
Fix various broken test cases and terribly written tests.
bug: 11689863
Change-Id: I4efb9e02eb88517273fff50a0dec1d0262feafb2
|
| |
| |
| |
| |
| | |
Bug: 11220570
Change-Id: Ic918e806ae1d8ea9b98c690cfabd9c3245886525
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We explicitly disallow setLevel or setStrategy after
setInput. (It's clearly documented in the method docs).
Presumably, this is to prevent users from shooting
themselves in the foot & causing issues by changing
the strategy / level after we've started deflating.
Change-Id: Ifd65728ff0ec7e47aeec716aeb6f44242573c491
|
| |
| |
| |
| | |
Change-Id: I15c25ff373b1ca4acb5e530f75d028b971779549
|
| |
| |
| |
| |
| |
| | |
Removal of debug code gone bad.
Change-Id: I93d9decbd9d733cbeccd7832fef6857cf1b41b25
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- We now guarantee that available() returns 0 iff.
deflater.finished() == true. Note that this is still
inconsistent with the specification of InputStream#available.
- Remove an unnecessary array copy in DeflaterInputStream#read.
- Remove tests that expect an IllegalArgumentException for
negative skip count values. The InputStream spec doesn't mandate
that we must throw here, and it's better to be consistent with
every othem InputStream specialization in the code.
- Remove obsolete failures from brokentests.txt.
bug: 12189307
Change-Id: Ie9b1ad5d7c050b005b5f6f44a5a283bfdaeb1e81
|
| |
| |
| |
| |
| |
| |
| | |
Also remove tests with broken expectations that were never
implemented.
Change-Id: I5eb60d3e6dfb8ead6e23941fca1bc19f79c4a158
|
| |
| |
| |
| |
| |
| |
| | |
Also moves a couple of tests from luni/src/test to
harmony-tests/ where they belong.
Change-Id: I0b441b1fcbd355bd3c66551d16732a671fb64f54
|
| |
| |
| |
| |
| |
| | |
A comment was missing the word "the".
Change-Id: I592c998774e7335881f03006c9e28700b048b8db
|
| |
| |
| |
| |
| |
| |
| | |
Automatic IntelliJ reformatting of a weirdly formatted
test.
Change-Id: I9ce29d9004dfe625a8479a77230248db3d1b9e3b
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When malformed or unmappable characters span input
buffers, we'd end up setting a negative position on the
buffer.
Also fix up a few test cases which were wrong in
several ways.
- One test was simply checking for the wrong sort
of exception (unmappable vs malformed)
- Another test was expecting encode() to throw an
error (and ignoring flush) but the API allows flush
to throw an error instead of encode.
bug: 10729779
Change-Id: I6560b749ca2445651d61ca651f8a5e388cf1c1b0
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Fix a mistaken assumption about how path matching
works.
- Change a TreeMap to a LinkedHashMap, because TreeMaps
are not required to support null keys.
- Change a bogus "equals" check for the version to a
startsWith check.
- Change various tests re: the size of the output list.
The specification doesn't require us to create separate
Cookie headers for each cookie found in the store. It is
free to concatenate the contents of matching cookies.
- Change tests that expected the addition of an empty list
to the headers map when there are no matching cookies.
The spec does not require this.
bug: 11689102
Change-Id: I341c301f18e410b983d010b5d2f14b3462901bf5
|
| |
| |
| |
| |
| |
| |
| | |
The object doesn't override equals & hashCode so it needs
a serialization comparator.
Change-Id: Ie6067ad1e6cd22f5e2b83907e5bf2ea0039466cb
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Check for the nio canonical name instead of
the "old" canonical name.
bug: 11665359
Change-Id: Icc813a77cfb7d61ddb0ce33fbdf48ccbe0ded7fb
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These tests were added in commit 5ec6bf8d0 and were
assumed to have been caused by an ICU bug. They were
in fact caused by bugs in our ICU glue code and those
issues have now been fixed.
Change-Id: Ia21a5b466eea685f175fa370d9e2b3b3342cd1b8
|