| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
Change-Id: Ib61b132ce17fdd37956889e855bda35956f8ae62
|
|
|
|
|
|
|
|
|
|
|
| |
These were clearly added just to shut up our own warning, and are now
unnecessary and misleading to future maintainers.
There's one barely-related change: InputStreamReader and OutputStreamWriter
are very similar, and this patch makes them more similar, and adds a few
missing modifiers from their fields.
Change-Id: I959011f914ff215e92bbfa41c1bac66465803685
|
|
|
|
|
|
|
| |
I've fixed a few typos, and removed a few of the more egregiously nonsensical
or incorrect comments that were nearby.
Change-Id: I35851baebd532f949cc269f4738a26eeb9b6e697
|
|\
| |
| |
| |
| |
| |
| | |
Merge commit 'e073b0e86ea089a08685202f78fe446cd03b3d49' into dalvik-dev
* commit 'e073b0e86ea089a08685202f78fe446cd03b3d49':
Move String creation outside O(n^2) path in LogManager
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This more than halves the number of Strings and StringBuilders created
when constructing a GoogleHttpClient and executing a single
HTTP request.
Bug http://b/issue?id=2529141
Change-Id: Ia8268fd692b08cf82e4abbffe1459e461e9f7e68
|
| |
| |
| |
| |
| |
| |
| | |
Also deprecated Logger.global.
Bug: 2497395
Change-Id: I28e5f83116277430c4eb0773b238670c0dd80847
|
| |
| |
| |
| | |
(Plus a bonus item: one Android-written test under luni.)
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I started off with a mission to remove uses of dalvik.annotation.* (stuff
like @TestTargetNew and other useless junk that just makes it harder to
stay in sync with upstream). I wrote a script to go through tests showing
me the diff between what we have and what upstream has, thinking that in
cases where upstream has also added tests, I may as well pull them in at
the same time...
...but I didn't realize how close we were to having dx fill its 1.5GiB heap.
After trying various alternatives, I decided to bite the bullet and break
core-tests up into one .jar per module. This adds parallelism back into this,
the slowest part of our build. (I can do even better, but I'll do that in a
separate patch, preferably after we've merged recent changes from master.)
Only a couple of dependencies were problematic: the worthless TestSuiteFactory
which already contained a comment suggesting we get rid of it, and the fact
that some tests -- most notably the concurrent ones -- also contained main
methods that started the JUnit tty-based TestRunner.
(In the long run, we want to be running the harmony tests directly from a
pristine "svn co" of upstream, using DalvikRunner. But this will be a big
help in the meantime, and starts the work of getting our current copy of
the tests into a state where we can start to extract any meaningful
changes/additions we've made.)
|
|
|
|
|
|
|
|
| |
Conflicts:
libcore/logging/META-INF/MANIFEST.MF
libcore/logging/src/main/java/java/util/logging/LogManager.java
libcore/logging/src/main/java/java/util/logging/Logger.java
libcore/logging/src/test/java/org/apache/harmony/logging/tests/java/util/logging/LogManagerTest.java
|
| |
|
|
|
|
| |
This replaces PrefsTester and is more general purpose.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change introduces a new interface, DalvikLogHandler. Log
handlers that implement it opt-in to more efficient log handling
for common-case log messages. The API requires far fewer objects
to be allocated to log a message.
A related change in frameworks/base adopts this optimization
in the built-in AndroidHandler.
This optimization resulted in a 2.75x improvement on my device:
from 154ns to 56ns per message.
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Formerly any logged message would require synchronization on the shared
global lock to access the root logger's handlers. This change replaces
synchronization on loggers with a combination of copy-on-write and
volatile fields.
Also moving handler initialization from lazy to eager - the code has
moved from initHandlers() to setManager().
Also tidying up the info(), severe() type methods to delegate to avoid
unnecessary duplication.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Highlights:
- Clean up documentation. Moved internal docs from variable use site
to declaration site, especially for special cases around null.
- Move default variable values to declaration
- Move methods requiring LogManager synchronization to LogManager.
This includes setLevelImpl(), forceChildsToInherit(),
internalSetParent() and getLoggerWithRes().
- flip "if (null == foo)" to "if (foo == null)" for readability
- Rename updateResourceBundle to initResourceBundle. Made method
non-static.
- Rename initHandler to initHandlers; changed the method to
short circuit on negative 'handlerInited' cases.
- Flipped "internalIsLoggable" methods to short-circuit.
- Expose variables used by LogManager as package-private. For example,
the childs variable is only used by LogManager, but previously it
went through the Logger class each time it was used.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
commit 080ff677c719f1e53ffb544c3fb684bb9ff28677
Author: Jesse Wilson <jessewilson@google.com>
Date: Mon May 11 19:06:05 2009 -0700
Copied test changes over manually.
commit ea52f28de5378f7dd4eff5c0f83d805e997a98de
Merge: 0c1f753 a6c8255
Author: Jesse Wilson <jessewilson@google.com>
Date: Mon May 11 18:49:28 2009 -0700
Merge branch 'logging_772995' into logging_dalvik
Conflicts:
libcore/logging/.classpath
libcore/logging/META-INF/MANIFEST.MF
libcore/logging/build.xml
libcore/logging/src/main/java/java/util/logging/ConsoleHandler.java
libcore/logging/src/main/java/java/util/logging/FileHandler.java
libcore/logging/src/main/java/java/util/logging/Formatter.java
libcore/logging/src/main/java/java/util/logging/Handler.java
libcore/logging/src/main/java/java/util/logging/Level.java
libcore/logging/src/main/java/java/util/logging/LogManager.java
libcore/logging/src/main/java/java/util/logging/LogRecord.java
libcore/logging/src/main/java/java/util/logging/Logger.java
libcore/logging/src/main/java/java/util/logging/LoggingMXBean.java
libcore/logging/src/main/java/java/util/logging/LoggingPermission.java
libcore/logging/src/main/java/java/util/logging/MemoryHandler.java
libcore/logging/src/main/java/java/util/logging/SimpleFormatter.java
libcore/logging/src/main/java/java/util/logging/SocketHandler.java
libcore/logging/src/main/java/java/util/logging/StreamHandler.java
libcore/logging/src/main/java/java/util/logging/XMLFormatter.java
libcore/logging/src/test/java/org/apache/harmony/logging/tests/java/util/logging/LoggerTest.java
commit 0c1f7538e6fe3091a3d142b2ac14f5bf338b3a55
Author: Jesse Wilson <jessewilson@google.com>
Date: Mon May 11 16:06:59 2009 -0700
Stripped @since Android 1.0
commit 4c715c6c58080b3cbed2928cd1b71b9931e217a3
Author: Jesse Wilson <jessewilson@google.com>
Date: Mon May 11 15:57:59 2009 -0700
Logging Dalvik.
commit a6c8255dbbad85145a2066d9846d24787df0f75f
Author: Jesse Wilson <jessewilson@google.com>
Date: Mon May 11 15:56:41 2009 -0700
Logging 772995
commit db77dbdf56e99e3dcced2d758f7150007562c41c
Author: Jesse Wilson <jessewilson@google.com>
Date: Mon May 11 15:54:13 2009 -0700
Logging 527399
|
|
|
|
|
|
|
|
|
|
| |
timeout
are now marked with BrokenTest to exclude them for the time being until
we have a way to execute them.
BUG=1285921
Automated import of CL 147687
|
|
|
|
|
|
| |
BUG=1285921
Automated import of CL 143466
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|