From 6bcf32ab404c39b85d25430f6df16503ef3526cf Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Mon, 16 Nov 2009 21:23:11 -0800 Subject: Various XML fixes. Add tests for bug 2487, exploring the situations where "]]>" is and isn't allowed. Fix the bug by changing KXmlParser so it pays attention to whether it's dealing with normal text or text in an attribute value and reports errors appropriately. In order to pass the new tests, we also need to fix DocumentBuilder to pay attention to its DocumentBuilderFactory's "coalescing" setting: whether or not adjacent text/CDATA nodes should be coalesced. This in turn fixes a @KnownFailure in DocumentBuilderFactoryTest: previously we didn't allow the caller to turn "coalescing" off (though until my previous patch, we didn't actually coalesce anyway). Now we support both, and I've made coalescing the default, because bug reports tell us that's what users want. It's how the RI behaves, too. Bug: 2487 --- .../java/tests/api/javax/xml/parsers/DocumentBuilderFactoryTest.java | 1 - 1 file changed, 1 deletion(-) (limited to 'xml/src/test/java') diff --git a/xml/src/test/java/tests/api/javax/xml/parsers/DocumentBuilderFactoryTest.java b/xml/src/test/java/tests/api/javax/xml/parsers/DocumentBuilderFactoryTest.java index b6c400f..80c6e3c 100644 --- a/xml/src/test/java/tests/api/javax/xml/parsers/DocumentBuilderFactoryTest.java +++ b/xml/src/test/java/tests/api/javax/xml/parsers/DocumentBuilderFactoryTest.java @@ -462,7 +462,6 @@ public class DocumentBuilderFactoryTest extends TestCase { method = "setCoalescing", args = {boolean.class} ) - @KnownFailure("Should support coalescing") public void test_setCoalescingZ() { dbf.setCoalescing(true); assertTrue(dbf.isCoalescing()); -- cgit v1.1