diff options
-rw-r--r-- | Android.mk | 2 | ||||
-rw-r--r-- | res/layout/data_usage_bytes_editor.xml | 3 | ||||
-rw-r--r-- | res/layout/wifi_dialog.xml | 1 | ||||
-rw-r--r-- | res/values/strings.xml | 6 | ||||
-rw-r--r-- | src/com/android/settings/ApnEditor.java | 3 | ||||
-rw-r--r-- | src/com/android/settings/ApnSettings.java | 11 | ||||
-rw-r--r-- | src/com/android/settings/CryptKeeper.java | 3 | ||||
-rw-r--r-- | src/com/android/settings/DataUsageSummary.java | 3 | ||||
-rw-r--r-- | src/com/android/settings/RadioInfo.java | 16 | ||||
-rw-r--r-- | src/com/android/settings/RingerVolumePreference.java | 1 | ||||
-rw-r--r-- | src/com/android/settings/TestingSettingsBroadcastReceiver.java | 2 | ||||
-rw-r--r-- | src/com/android/settings/Utils.java | 2 | ||||
-rw-r--r-- | src/com/android/settings/accounts/AccountSyncSettings.java | 11 | ||||
-rw-r--r-- | src/com/android/settings/deviceinfo/Status.java | 9 | ||||
-rw-r--r-- | src/com/android/settings/inputmethod/InputMethodAndLanguageSettings.java | 18 | ||||
-rw-r--r-- | src/com/android/settings/wifi/WifiApEnabler.java | 4 |
16 files changed, 64 insertions, 31 deletions
@@ -1,7 +1,7 @@ LOCAL_PATH:= $(call my-dir) include $(CLEAR_VARS) -LOCAL_JAVA_LIBRARIES := bouncycastle +LOCAL_JAVA_LIBRARIES := bouncycastle telephony-common LOCAL_STATIC_JAVA_LIBRARIES := guava android-support-v4 LOCAL_MODULE_TAGS := optional diff --git a/res/layout/data_usage_bytes_editor.xml b/res/layout/data_usage_bytes_editor.xml index 6207391b..ec6e64f 100644 --- a/res/layout/data_usage_bytes_editor.xml +++ b/res/layout/data_usage_bytes_editor.xml @@ -22,7 +22,8 @@ <NumberPicker android:id="@+id/bytes" - android:layout_width="48dip" + android:layout_width="wrap_content" + android:minWidth="48dip" android:layout_height="wrap_content" android:layout_gravity="center_vertical" android:layout_marginLeft="16dip" diff --git a/res/layout/wifi_dialog.xml b/res/layout/wifi_dialog.xml index 5103e8b..88dae27 100644 --- a/res/layout/wifi_dialog.xml +++ b/res/layout/wifi_dialog.xml @@ -38,6 +38,7 @@ <EditText android:id="@+id/ssid" style="@style/wifi_item_content" + android:maxLength="32" android:singleLine="true" android:inputType="textNoSuggestions" /> </LinearLayout> diff --git a/res/values/strings.xml b/res/values/strings.xml index b433637..a17ceb7 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -871,7 +871,7 @@ <!-- Hint shown in dialog screen when password is too short --> <string name="lockpassword_password_too_short">Password must be at least %d characters</string> <!-- Hint shown in dialog screen when PIN is too short --> - <string name="lockpassword_pin_too_short">PIN must be at least %d characters</string> + <string name="lockpassword_pin_too_short">PIN must be at least %d digits</string> <!-- Hint shown after minimum password criteria is met --> <string name="lockpassword_press_continue">Touch Continue when done</string> @@ -1451,6 +1451,10 @@ <!-- Wifi AP settings--> <!-- Label for wifi tether checkbox. Toggles Access Point on/off --> <string name="wifi_tether_checkbox_text">Portable Wi-Fi hotspot</string> + <!-- Summary text when turning hotspot on --> + <string name="wifi_tether_starting">Turning hotspot on\u2026</string> + <!-- Summary text when turning hotspot off --> + <string name="wifi_tether_stopping">Turning off hotspot\u2026</string> <!-- Subtext for wifi tether checkbox on success --> <string name="wifi_tether_enabled_subtext">Portable hotspot <xliff:g id="network_ssid">%1$s</xliff:g> active</string> <!-- Subtext for wifi tether checkbox on failure --> diff --git a/src/com/android/settings/ApnEditor.java b/src/com/android/settings/ApnEditor.java index efde689..bca521b 100644 --- a/src/com/android/settings/ApnEditor.java +++ b/src/com/android/settings/ApnEditor.java @@ -40,6 +40,7 @@ import android.view.Menu; import android.view.MenuItem; import com.android.internal.telephony.Phone; +import com.android.internal.telephony.PhoneConstants; import com.android.internal.telephony.RILConstants; import com.android.internal.telephony.TelephonyProperties; @@ -170,7 +171,7 @@ public class ApnEditor extends PreferenceActivity // types. (This screen is not normally accessible on CDMA phones, but is useful for // testing.) TelephonyManager tm = (TelephonyManager)getSystemService(TELEPHONY_SERVICE); - if (tm.getCurrentPhoneType() == Phone.PHONE_TYPE_CDMA) { + if (tm.getCurrentPhoneType() == PhoneConstants.PHONE_TYPE_CDMA) { mRoamingProtocol.setOnPreferenceChangeListener(this); } else { getPreferenceScreen().removePreference(mRoamingProtocol); diff --git a/src/com/android/settings/ApnSettings.java b/src/com/android/settings/ApnSettings.java index 57762d4..8ea2063 100644 --- a/src/com/android/settings/ApnSettings.java +++ b/src/com/android/settings/ApnSettings.java @@ -43,6 +43,7 @@ import android.view.MenuItem; import android.widget.Toast; import com.android.internal.telephony.Phone; +import com.android.internal.telephony.PhoneConstants; import com.android.internal.telephony.TelephonyIntents; import com.android.internal.telephony.TelephonyProperties; @@ -90,7 +91,7 @@ public class ApnSettings extends PreferenceActivity implements public void onReceive(Context context, Intent intent) { if (intent.getAction().equals( TelephonyIntents.ACTION_ANY_DATA_CONNECTION_STATE_CHANGED)) { - Phone.DataState state = getMobileDataState(intent); + PhoneConstants.DataState state = getMobileDataState(intent); switch (state) { case CONNECTED: if (!mRestoreDefaultApnMode) { @@ -104,12 +105,12 @@ public class ApnSettings extends PreferenceActivity implements } }; - private static Phone.DataState getMobileDataState(Intent intent) { - String str = intent.getStringExtra(Phone.STATE_KEY); + private static PhoneConstants.DataState getMobileDataState(Intent intent) { + String str = intent.getStringExtra(PhoneConstants.STATE_KEY); if (str != null) { - return Enum.valueOf(Phone.DataState.class, str); + return Enum.valueOf(PhoneConstants.DataState.class, str); } else { - return Phone.DataState.DISCONNECTED; + return PhoneConstants.DataState.DISCONNECTED; } } diff --git a/src/com/android/settings/CryptKeeper.java b/src/com/android/settings/CryptKeeper.java index 5fb72ed..4cab767 100644 --- a/src/com/android/settings/CryptKeeper.java +++ b/src/com/android/settings/CryptKeeper.java @@ -56,6 +56,7 @@ import android.widget.TextView; import com.android.internal.telephony.ITelephony; import com.android.internal.telephony.Phone; +import com.android.internal.telephony.PhoneConstants; import java.util.List; @@ -637,7 +638,7 @@ public class CryptKeeper extends Activity implements TextView.OnEditorActionList */ private final void setAirplaneModeIfNecessary() { final boolean isLteDevice = - TelephonyManager.getDefault().getLteOnCdmaMode() == Phone.LTE_ON_CDMA_TRUE; + TelephonyManager.getDefault().getLteOnCdmaMode() == PhoneConstants.LTE_ON_CDMA_TRUE; if (!isLteDevice) { Log.d(TAG, "Going into airplane mode."); Settings.System.putInt(getContentResolver(), Settings.System.AIRPLANE_MODE_ON, 1); diff --git a/src/com/android/settings/DataUsageSummary.java b/src/com/android/settings/DataUsageSummary.java index 13512d4..5e20a6e 100644 --- a/src/com/android/settings/DataUsageSummary.java +++ b/src/com/android/settings/DataUsageSummary.java @@ -128,6 +128,7 @@ import android.widget.TabWidget; import android.widget.TextView; import com.android.internal.telephony.Phone; +import com.android.internal.telephony.PhoneConstants; import com.android.settings.drawable.InsetBoundsDrawable; import com.android.settings.net.ChartData; import com.android.settings.net.ChartDataLoader; @@ -2193,7 +2194,7 @@ public class DataUsageSummary extends Fragment { final TelephonyManager tele = TelephonyManager.from(context); final boolean hasWimax = conn.isNetworkSupported(TYPE_WIMAX); - final boolean hasLte = (tele.getLteOnCdmaMode() == Phone.LTE_ON_CDMA_TRUE) + final boolean hasLte = (tele.getLteOnCdmaMode() == PhoneConstants.LTE_ON_CDMA_TRUE) && hasReadyMobileRadio(context); return hasWimax || hasLte; } diff --git a/src/com/android/settings/RadioInfo.java b/src/com/android/settings/RadioInfo.java index aa3f2e9..5ba3837 100644 --- a/src/com/android/settings/RadioInfo.java +++ b/src/com/android/settings/RadioInfo.java @@ -55,6 +55,7 @@ import android.widget.EditText; import com.android.internal.telephony.DataConnection; import com.android.internal.telephony.Phone; +import com.android.internal.telephony.PhoneConstants; import com.android.internal.telephony.PhoneFactory; import com.android.internal.telephony.PhoneStateIntentReceiver; import com.android.internal.telephony.TelephonyProperties; @@ -193,9 +194,14 @@ public class RadioInfo extends Activity { ar= (AsyncResult) msg.obj; if (ar.exception == null) { int type = ((int[])ar.result)[0]; + if (type >= mPreferredNetworkLabels.length) { + Log.e(TAG, "[RadioInfo] EVENT_QUERY_PREFERRED_TYPE_DONE: unknown " + + "type=" + type); + type = mPreferredNetworkLabels.length - 1; + } preferredNetworkType.setSelection(type, true); } else { - preferredNetworkType.setSelection(8, true); + preferredNetworkType.setSelection(mPreferredNetworkLabels.length - 1, true); } break; case EVENT_SET_PREFERRED_TYPE_DONE: @@ -546,7 +552,7 @@ public class RadioInfo extends Activity { private final void updatePhoneState() { - Phone.State state = mPhoneStateReceiver.getPhoneState(); + PhoneConstants.State state = mPhoneStateReceiver.getPhoneState(); Resources r = getResources(); String display = r.getString(R.string.radioInfo_unknown); @@ -1009,7 +1015,7 @@ public class RadioInfo extends Activity { mPreferredNetworkHandler = new AdapterView.OnItemSelectedListener() { public void onItemSelected(AdapterView parent, View v, int pos, long id) { Message msg = mHandler.obtainMessage(EVENT_SET_PREFERRED_TYPE_DONE); - if (pos>=0 && pos<=7) { //IS THIS NEEDED to extend to the entire range of values + if (pos>=0 && pos<=(mPreferredNetworkLabels.length - 2)) { phone.setPreferredNetworkType(pos, msg); } } @@ -1027,5 +1033,9 @@ public class RadioInfo extends Activity { "CDMA only", "EvDo only", "GSM/CDMA auto (PRL)", + "LTE/CDMA auto (PRL)", + "LTE/GSM auto (PRL)", + "LTE/GSM/CDMA auto (PRL)", + "LTE only", "Unknown"}; } diff --git a/src/com/android/settings/RingerVolumePreference.java b/src/com/android/settings/RingerVolumePreference.java index a79f4a5..954213d 100644 --- a/src/com/android/settings/RingerVolumePreference.java +++ b/src/com/android/settings/RingerVolumePreference.java @@ -17,7 +17,6 @@ package com.android.settings; import static android.os.BatteryManager.BATTERY_STATUS_UNKNOWN; -import static android.provider.Telephony.Intents.SPN_STRINGS_UPDATED_ACTION; import com.android.internal.telephony.TelephonyIntents; diff --git a/src/com/android/settings/TestingSettingsBroadcastReceiver.java b/src/com/android/settings/TestingSettingsBroadcastReceiver.java index cea12c5..3c40453 100644 --- a/src/com/android/settings/TestingSettingsBroadcastReceiver.java +++ b/src/com/android/settings/TestingSettingsBroadcastReceiver.java @@ -1,7 +1,7 @@ package com.android.settings; import android.provider.Telephony; -import static android.provider.Telephony.Intents.SECRET_CODE_ACTION; +import static com.android.internal.telephony.TelephonyIntents.SECRET_CODE_ACTION; import android.content.Context; import android.content.Intent; diff --git a/src/com/android/settings/Utils.java b/src/com/android/settings/Utils.java index 460a182..a029342 100644 --- a/src/com/android/settings/Utils.java +++ b/src/com/android/settings/Utils.java @@ -124,7 +124,7 @@ public class Utils { // Did not find a matching activity, so remove the preference parentPreferenceGroup.removePreference(preference); - return true; + return false; } /** diff --git a/src/com/android/settings/accounts/AccountSyncSettings.java b/src/com/android/settings/accounts/AccountSyncSettings.java index 715108b..196908e 100644 --- a/src/com/android/settings/accounts/AccountSyncSettings.java +++ b/src/com/android/settings/accounts/AccountSyncSettings.java @@ -79,7 +79,7 @@ public class AccountSyncSettings extends AccountPreferenceBase { private Account[] mAccounts; private ArrayList<SyncStateCheckBoxPreference> mCheckBoxes = new ArrayList<SyncStateCheckBoxPreference>(); - private ArrayList<String> mInvisibleAdapters = Lists.newArrayList(); + private ArrayList<SyncAdapterType> mInvisibleAdapters = Lists.newArrayList(); @Override public Dialog onCreateDialog(final int id) { @@ -321,8 +321,11 @@ public class AccountSyncSettings extends AccountPreferenceBase { } // plus whatever the system needs to sync, e.g., invisible sync adapters if (mAccount != null) { - for (String authority : mInvisibleAdapters) { - requestOrCancelSync(mAccount, authority, startSync); + for (SyncAdapterType syncAdapter : mInvisibleAdapters) { + // invisible sync adapters' account type should be same as current account type + if (syncAdapter.accountType.equals(mAccount.type)) { + requestOrCancelSync(mAccount, syncAdapter.authority, startSync); + } } } } @@ -452,7 +455,7 @@ public class AccountSyncSettings extends AccountPreferenceBase { } else { // keep track of invisible sync adapters, so sync now forces // them to sync as well. - mInvisibleAdapters.add(sa.authority); + mInvisibleAdapters.add(sa); } } diff --git a/src/com/android/settings/deviceinfo/Status.java b/src/com/android/settings/deviceinfo/Status.java index 1d1dfaa..9e884c5 100644 --- a/src/com/android/settings/deviceinfo/Status.java +++ b/src/com/android/settings/deviceinfo/Status.java @@ -43,6 +43,7 @@ import android.telephony.TelephonyManager; import android.text.TextUtils; import com.android.internal.telephony.Phone; +import com.android.internal.telephony.PhoneConstants; import com.android.internal.telephony.PhoneFactory; import com.android.internal.telephony.PhoneStateIntentReceiver; import com.android.internal.telephony.TelephonyProperties; @@ -115,7 +116,7 @@ public class Status extends PreferenceActivity { private Preference mSignalStrength; private Preference mUptime; - private static String sUnknown; + private String sUnknown; private Preference mBatteryStatus; private Preference mBatteryLevel; @@ -188,9 +189,7 @@ public class Status extends PreferenceActivity { mBatteryStatus = findPreference(KEY_BATTERY_STATUS); mRes = getResources(); - if (sUnknown == null) { - sUnknown = mRes.getString(R.string.device_info_default); - } + sUnknown = mRes.getString(R.string.device_info_default); mPhone = PhoneFactory.getDefaultPhone(); // Note - missing in zaku build, be careful later... @@ -213,7 +212,7 @@ public class Status extends PreferenceActivity { setSummaryText(KEY_PRL_VERSION, mPhone.getCdmaPrlVersion()); removePreferenceFromScreen(KEY_IMEI_SV); - if (mPhone.getLteOnCdmaMode() == Phone.LTE_ON_CDMA_TRUE) { + if (mPhone.getLteOnCdmaMode() == PhoneConstants.LTE_ON_CDMA_TRUE) { // Show ICC ID and IMEI for LTE device setSummaryText(KEY_ICC_ID, mPhone.getIccSerialNumber()); setSummaryText(KEY_IMEI, mPhone.getImei()); diff --git a/src/com/android/settings/inputmethod/InputMethodAndLanguageSettings.java b/src/com/android/settings/inputmethod/InputMethodAndLanguageSettings.java index 182c1eb..c2ff0d9 100644 --- a/src/com/android/settings/inputmethod/InputMethodAndLanguageSettings.java +++ b/src/com/android/settings/inputmethod/InputMethodAndLanguageSettings.java @@ -225,6 +225,7 @@ public class InputMethodAndLanguageSettings extends SettingsPreferenceFragment public void onResume() { super.onResume(); + mSettingsObserver.resume(); mIm.registerInputDeviceListener(this, null); if (!mIsOnlyImeSettings) { @@ -279,6 +280,7 @@ public class InputMethodAndLanguageSettings extends SettingsPreferenceFragment super.onPause(); mIm.unregisterInputDeviceListener(this); + mSettingsObserver.pause(); if (SHOW_INPUT_METHOD_SWITCHER_SETTINGS) { mShowInputMethodSelectorPref.setOnPreferenceChangeListener(null); @@ -537,17 +539,27 @@ public class InputMethodAndLanguageSettings extends SettingsPreferenceFragment } private class SettingsObserver extends ContentObserver { + private Context mContext; + public SettingsObserver(Handler handler, Context context) { super(handler); - final ContentResolver cr = context.getContentResolver(); + mContext = context; + } + + @Override public void onChange(boolean selfChange) { + updateCurrentImeName(); + } + + public void resume() { + final ContentResolver cr = mContext.getContentResolver(); cr.registerContentObserver( Settings.Secure.getUriFor(Settings.Secure.DEFAULT_INPUT_METHOD), false, this); cr.registerContentObserver(Settings.Secure.getUriFor( Settings.Secure.SELECTED_INPUT_METHOD_SUBTYPE), false, this); } - @Override public void onChange(boolean selfChange) { - updateCurrentImeName(); + public void pause() { + mContext.getContentResolver().unregisterContentObserver(this); } } } diff --git a/src/com/android/settings/wifi/WifiApEnabler.java b/src/com/android/settings/wifi/WifiApEnabler.java index 92e1c92..86a7cb4 100644 --- a/src/com/android/settings/wifi/WifiApEnabler.java +++ b/src/com/android/settings/wifi/WifiApEnabler.java @@ -180,7 +180,7 @@ public class WifiApEnabler { private void handleWifiApStateChanged(int state) { switch (state) { case WifiManager.WIFI_AP_STATE_ENABLING: - mCheckBox.setSummary(R.string.wifi_starting); + mCheckBox.setSummary(R.string.wifi_tether_starting); mCheckBox.setEnabled(false); break; case WifiManager.WIFI_AP_STATE_ENABLED: @@ -193,7 +193,7 @@ public class WifiApEnabler { mCheckBox.setEnabled(true); break; case WifiManager.WIFI_AP_STATE_DISABLING: - mCheckBox.setSummary(R.string.wifi_stopping); + mCheckBox.setSummary(R.string.wifi_tether_stopping); mCheckBox.setEnabled(false); break; case WifiManager.WIFI_AP_STATE_DISABLED: |