From c54782071ad7d595162040c3471e5ed416fb52a3 Mon Sep 17 00:00:00 2001 From: Barnaby James Date: Sun, 24 May 2015 08:36:18 -0700 Subject: Fix TTS for Zen mode voice activity. Don't finish activity until TTS has finished. Incorrect TTS for mix of hours / mins - e.g. 1 hour 45 minutes. Improve the description of TTS strings for translators. BUG: 20248251 BUG: 21413212 BUG: 21411622 Change-Id: Id2693ea82b76492216147012216ba07ce75a9d12 --- .../android/settings/notification/ZenModeVoiceActivity.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'src/com/android/settings/notification') diff --git a/src/com/android/settings/notification/ZenModeVoiceActivity.java b/src/com/android/settings/notification/ZenModeVoiceActivity.java index 71e56b0..270633a 100644 --- a/src/com/android/settings/notification/ZenModeVoiceActivity.java +++ b/src/com/android/settings/notification/ZenModeVoiceActivity.java @@ -58,7 +58,6 @@ public class ZenModeVoiceActivity extends VoiceSettingsActivity { mode = Global.ZEN_MODE_ALARMS; } setZenModeConfig(mode, condition); - notifySuccess(getChangeSummary(mode, minutes)); AudioManager audioManager = (AudioManager) getSystemService(Context.AUDIO_SERVICE); if (audioManager != null) { @@ -67,10 +66,12 @@ public class ZenModeVoiceActivity extends VoiceSettingsActivity { AudioManager.ADJUST_SAME, AudioManager.FLAG_SHOW_UI); } + notifySuccess(getChangeSummary(mode, minutes)); } else { Log.v(TAG, "Missing extra android.provider.Settings.EXTRA_DO_NOT_DISTURB_MODE_ENABLED"); + finish(); } - return true; + return false; } private void setZenModeConfig(int mode, Condition condition) { @@ -88,12 +89,14 @@ public class ZenModeVoiceActivity extends VoiceSettingsActivity { int indefinite = -1; int byMinute = -1; int byHour = -1; + int byTime = -1; switch (mode) { case Global.ZEN_MODE_ALARMS: - indefinite = R.string.zen_mode_summary_alarams_only_indefinite; + indefinite = R.string.zen_mode_summary_alarms_only_indefinite; byMinute = R.plurals.zen_mode_summary_alarms_only_by_minute; byHour = R.plurals.zen_mode_summary_alarms_only_by_hour; + byTime = R.string.zen_mode_summary_alarms_only_by_time; break; case Global.ZEN_MODE_OFF: indefinite = R.string.zen_mode_summary_always; @@ -112,6 +115,8 @@ public class ZenModeVoiceActivity extends VoiceSettingsActivity { if (minutes < 60) { return res.getQuantityString(byMinute, minutes, minutes, formattedTime); + } else if (minutes % 60 != 0) { + return res.getString(byTime, formattedTime); } else { int hours = minutes / 60; return res.getQuantityString(byHour, hours, hours, formattedTime); -- cgit v1.1