From d6942db8a9887c506fb680afa62bdd168a550434 Mon Sep 17 00:00:00 2001 From: Stephen Bird Date: Wed, 11 Nov 2015 13:48:39 -0800 Subject: ContactsProvider: Join raw_contacts and data on the proper ID For some reason, we selected the wrong ID to join these tables on. contact_id may be completely different from the raw_contact_id in data. Change-Id: Idd067a90a67a126b22f7bb0281c69e93ad6bed10 --- src/com/android/providers/contacts/ContactsDatabaseHelper.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/com/android/providers/contacts/ContactsDatabaseHelper.java b/src/com/android/providers/contacts/ContactsDatabaseHelper.java index 31d3764..143f6b6 100644 --- a/src/com/android/providers/contacts/ContactsDatabaseHelper.java +++ b/src/com/android/providers/contacts/ContactsDatabaseHelper.java @@ -5339,7 +5339,8 @@ public class ContactsDatabaseHelper extends SQLiteOpenHelper { // Todo: make more performant sb.append(Tables.RAW_CONTACTS + " JOIN " + Views.DATA + " data_view ON (data_view.raw_contact_id = " - + Tables.RAW_CONTACTS + ".contact_id) WHERE data1 = '" + lookupData + "'"); + + Tables.RAW_CONTACTS + "._id) WHERE data1 = "); + DatabaseUtils.appendEscapedSQLString(sb, lookupData); } private void appendPhoneLookupSelection(StringBuilder sb, String number, String numberE164) { -- cgit v1.1