aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge "36951: Lint API Level Warnings for Enums are Confusing"Tor Norbye2012-09-046-14/+281
|\
| * 36951: Lint API Level Warnings for Enums are ConfusingTor Norbye2012-09-046-14/+281
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using switch statements on enums, the compiler will generate extra code to make the switch invocation efficient. For example, it generates a method which looks up all the values in the enum, calls ordinal() on each, and then creates an array which has all the enum values indexed by ordinal. The problem is that this helper code will end up referencing fields which may have a higher API requirement than is currently being used, and Lint would flag these as illegal API references. That's not correct in this case; as long as the corresponding jump table does not actually use these references, there's no problem. This changeset makes lint aware of this pattern, and when it encounters an invalid field reference inside one of these synthetic switch constant lookup methods, it will search for the corresponding table lookup, check whether the actual key is used, and only in that case complain. It also makes error messages associated with enums in general a bit better, when the whole enum class itself requires a higher API. (This would generate a message related to invocation of ordinal() which might not be obvious to everybody.) Finally, it cleans up class name formatting such that we never reference inner classes using "$" in error messages. Change-Id: I28a14084c160866e69f63f62b5bc8f21ee50215c
* | Merge "36942: tools:ignore="DuplicateActivity" just doesn't"Tor Norbye2012-09-047-8/+41
|\ \
| * | 36942: tools:ignore="DuplicateActivity" just doesn'tTor Norbye2012-09-037-8/+41
| | | | | | | | | | | | Change-Id: Iffd270a227a8a76636cbfa5d19c6e0330a8391fb
* | | Merge "36987: TaskHelper can't parse the tools revision number "21 rc3""Tor Norbye2012-09-041-0/+5
|\ \ \ | |_|/ |/| |
| * | 36987: TaskHelper can't parse the tools revision number "21 rc3"Tor Norbye2012-09-041-0/+5
| |/ | | | | | | Change-Id: I4286930a2d36d21d9eb60a1c96c70276b77b9d4a
* | Merge "SDK Manager: fix support for file:// URLs in UrlOpener."Raphael Moll2012-08-313-7/+136
|\ \ | |/ |/|
| * SDK Manager: fix support for file:// URLs in UrlOpener.Raphael Moll2012-08-313-7/+136
|/ | | | Change-Id: I5996187d0ccd002d9ec3fe8c0fa5d17a96671431
* Merge "Avoid "Marker id: 123456789 not found" errors"Tor Norbye2012-08-312-5/+18
|\
| * Avoid "Marker id: 123456789 not found" errorsTor Norbye2012-08-312-5/+18
| | | | | | | | | | | | | | | | | | | | We have some code which runs asynchronously to add or clean up error markers. In some cases this code runs after a project has been closed or deleted, which results in errors. Guard these marker access points with an IResource.isAccessible() check (which performs both exists(), and for projects, isOpen()). Change-Id: Ie4884db13b1e00236c1c219d95c3544fcdee9610
* | Merge "Close XML editors when files are deleted or projects are closed"Tor Norbye2012-08-316-194/+202
|\ \ | |/
| * Close XML editors when files are deleted or projects are closedTor Norbye2012-08-316-194/+202
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The existing hooks for closing the editor when the underlying file is deleted was not working correctly, and was inefficient (since each editor added their own global resource listener, so every editor would find out about every other editor's file changes). Instead, this generalizes the single editor listener which was used to initialize editor types such that it also listens for deletion, and then finds any open editor mapped to that file. It also hooks up to the pre-close events for projects and closes all files related to the project as well. This will hopefully fix this issue as well: 20836: Can't delete a layout XML via Package Explorer > Delete if it has an error Finally, it removes a bunch of now obsolete logging code for an issue which seems to be permanently fixed. Change-Id: I90b38984639a605755f2d67ca2413cc925f730d1
* | Merge "Let ApkBuilder package bitcode library into APK."Shih-wei Liao2012-08-301-1/+5
|\ \ | |/ |/|
| * Let ApkBuilder package bitcode library into APK.Shih-wei Liao2012-08-271-1/+5
| | | | | | | | Change-Id: I54e99cff338a62147af3247446148d88a73a4ddb
* | Merge "Add Translation dialog"Tor Norbye2012-08-308-35/+742
|\ \
| * | Add Translation dialogTor Norbye2012-08-308-35/+742
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL adds a dialog to the locale menu in the configuration chooser which makes it easy to add a new language into the set of languages used by the project. Also add some null annotations. Change-Id: I70ea2f623e6c56684e7b2a51b391f472bf31529b
* | | Merge "Suggest using SparseIntArray instead of SparseArray<Integer>"Tor Norbye2012-08-303-3/+40
|\ \ \
| * | | Suggest using SparseIntArray instead of SparseArray<Integer>Tor Norbye2012-08-293-3/+40
| |/ / | | | | | | | | | Change-Id: I95bf3bc87e4378af6ef866df0a1ffb69f8fd7a41
* | | Merge "Also check SimpleDateFormat calls for explicit locale"Tor Norbye2012-08-306-13/+79
|\ \ \
| * | | Also check SimpleDateFormat calls for explicit localeTor Norbye2012-08-306-13/+79
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset expands on the lint check for calling String convenience methods that are locale sensitive without an explicit locale (issue 36822). It checks whether a SimpleDateFormat constructor that uses the default locale is called, and if so suggests either specifying a locale or using one of the pre-configured locale sensitive instances of SimpleDateFormat. Change-Id: Ic4fcb72c2ee6b31d1534b4d909493fef7dcff867
* | | Merge "Fix keybindings in manifest editor (issue 36540)"Tor Norbye2012-08-302-2/+53
|\ \ \
| * | | Fix keybindings in manifest editor (issue 36540)Tor Norbye2012-08-302-2/+53
| |/ / | | | | | | | | | | | | | | | | | | Unbind the text editor keybindings when any page other than the text editor itself is shown. Change-Id: I1681de20113b3c0627a23872100632f8d28bb698
* | | Merge "Add HTML documentation for ADT templates."Roman Nurik2012-08-307-0/+936
|\ \ \ | |/ / |/| |
| * | Add HTML documentation for ADT templates.Roman Nurik2012-08-307-0/+936
| | | | | | | | | | | | Change-Id: I7e565ebec48a489f880f556c5f990ff0d0380334
* | | Merge "Add lint rule to find incorrect alias files"Tor Norbye2012-08-293-1/+113
|\ \ \
| * | | Add lint rule to find incorrect alias filesTor Norbye2012-08-293-1/+113
|/ / / | | | | | | | | | | | | | | | | | | This helps catch errors like http://code.google.com/p/android/issues/detail?id=36821 Change-Id: I1ceda3183d8b1e29510ba0be2523dc6eb9c7a23b
* | | Merge "Add lint check for potential string locale errors (issue 36822)"Tor Norbye2012-08-2910-10/+360
|\ \ \
| * | | Add lint check for potential string locale errors (issue 36822)Tor Norbye2012-08-2910-10/+360
|/ / / | | | | | | | | | Change-Id: I320af69286e7f0bcee395419acfeea7ed8f8d384
* | | Merge "Minor tweaks and typos"Tor Norbye2012-08-293-3/+3
|\ \ \
| * | | Minor tweaks and typosTor Norbye2012-08-283-3/+3
| |/ / | | | | | | | | | Change-Id: I46630c51a4f055222fb614d73419cb28272b87de
* | | Merge "Update Guava from 10.0.1 to 13.0.1"Tor Norbye2012-08-2912-13/+13
|\ \ \
| * | | Update Guava from 10.0.1 to 13.0.1Tor Norbye2012-08-2912-13/+13
|/ / / | | | | | | | | | Change-Id: Ia51e3e2280c3d360496550df50a540571b9b7582
* | | Merge "Fix source attachments in the *base plugin"Tor Norbye2012-08-291-6/+6
|\ \ \
| * | | Fix source attachments in the *base pluginTor Norbye2012-08-291-6/+6
|/ / / | | | | | | | | | Change-Id: I1d1aa146fad375e06a26c4c60eb203588e7ca542
* | | Merge "Fix SdkManager.hasChanged"Raphael Moll2012-08-292-18/+59
|\ \ \ | |/ / |/| |
| * | Fix SdkManager.hasChangedRaphael Moll2012-08-282-18/+59
|/ / | | | | | | | | | | Also add a simple unit test. Change-Id: I8ed3dfbea07578528036f1dabd75c18f3161819c
* | Merge "Add lint rule which warns about View.setTag(int, Object)"Tor Norbye2012-08-287-1/+286
|\ \
| * | Add lint rule which warns about View.setTag(int, Object)Tor Norbye2012-08-277-1/+286
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset adds a lint rule which looks for potential leaks when using View#setTag(int, Object) where the Object is likely to contain a strong reference to the context, such as views and view holders. http://code.google.com/p/android/issues/detail?id=26984 Change-Id: Ib606485d2b875d2129c339b9b89be0e444629408
* | | Merge "Fix property sheet value completion"Tor Norbye2012-08-2812-225/+518
|\ \ \ | |/ / |/| |
| * | Fix property sheet value completionTor Norbye2012-08-2712-225/+518
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset fixes the value completion such that you can add custom values into properties that also have enum fields. Rather than have separate completion routines for properties based on whether they contain an enum, a flag, a reference, etc., have a single completer which considers all the various formats and combines the results. In addition to combining results, this now also offers completion on dimensions, and offers theme attribute values for references as well. Change-Id: Idbc1799a34b3a3f14ea567654953925bf12afb8f
* | Merge "Issue 34322: Fix handling of import statements"Tor Norbye2012-08-278-3/+210
|\ \
| * | Issue 34322: Fix handling of import statementsTor Norbye2012-08-278-3/+210
|/ / | | | | | | | | | | | | | | Fix the commit prefs lint check such that it correctly identifies scenarios where the innerclass "Editor" is referenced without its qualifying top level class, SharedPreferences. Change-Id: I3a22738508b66ce0b3e836feff91f816b2c368e8
* | Merge "Add target SDK setting to the New Project wizard"Tor Norbye2012-08-2711-309/+710
|\ \
| * | Add target SDK setting to the New Project wizardTor Norbye2012-08-2711-309/+710
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the first page is getting too large, rather than add one more, split some of the contents into a second page. In addition, the new project dialog was missing a workset chooser like the old wizard had, so add one in on the new page now that we have plenty room for it. Some other tweaks as well based on input from Xav. Change-Id: I4dd2334b2f5af623cba4bbb3a6d2d0b053d1763f
* | | Merge "SDK Manager: fix sdk-has-changed."Raphael Moll2012-08-271-6/+36
|\ \ \ | |/ / |/| |
| * | SDK Manager: fix sdk-has-changed.Raphael Moll2012-08-271-6/+36
| |/ | | | | | | | | | | | | | | The SdkManager.hasChanged method was supposed to only look at direct folders in platforms and add-ons, not regular files. Change-Id: I87c3d51bfd7bd2578285f957a9838fadec703401
* | Merge "31340: ADT default for opening editors in textual mode"Tor Norbye2012-08-272-0/+29
|\ \
| * | 31340: ADT default for opening editors in textual modeTor Norbye2012-08-272-0/+29
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When you reopen a file you've already opened in the past, ADT will open the file on the same page (graphical or XML) that you left it at. However, new files are always opened graphically. This changeset will change this such that if you manually switch to XML, new files opened from that point open in XML, and if you switch to graphical mode, new files are opened in graphical mode. This will hopefully help those users who prefer to work in XML mode without negatively impacting those who prefer to work in graphical mode. Change-Id: Ib229b22c31899c1cd9520e6ab48f5902d2782844
* | Merge "Inline devices if there is only one manufacturer"Tor Norbye2012-08-271-5/+7
|\ \
| * | Inline devices if there is only one manufacturerTor Norbye2012-08-271-6/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently the device pulldown shows a single item, "Generic", which itself contains the various generic devices. This CL tweaks the display code such that if there is just a single manufacturer, the items are inlined in the top level menu. Change-Id: If150becaa7dfe225f9ec8e861be1d67ede4f30c4
generated by cgit v1.1 at 2025-05-18 14:45:46 +0000