aboutsummaryrefslogtreecommitdiffstats
path: root/ddms/libs
Commit message (Collapse)AuthorAgeFilesLines
...
* Add @NonNull annotation and configure Eclipse settingsTor Norbye2011-12-222-2/+26
| | | | | | | | | | | | | | This changeset adds a new @NonNull annotation, to match our existing @Nullable annotation, and it adds configuration settings for Eclipse 3.8 / Eclipse 4.2 which configures the new null analysis there to use our own annotations. Note that the annotations only have source retention so there is no extra size or class-loading overhead. (To use findbugs you'll need to temporarily change retention to class-level.) In upcoming CL's I'll use these annotations to clarify the Lint API and other APIs. Change-Id: I99096d8b8a7e25ef002624d592da7700195a5872
* Update SDK codebase to JDK 6Tor Norbye2011-12-2164-145/+542
| | | | | | | | | | | | | | | | | | | | | This changeset makes the SDK codebase compile with source=1.6 (which means it also requires JDK 6). This means that methods implementing an interface requires @Override's. It also means we can start using APIs like the ArrayDeque class and methods like String#isEmpty(). This changeset looks big but the change is trivial: it's basically adding @Override in all the places that need it, along with some other automatic Eclipse cleanup in certain files (such as reordering imports where they were incorrectly ordered (because older versions of Eclipse didn't always handle inner classes right)), as well as cleaning up trailing whitespace and removing some $NON-NLS-1$ markers on lines where there aren't any string literals anymore. This changeset also sets the source and target JDK level to 6 in the Eclipse compiler .settings file, and synchronizes this file to all the other Eclipse SDK projects. Change-Id: I6a9585aa44c3dee9a5c00739ab22fbdbcb9f8275
* ddms: display manufacturer & model for devices.Siva Velusamy2011-12-201-1/+51
| | | | | | | | DDMS displays only the serial number for connected devices. This patch appends the manufacturer & model name to the serial number. Change-Id: I90400365fe984b0b0a198e3c21aaf25eb05aa930
* logcat: Improve auto scroll lock behaviorSiva Velusamy2011-12-143-46/+79
| | | | | | | | | | | | | | | | Setting up scroll lock automatically is broken due to the highly platform dependent nature of the scroll bar events. This patch improves the current situation significantly, but may not be the last word on this subject. This patch does the following: 1. Sets up auto scroll lock on Windows and Linux. 2. Removes auto scroll locking on Mac. Users have to manually press the Pause Logcat button. 3. Renames the "Scroll to latest" button to "Pause Logcat" to more accurately reflect what is happening. Change-Id: I1ce03371d7ac7aeaea218aa3c5c426c69c56a527
* Merge "Use a custom timeout for IDevice.getBatteryLevel."Brett Chabot2011-12-131-1/+2
|\
| * Use a custom timeout for IDevice.getBatteryLevel.Brett Chabot2011-12-091-1/+2
| | | | | | | | | | | | Bug 5697543 Change-Id: I6ce33dd2c8416f5ccfb55b26120edb6a0acf5ad7
* | logcat: when copying items, index into filtered list.Siva Velusamy2011-12-131-7/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | The previous commit introduced a bug: The SWT table model is a list of logcat messages before any filters are applied. But the user sees the filtered messages. So when user selects items in the table, the selection index will not match the index in the input model. This patch applies all current filters to the input model and then indexes this filtered list to get the same items that the user has selected in the view. Change-Id: If955bd5c22e1c587bcf5fe32092f513d53c0d8ef
* | logcat: fix npe & clear log in filtered viewSiva Velusamy2011-12-121-2/+17
|/ | | | | | | | | | | | | 1. Fix NPE when selecting all items: Issue is that in case of a table with SWT.VIRTUAL, tableItem.getData() could return NULL if the item hasn't been shown. So we have to rely on the original model to retrieve the items. 2. When viewing items after applying a filter, clear log will clear the full log but not the filtered view. To clear the filtered view, the SWT ViewerFilters have to be reapplied. Change-Id: I6c66be4e0e8abb6db114588f382bcd3b9fe8ee0f
* logcat: bring up edit filter dialog on double clickSiva Velusamy2011-11-281-0/+5
| | | | | | | When a saved filter is double clicked, bring up the 'Edit Filter' dialog for the selected filter. Change-Id: Idd6766ba95e0d2f228c664ffccf8dbfb5b93b0b8
* logcat: fix tooltip shift distanceSiva Velusamy2011-11-281-0/+11
| | | | | | | Fix for http://code.google.com/p/android/issues/detail?id=22111 which is OS X Lion specific. This fix hasn't actually been tested on OS X Lion! Change-Id: Ifb4397e1482ebacc84cd90e83bb6837b883fbd08
* Merge "Add IDevice.getBatteryLevel()"Brett Chabot2011-11-092-0/+97
|\
| * Add IDevice.getBatteryLevel()Brett Chabot2011-11-042-0/+97
| | | | | | | | Change-Id: I1db67422e2f39206383a3bd760769b2ebbf46ed6
* | Merge "nativeheap: Do not clean up display if a client is killed."Siva Velusamy2011-11-061-17/+21
|\ \ | |/ |/|
| * nativeheap: Do not clean up display if a client is killed.Siva Velusamy2011-11-061-17/+21
| | | | | | | | | | | | | | | | | | Fix for Issue #21554. When a client process dies, the native heap view is immediately cleared. This makes it impossible to view the native heap snapshots for processes that are being killed due to OOM errors. Change-Id: I3b6c868832c6b48e591d31d1643db20887ff8c13
* | Merge "fix for leaky fd, amke sure we close syncservice."Tsu Chiang Chuang2011-11-031-3/+18
|\ \ | |/ |/|
| * fix for leaky fd, amke sure we close syncservice.Tsu Chiang Chuang2011-11-031-3/+18
| | | | | | | | Change-Id: Id639890c3e962dd5993281a0cdd911031aaf7304
* | ddms-heap: Show atleast 1 row.Siva Velusamy2011-11-021-45/+57
| | | | | | | | | | | | | | | | One some platforms, the table doesn't show any rows at all, and there is no way to resize the table. This patch makes sure that there is one row that is always displayed. Change-Id: Ib93839c610926a7f8629436d26bb7ad9485431af
* | logcat: update scroll behavior when buffer is full.Siva Velusamy2011-11-022-6/+37
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | When the logcat buffer is full, any received message will push out an old message. As a result, the messages keep moving up the table, which is annoying if you want to view a particular message. Ideally, we'd keep the view constant, but only the scrollbar moves up to indicate that we have received new messages. But this doesn't work in an SWT table. One solution would be to refresh the table and then scroll it to remain in the same place. This causes a flicker and is annoying. This patch stops refreshing the table when the user is viewing an older item in the table, and starts auto refresh if the scroll bar is again brought to the bottom. In addition it provides a toolbar button that reflects the state of scrolling, similar to a scroll lock checkbox. The one downside to this is that since the scrollbar does not move, the user does not have clue if new messages are being received. The new messages will be noticed only if the user unselects the scroll lock button, or manually moves the scrollbar down. This is a fix for Issue #20805. Change-Id: I12108789265fec38287a466d21505db85892594d
* Merge "Code cleanup: make sure FileInputStreams are closed."Raphael2011-10-182-8/+28
|\
| * Code cleanup: make sure FileInputStreams are closed.Raphael2011-10-132-8/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Various places of the code construct a new FileInputStream on the fly and give it to another method. One many occasions the stream is never properly closed, which can lock files on Windows. 2 specific cases: - Properties.load() doesn't seem to close its input (when looking at the source bundled with the JRE). - The doc of InputSource (used by various XML parsers like the pull parser) indicates the caller should in general not close the stream and the parser itself should do it. Change-Id: I622b54a22f97ed2c9c8fdc56ccde331207d9d212
* | Merge "Make InstrumentationResultParser less chatty on unexpected output."Brett Chabot2011-10-172-2/+23
|\ \ | |/ |/|
| * Make InstrumentationResultParser less chatty on unexpected output.Brett Chabot2011-10-142-2/+23
| | | | | | | | | | | | Bug 5459282 Change-Id: Ib3069b628f476cf73649802f51b7bb22b6ceebaa
* | Logcat autoscroll behavior update.Siva Velusamy2011-10-121-28/+41
| | | | | | | | | | | | | | | | | | | | | | | | Rather than checking the position of the thumb every time entries are added, we listen to the scroll bar being moved up or down by the user. In addition, also update the scrolling behavior whenever entries in the table are selected. Auto scrolling will stop if anything but the last entry is selected. Change-Id: I7b32e9c42bc8e2ad01171b61a5a9ef09d8d0a7b1
* | Remove non-actionable log statement.Siva Velusamy2011-10-101-4/+0
| | | | | | | | Change-Id: I18064d048603c61a5f7d046bbb4cdb39181159de
* | Fix NPE when getCurrentDevice() == null.Siva Velusamy2011-10-101-1/+13
| | | | | | | | Change-Id: I0f9eaf599b5ab22487408ea74d597ea61a22793f
* | Add a new implementation for symbol resolution.Siva Velusamy2011-10-103-13/+436
| | | | | | | | | | | | | | | | | | | | The old implementation can still be used by setting the env variable ANDROID_DDMS_OLD_SYMRESOLVER. With the new one, all errors are collected, and displayed in the UI at the end, grouping similar errors together. Change-Id: Ibf2fa2122109b2eaf37579d65a3d0b18f475b436
* | Add a whitespace character when scanning across tokens.Siva Velusamy2011-10-091-1/+6
|/ | | | Change-Id: I6473c1e987c37fb69f808c26e2a7e0f451ab1d34
* Minor refactor: keep sizes of snapshot ArrayList's in sync.Siva Velusamy2011-10-061-8/+12
| | | | Change-Id: I30aef911df1146ff9a64c4d08c4371c2937d4e94
* Add support for importing saved heap data.Siva Velusamy2011-10-064-33/+458
| | | | Change-Id: I8552af1754f5093dcdb156f7f81e3beef776835a
* Model diff snapshot as a subtype of a regular snapshot.Siva Velusamy2011-10-064-27/+94
| | | | Change-Id: Ic701255c586530214b51a1553b66aa60c6c7b538
* Merge "Create FileListingService#getChildrenSync"Brett Chabot2011-09-291-10/+40
|\
| * Create FileListingService#getChildrenSyncBrett Chabot2011-09-291-10/+40
| | | | | | | | | | | | | | | | | | Useful for cases where callers want to be informed of adb communication errors when retrieving child files. Bug 5392097 Change-Id: I82087d24d08f4e1b2fcda67156835367dc1bb824
* | Provide a way to show/hide the filters column.Siva Velusamy2011-09-292-8/+40
| | | | | | | | Change-Id: I7c94daa006987a0983cdb3cee02a35f6e678d86e
* | Use a text box instead of a browser in tooltip area.Siva Velusamy2011-09-291-10/+4
| | | | | | | | Change-Id: Ica610ef4cefffaef3b6404a425c8b4551e741676
* | Display tooltips only for long messages.Siva Velusamy2011-09-292-2/+36
| | | | | | | | | | | | | | | | | | Currently, the tooltips are displayed for all logcat messages. This patch makes them show up only if the logcat messages are longer than the width of the column in which they are displayed, i.e., tooltips will be displayed only for those messages that could be clipped. Change-Id: Ib5bbce7d055656d2cc8063efdf5fed5910b24ad0
* | Check for scrolling before refreshing the table.Siva Velusamy2011-09-281-1/+4
|/ | | | Change-Id: Id65b11216a8240e3297072f0af094d69d924a8b3
* Add support for exporting heap data.Siva Velusamy2011-09-281-2/+61
| | | | Change-Id: Ica8de494934195f30b75b8295d0908e3aacdefff
* Add support for Select All & Copy Paste.Siva Velusamy2011-09-283-4/+87
| | | | Change-Id: I4b41b6ee5a7a5600ca3b37d3addf1dce7d1e072a
* Construct NativeStackCallInfo with full symbol address.Siva Velusamy2011-09-283-15/+18
| | | | | | | | | Addr2line constructs NativeStackCallInfo for a symbol using its offset within the library as the address. This patch is a minor change to make it use the address in the executable instead of the offset in the library. Change-Id: I3e3e960f6c5abefac83b670e3ab23a78c57a8e56
* Check for relevant stack frame using source library.Siva Velusamy2011-09-271-45/+37
| | | | | | | | In a stack trace, skip all frames from libc and from methods matching malloc/realloc/calloc etc to identify the source frame where heap memory is allocated. Change-Id: Ia8661c7ff58b3db502c92b2f48819c3219861a73
* Append prefix "Z" only for Zygote allocations.Siva Velusamy2011-09-232-2/+2
| | | | | | | Cross checked with vendor/google/tools/nativeheapdump and made sure that output of both tools match. Change-Id: I129791ec42e7c0f4197fd59f687477b3d82e4d20
* Provide ability to view just the new allocations.Siva Velusamy2011-09-231-17/+68
| | | | | | | | Rather than viewing the entire snapshot, users can now view just the allocations that have happened since the previous snapshot. Change-Id: I6115fdcd3928db775d8b77c078c9fce2539779ac
* Override hashCode.Siva Velusamy2011-09-231-0/+19
| | | | | | equals() was overridden previously, but not hashCode. Change-Id: I82371f853f1ab23b081ed78fc54f5e66ecccbe3e
* Add support for filtering out zygote allocations.Siva Velusamy2011-09-225-15/+114
| | | | | | | Maintain separate list of non zygote allocations and switch to displaying the filtered list based on user input. Change-Id: Ib1fbbcb2ada55255a2f9dad02f3cf1dea18cbeda
* Show percentage of total heap size for each row.Siva Velusamy2011-09-222-5/+34
| | | | Change-Id: Iabfb5f246ca5c22cf0097300e66ba128b5174562
* Make library to be the first column in the details view.Siva Velusamy2011-09-222-11/+11
| | | | | | | | | | | There are two reasons for this change: 1. When allocations are grouped by library, it is nice to have the library in the first column immediately signifying the grouping. 2. The first column is always left aligned on some platforms (Linux). This is not the right alignment for showing numbers (they should be right aligned). Change-Id: I36a3fef17265da41e3e6d709f38d3fd6e28d233b
* Support grouping of allocations by library.Siva Velusamy2011-09-226-40/+367
| | | | | | | | | | | | Currently, all allocations are displayed as a list sorted by the size of the allocation. This patch set enables the toolbar checkbox to group the list of allocations by library. When this is checked, the display refreshes to show a tree with the root nodes being libraries, and their children being the list of allocations made from that library. Change-Id: Ibb61242db8c6e58d300f767f0b2b11b6b7a9530d
* Add support for user specifying search paths in the UI.Siva Velusamy2011-09-222-10/+89
| | | | | | Fix Addr2line to use the search path to locate binaries. Change-Id: I5ba901144faa70d4507d9286ade1cc49828d41ac
* Findbugs fix: Use Character.toString()Siva Velusamy2011-09-221-2/+2
| | | | Change-Id: I7a50c09b3cc7028caef2302154bfe6fea8bef556
* Resolve addresses to symbols in a separate thread.Siva Velusamy2011-09-212-2/+103
| | | | | | | | After retrieving a heap dump, start a thread to resolve all the addresses present in the dump. Refresh the UI with the resolved symbols once the process is complete. Change-Id: Iac2d24e91685b6c4e10985b3dfce00e79e1db10b