| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
| |
Change-Id: Idde24b6b893d1029d48ba32766110a6a3cdf73c6
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds support for invoking a find dialog when
the logcat view is in focus. The dialog can be invoked
via Edit -> Find (Ctrl + F), or via the context menu.
The dialog provides a way to specify a search term and
allows the user to search forward or backward in the
list of messages.
Change-Id: I7e7c6b20a051c161f035b3b45aba5f119f2c11a9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First, update our various project-specific Eclipse compiler settings
configuration files to include the new Eclipse 4 flags.
Second, turn off the "Unchecked conversion from non-annotated type to
@NonNull" warnings; there are hundreds or thousands of these, and
there isn't much we can do about them when they're coming from
platform and library APIs.
Third, make the lint projects warning-clean again by addressing
various warnings Eclipse found (such as some unclosed resources and
some null handling issues; yesterday's null annotation fixes only
addressed errors, not warnings.)
Change-Id: If75f7401a1cbeef1bf58b47ccaa9ad17bede7f91
|
|
|
|
|
|
|
|
|
|
| |
This patch enables users to customize the colors used for
log messages of different priority levels. These settings
are available in the Android -> Logcat -> Colors preference page.
This fixes: http://code.google.com/p/android/issues/detail?id=31494
Change-Id: I9430f573f84f09d00bfe25d6e53eeccf4e338e9d
|
|
|
|
| |
Change-Id: Iab558863997bb8c5f72c8ef9349719ca003c1724
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To help users who don't know about logcat, we automatically monitor
logcat output to see if there are any errors from a user application,
and if so, display the logcat view.
This patch makes this feature a bit easier to use:
- The first time the logcat view is about to be displayed, a dialog
is shown that allows the users to enable/disable auto monitoring.
Note that this can also be done via logcat preferences.
- Users can now control the message priority that will trigger
auto monitoring.
- Once the logcat view has been displayed, we turn off auto monitoring
until the next launch. This reduces overhead and avoids unnecessary
change of focus in cases where the user is already interacting with
the logcat view.
Change-Id: I44a9ccea9148dea7bf6dc7d7864a1bb56a7376fe
|
|
|
|
|
|
|
|
|
|
|
| |
When hprof files are obtained from the device, they are saved by
default. This patch changes the default to open the hprof file if
it is a registered content type implying that there is an editor
for it.
This fixes http://code.google.com/p/android/issues/detail?id=21297
Change-Id: Ic89eb59855888daa4775852181d2af245c8893d9
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixes a bunch of outstanding issues related to
scrolling in the presence of a full buffer.
Currently, the logbuffer is provided as the input model to the
TableViewer, and ViewerFilter's are used to filter the data.
This patch removes the JFace toolkit and directly works on the
SWT Table. When log messages arrive, rather than refreshing the
entire table, we can now just delete the TableItems corresponding
to the logs that were pushed out, and add new TableItems for the
incoming logs.
At steady state, this implementation performs far less work than
the previous implementation. However, during startup, this
implementation will perform more work since it does not use the
SWT.VIRTUAL bit (as all TableItems are created anyway).
Also, zebra striping has been removed to avoid appearance of flicker
when scroll lock is on.
Auto scroll lock behavior has been removed, and scroll lock button
behaves exactly like the scroll lock button in an Eclipse console.
Change-Id: Ic14487f7ad41338a581aed0ba2d85d292a584950
|
|
|
|
| |
Change-Id: If2b847d6937ea64b2727ff78f1c94850f91da81b
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logcat provides two different ways to resolve the source corresponding
to a stacktrace: the primary method is to search for file name and
line number, and the secondary method is to search for the fully
qualified method name. Which method is used depends on a preference
setting.
This patch makes the following changes:
- Resolution now uses both the methods - it first tries to resolve
using the fqmn, and then improves the result using the filename/
linenumber if that is available.
- Since both methods are used, the preference setting can be removed.
- If there are multiple search results, rather than always jumping
to the first result, user will be prompted to select a result
This fixes http://code.google.com/p/android/issues/detail?id=18514
Change-Id: I1abdfe5f7e70423fb04d62f1092e1a8037537837
|
|
|
|
| |
Change-Id: I3877a7418da193cbe3759f25daafa3309bb8c05a
|
|
|
|
| |
Change-Id: I8335bf7d72af4184d505826dc1024a3dde3b67b6
|
|
|
|
| |
Change-Id: Ia7ceed6297048779b9d591a518c2ae3c8cbfe60c
|
|
|
|
|
|
|
|
|
| |
Both monitor and ADT use the same ddms-plugin preference pages.
However, certain preference fields are only applicable in the context
of ADT + Eclipse. This CL wraps the creation of such preferences
around a check for the availability of the ADT plugin.
Change-Id: Ic1c425d00feae3eeceece53e226baa99c3c8dc93
|
|
|
|
| |
Change-Id: I3906416a7b5a4bf7b7e2f86ee3155c22d93a3c2b
|
|
|
|
|
|
|
|
| |
Currently, source revealers just reveal a file in the current perspective.
This changeset adds an option to first switch perspectives before revealing
the source file.
Change-Id: I5e89a89276f48ba41504434a1d2bb417f9ba541c
|
|\
| |
| |
| | |
device."
|
| |
| |
| |
| |
| |
| | |
Before selecting a target device.
Change-Id: I704d8af3d5f89dcbc5eb8e5e6b6090ddd8561e22
|
|/
|
|
| |
Change-Id: I89bf6b84a2ef2ed9a876eec41fae9a974ba93137
|
|
|
|
| |
Change-Id: I4989ce98d4c6a600ca075ee919e5a0e1a40a4497
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changeset adds a new @NonNull annotation, to match our existing
@Nullable annotation, and it adds configuration settings for Eclipse
3.8 / Eclipse 4.2 which configures the new null analysis there to use
our own annotations. Note that the annotations only have source
retention so there is no extra size or class-loading overhead. (To use
findbugs you'll need to temporarily change retention to class-level.)
In upcoming CL's I'll use these annotations to clarify the Lint API
and other APIs.
Change-Id: I99096d8b8a7e25ef002624d592da7700195a5872
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changeset makes the SDK codebase compile with source=1.6 (which
means it also requires JDK 6). This means that methods implementing an
interface requires @Override's. It also means we can start using APIs
like the ArrayDeque class and methods like String#isEmpty().
This changeset looks big but the change is trivial: it's basically
adding @Override in all the places that need it, along with some other
automatic Eclipse cleanup in certain files (such as reordering imports
where they were incorrectly ordered (because older versions of Eclipse
didn't always handle inner classes right)), as well as cleaning up
trailing whitespace and removing some $NON-NLS-1$ markers on lines
where there aren't any string literals anymore.
This changeset also sets the source and target JDK level to 6 in the
Eclipse compiler .settings file, and synchronizes this file to all the
other Eclipse SDK projects.
Change-Id: I6a9585aa44c3dee9a5c00739ab22fbdbcb9f8275
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, there are three locations that require the ability
to open a Java file containing a particular method: DDMS stack trace,
logcat and traceview.
The logcat and traceview panels use JDT to open up a Java editor on
a method. As a result, these plugins have a dependency on JDT.
The stack trace panel uses the DDMS plugin's sourceRevealer extension
point to achieve the same purpose. ADT plugin provides an
implementation of the sourceRevealer plugin. As a result, this
introduces a JDT dependency only on the ADT plugin.
This patch makes both the logcat & trace view code to use the same
sourceRevealer extension point. As a result, all source code
involved in revealing the source of a Java method is present in
a single place, and DDMS & Traceview plugins don't depend on JDT
anymore.
Change-Id: I5b840dc4d6ad45e5611a80cff740101c484a99dd
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When ADT plugin starts up, it attempts to set the console to be used
for certain parts of DDMS to be the Android console.
Doing this however causes the DDMS plugin to be activated, which
launches adb server if it is not already there.
Removing this enables us to not touch adb unnecessarily.
This patch moves the initialization of the DDMS console into the
DDMS plugin, and uses the DDMS console as opposed to the Android
console for messages from DDMS.
Change-Id: I010a7028a2f22ac4da1c55903e001dcdd329d91f
|
|
|
|
| |
Change-Id: I79ae1bff5086146cc60b4496f4b0464ffd642651
|
|
|
|
|
|
|
|
|
| |
DDMS plugin checks for 3 files when the tools location is set.
If any is missing, it won't connect to ADB. However there is
no way to know that exactly. This adds a log with the path
of the missing file.
Change-Id: If7b679342e6eef314470f63998cdb701e1e1920b
|
|
|
|
| |
Change-Id: I42508186ea339de1d97f0de2e801e6152311881a
|
|
|
|
| |
Change-Id: Ia2f02cbb02a89df6f665739427d842d6826a61cd
|
|
|
|
|
| |
Bug: 5390877
Change-Id: I81e77cf57a358e6c0583d592d104a93475ab37ae
|
|
|
|
| |
Change-Id: I3ade32621326456f030d9aaa581b011420fe4413
|
|
|
|
|
|
|
|
| |
When a error message is detected on logcat, display logcat view but
with a filter for the application selected so that only the relevant
messages are displayed.
Change-Id: Ic84c59b63519302eac286ae243b228a305288b3d
|
|
|
|
|
|
|
|
|
| |
- When applications are launched (run/debug) on a device, start
monitoring the logcat output on that device.
- If some important message comes across, and the logcat view is not
currently displayed, then activate it.
Change-Id: Ib88973badde4cb2860379129dfe0eb03a3f955dc
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Until now there was only one instance of LogCatReceiver. This
instance would listen to the logcat output from the currently
selected device.
This patch modifies this behavior to make one LogCatReceiver
responsible for listening to only one device. If there are multiple
devices, then multiple instances of LogCatReceivers are instantiated.
The instantiation is also moved to a separate factory.
This modification allows for the scenario where the LogCatReceiver's
can be instantiated independent of the UI, and are reused by the UI
whenever needed.
Change-Id: I46008cbd5ee41880372a62e7e09634ce2d2fc122
|
|
|
|
|
|
|
| |
Add a preference where users can set the size of the message list.
Defaults to 1000.
Change-Id: Ia888c3802f07607274bfbdca0ade8fbda009ba55
|
|
|
|
| |
Change-Id: Idbf3bc093f2a049b5e0e0cd9605a6f8bdc8f7723
|
|
|
|
| |
Change-Id: Ia2693424f0106fb3aa1724c211a8e1273f3a0c28
|
|
|
|
|
|
|
|
|
|
|
|
| |
The existing logcat view has been renamed to OldLogCatView. It is
still accessible from the Views menu with the title:
"LogCat (deprecated)".
The new view is the default. The only missing feature compared to
the old view is the lack of double click handler. Subsequent CL's
add this feature.
Change-Id: If8ce594539f3f82c0c47ebb2d46159d6feed5a21
|
|
|
|
| |
Change-Id: Id29498fde61185a63812b7267b64560a8fd54dc5
|
|
|
|
| |
Change-Id: Ibedcb5627170d107cacf5e9d212f9da11c8d1f3e
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I ran the latest version of findbugs on our codebase and fixed some
(not all!) of the warnings.
I also ran with Eclipse 3.7 RC3 and updated our compiler warning
settings for the new warnings that are available.
I also fixed some DOS line endings in some files (formatted with CRLF
instead of LF).
Change-Id: I9a9d34a9b60f2cb609245793815d96a4587007b0
|
|
|
|
| |
Change-Id: Ifcf5190547e9e37bdda766ad3d57a312c2dbb481
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After applying it, please run the Eclipse's Externalize Wizard at “Source -> Externalize Strings…”. This ensure that hard-coded strings added between the time the patch was created and the time it was integrated will also be externalized.
From the time this patch is integrated on, each new string created in the plugin
should be added to the following files:
eclipse/plugins/com.android.ide.eclipse.ddms/src/com/android/ide/eclipse/ddms/i18n/messages.properties
Example: JavaClassName_MessageID=<string value>
<string value> refers to the string itself.
eclipse/plugins/com.android.ide.eclipse.ddms/src/com/android/ide/eclipse/ddms/i18n/Messages.java
Example: public static String JavaClassName_MessageID;
In the Java class, the new string should be referenced this way:
Messages.JavaClassName_MessageID
Related patches: All patches with the [EXTERNALIZATION] tag
Changes after review:
Code formatted according using android code formatter template
Merged Strings DeviceView_Unable_Create_HPROF_For_Application and DeviceView_Unable_Create_HPROF_For_Application.
Removed Motorola copyright notices.
Change-Id: Id889db593ef313760515f28b5973d3a9a8ad80d0
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ddms and (one of) hierarchy viewer perspective.
- feature about for traceview/hierarchyviewer
- use the draw9patch icon for the resource view in ADT
- use the emulator icon for the emulator control view in DDMS
- use the new android icon for the ADT wizard.
Also standardized on <toolsname>-<size>.png for the icon names.
ADT uses android-##.png
Change-Id: I1ce2a0dae5d256049b381552bd89aef717f51da6
|
|
|
|
|
|
|
|
|
| |
This action allows the user to create a new folder if the current
selection in the tree is a folder. It executes the "mkdir" command
on the device. If an error occurs during execution, a popup is
displayed.
Change-Id: Id94485502849679ee9c753882b3e46f30e0edd1e
|
|
|
|
|
|
|
|
| |
This can be a matter of personal taste, but I find it a lot
more readable to write an if {} else {} sometimes, and it's
perfectly valid, so really it shouldn't be marked as a warning.
Change-Id: Iac1b9bd5f9602b5018f7432422e0a083f4836490
|
|
|
|
| |
Change-Id: I9837714c5673d43fa7108b16ab264f1017c4bd3d
|
|
|
|
| |
Change-Id: I4ba19e12a7d11df3d3c1053c30f3998a93b5fb06
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New DDMS extension: traceviewLauncher.
This allows another plug-in (traceview) to provide
a way to open traceview file. If this doesn't work
it revert to the default behavior of DDMS which is to
open the external traceview program.
also reverted the extension of traceview file
from .atv to .trace because earlier versions of
Android would automatically create those files
using this extension.
Change-Id: I2605ad47e501770ae100da2ace781b1d5d8cebc5
|
|\ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When the user clicked on the "Restored Defaults" button,
the "ADBHOST value:" field could still be enabled while
the "Use ADBHOST" field was disabled.
This commit fixes the problem.
Change-Id: Id5948fed655a7034a65cb96b509e1ad80226a93b
|