aboutsummaryrefslogtreecommitdiffstats
path: root/lint/libs/lint_checks/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Issue 34322: Fix handling of import statementsTor Norbye2012-08-271-2/+7
| | | | | | | | Fix the commit prefs lint check such that it correctly identifies scenarios where the innerclass "Editor" is referenced without its qualifying top level class, SharedPreferences. Change-Id: I3a22738508b66ce0b3e836feff91f816b2c368e8
* Merge "Use simple markup for bold and monospace in lint issues"Tor Norbye2012-08-2737-137/+140
|\
| * Use simple markup for bold and monospace in lint issuesTor Norbye2012-08-2337-137/+140
| | | | | | | | | | | | | | | | | | The explanation text for issues can now contain some simple markup such as * around sentences for bold and ` for monospace. In the HTML report this is converted to HTML markup using <b> and <code> spans, as well as <a> for http:// links. Change-Id: I875a55a0ab9a61c2e8bb493ad94d5e4d51dd1072
* | Merge "Warn about non-recent targetSdkVersions"Tor Norbye2012-08-272-5/+45
|\ \ | |/
| * Warn about non-recent targetSdkVersionsTor Norbye2012-08-232-5/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset changes the default targetSdkVersion written into new projects from being hardcoded to "15" to being the same level as the build target's API level. It also adds a new lint check which looks at the targetSdkVersion and complains if it's not the same as the highest known version (currently 16). The issue explanation points to the javadocs for the android.os.Build.VERSION_CODES class for details on how to upgrade the app. Change-Id: I00c2bd7cd8fa239b9fd1de9b2d35ff9faf87d25f
* | Lint: IconDetector - catch more cases in 3.0Marius Volkhart2012-08-271-2/+7
|/ | | | | | | | Developer documentation says naming convention for 3.0 and up is still ic_menu for action bar icons so if name.startsWith ic_menu need to use the correct px count Change-Id: I9db3199f805934a0bad3eac3b1306ef881b0e631
* Tweak API check error messages for constructorsTor Norbye2012-08-211-1/+6
| | | | | | | | | | Instead of referring to "java.io.IOException#<init>" in the error messages, refer to this method as "new java.io.IOException", since the fact that constructors get mapped to the internal name "<init>" isn't something everybody knows. Change-Id: I4e9aacd9cfd3acae340737d4e3094c6dbdcf52f5
* Fix class to source mapping for the super() keywordTor Norbye2012-08-211-0/+3
| | | | | | | | | | | | | The API checker needs to look up the corresponding source code source range for a given bytecode method dispatch, and the line number information found in the .class file is not accurate enough. Lint has some heuristics to search for the corresponding source range, but this did not work properly for cases where the method call was a parent constructor, via the "super()" call. It also fixes a bug in handling the default package. Change-Id: I15bb07b6709ab9a53376398fe92715f6e6eba968
* Recommend java.lang.Math instead of android.util.FloatMathTor Norbye2012-08-091-31/+13
| | | | | | | | | Apparently java.lang.Math is faster than FloatMath now with the newer JITs. This reverses the old lint rule which would recommend using FloatMath instead of Math with the opposite recommendation, provided minSdkVersion is Froyo or greater. See issue 36199 for more. Change-Id: I362cb7da011d39f5620db96e113f8255a828d40b
* 36175: Lint crashes with java.nio.BufferUnderflowExceptionTor Norbye2012-08-091-10/+28
| | | | | | | This CL adds some code to more gracefully handle problems with the Api Checker's binary cache. Change-Id: I02c86ab16b857b88df8945c84cb92c7217a6144a
* Refactor common.jarXavier Ducrohet2012-08-077-7/+7
| | | | | | | | | | | | | | | Move resources and com.android.util.Pair into layoutlib_api where they belong since layoutlib depends on them and we need to control the API. Made a copy of Pair to stay in common.jar but moved it to com.android.utils.Pair (the one in com.android.util.Pair is marked as deprecated to prevent usage where applicable). Also moved XmlUtil and PositionXmlParser to com.android.utils to match Pair. Change-Id: I21d7057d3f2ce604f86a3bb1fa3c130948c93b89
* 35875: Lint too strict about translating strings by default.Tor Norbye2012-08-061-2/+30
| | | | | | | | | | | | | | | | | | This changeset updates the issue explanation for the translation detector to explain the translatable=false and donottranslate.xml mechanisms to handle non-translatable strings. It adds a quickfix for missing translation items to set the translatable attribute to false. It also makes lint warn where you're using translatable=false on strings in a locale-folder, as well as when you're translating a string defined as translatable=false in the base folder. And finally it also bumps up the severity of the extra translations issue as justified in issue 35875. Change-Id: I7539464b234b0a4b444bf9f188ce5b819f962430
* Merge "Add support for additional languages in the typo detector"Tor Norbye2012-08-062-125/+318
|\
| * Add support for additional languages in the typo detectorTor Norbye2012-08-032-125/+318
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This checkin adds typo databases for six additional languages, as well as several fixes to the infrastructure. First, it now supports "globbing", since for example the German typo database contains glob patterns of the form "asymetrisch*->asymmetrisch*". Second, it supports multiword typos (such as "all zu->allzu") which caused some complications (since this means that the typo detector can match beyond the word boundary it was passed in). Third, it adds a bunch of validation code to the type dictionaries, which uncovered a bunch of inconsistencies (duplicate entries, using "-" instead of "->" for some separators, etc). There's now a unit test which produces a cleaned up version of each dictionary file, as well as tests to ensure that the ASCII and the UTF-8 comparison methods are in sync (and this uncovered some bugs which were fixed.) Finally, it fixes the HTML reporter such that it properly handles UTF-8. Change-Id: Ie32cbbe489687a7b50184696a027f87c2e21c409
* | 35804: When importantForAccessibility="no" is set, don't warnTor Norbye2012-08-031-0/+7
|/ | | | | | | | | | | | This changeset fixes 35804: ContentDescription should not flag if importantForAccessibility="no" When the above attribute is set on a View, the accessibility detector will not flag the corresponding view for missing a contentDescription attribute. Change-Id: I953235a04f1b1ee0f05a94604a2f364c09f851a1
* Fix lint-on-save for .class file detectors in Java filesTor Norbye2012-08-011-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | This changeset fixes the lint-on-save behavior in Java files such that the classfile based checks are run after the .class files are up to date. It also makes lint-on-save work when Project > Build Automatically is turned off, by adding a new resource listener, and it modifies the IFileListener interface to make resource listening more efficient; in particular, it passes the flag mask such that listeners can ignore events such as markers getting added or removed from a file without the content changing. It also makes some improvements to the lint infrastructure. First, it adds an indirection in the LintClient such that reading bytes from files can be customized by the client (to for example add caching or to read contents from memory not yet flushed to disk). It also allows inner classes to share the contents of the source file between each context (while debugging the above I noticed that each inner class node had its own class context and therefore would re-read the source file repeatedly.) Change-Id: Ib9572cebe1269fe05c3af1369610525ea3b44061
* Multilingual typo checkerTor Norbye2012-07-312-108/+345
| | | | | | | This changeset generalizes the lint typo checker to handle non-ASCII languages (with UTF-8 encoded typo dictionaries). Change-Id: If21a2047a127848db77d9ec6f9aae3c052e0f288
* Merge "Fix 35171: ExportedReceiver flags app widget receivers"Tor Norbye2012-07-302-10/+12
|\
| * Fix 35171: ExportedReceiver flags app widget receiversTor Norbye2012-07-242-10/+12
| | | | | | | | Change-Id: I0e2959c4183d0063b66ec4ade98029a0e3e17c9d
* | Merge "26501: Handle padding between image and text"Tor Norbye2012-07-271-1/+2
|\ \
| * | 26501: Handle padding between image and textTor Norbye2012-07-271-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The visual refactoring for converting a LinearLayout with a <TextView> and an <ImageView> adjacent into a single <TextView> using a compound drawable, needed to properly handle spacing between the two widgets. This changeset updates it to convert margins between the views into a single drawablePadding attribute. Change-Id: Idb077e3324c279d41fdc0baa68008fe862d8181a
* | | 35588: @SuppressLint does not work on constructors in Java filesTor Norbye2012-07-273-26/+28
|/ / | | | | | | | | | | | | | | | | | | | | | | | | The AST-based check for whether an issue is suppressed did not take constructors into account. This was because the AST node for constructors (ConstructorDeclaration) does not extend the AST node for method declarations (MethodDeclaration). This mistake was made in a couple of other detectors as well. (Also renamed test class which did not have the correct name (detector class + "Test") so jump to test did not work.) Change-Id: I0ecf99ab7d0357a03e300b7197ae84079f0ddbd1
* | Merge "Improve handling of library projects in lint"Tor Norbye2012-07-242-4/+46
|\ \
| * | Improve handling of library projects in lintTor Norbye2012-07-242-4/+46
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset improves the way lint handles library projects. Until now, running lint on project "master" would also look up any library projects referenced by the master project, and analyze the library projects as well. This is necessary in order to correctly compute unused resources for example, since it's possible for a resource to be defined in one project and referenced in another. However, while this behavior is desirable for users who partition their code up into library projects, it has some serious problems for users who are using a third party library project: - Their lint output can be swamped with errors from the library which they have no control over. - If for example the library provides translations into 60 languages, lint will use these 60 languages as the set of languages targeted by the application, and complain about all strings in the master project which are not translated into all the languages. This changeset makes a key change to how library projects are handled: (1) If you run lint on all projects (including the library projects), then there is no change from before. (2) If you run lint and specify just a project, then lint will continue to analyze the project as well as all its libraries, but will only report problems on the user-specified project. The way this is done is by a new "report errors" attribute stored with each project. All projects that are explicitly referenced on the command line (or selected in the Eclipse UI), and all projects that are found recursively if you specify a top level directory, all these projects have their "report errors" flag set. Any remaining projects, which would be those found through library project references, these have their report errors flag cleared. And whenever lint is processing errors, it will filter out errors for projects that are not reporting errors. This addresses issue http://code.google.com/p/android/issues/detail?id=33847 as well as a number of other requests (in StackOverflow and elsewhere) around the ability to filter errors in library projects. Change-Id: I9d084f598c678ecf79cfe70d8ea7a84844333acc
* | Fix String#format checksTor Norbye2012-07-231-16/+34
|/ | | | Change-Id: I83023903a7744b1372a832dfdc56b595c21f4902
* BuildfixTor Norbye2012-07-231-1/+1
| | | | Change-Id: I789b086fff06e3b0106995a80dcdb96608447fb6
* Merge "Tweaks to the lint CLI offsets"Tor Norbye2012-07-234-23/+24
|\
| * Tweaks to the lint CLI offsetsTor Norbye2012-07-234-23/+24
| | | | | | | | Change-Id: I20592372d41235b36227a0d36014d77c23c7fc58
* | Merge "35049: @SuppressLint("NewApi") doesn't work on local variables"Tor Norbye2012-07-232-1/+171
|\ \
| * | 35049: @SuppressLint("NewApi") doesn't work on local variablesTor Norbye2012-07-232-1/+171
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The @SuppressLint annotation can deliberately be placed on not only classes and methods but on parameters and local variables too. For AST-based (Java source-based) lint checks, this works fine. However, some lint checks, such as the API Check, is based on analyzing the bytecode. Annotations placed on local variables and parameters do not make it into the .class file, so these annotations do not work to suppress errors when placed on local variables (or parameters). The @TargetApi annotation applies only to the bytecode based API check, so its metadata only allows the annotation to be placed on methods and classes and constructors. However, the @SuppressLint annotation needs to continue to be available for the AST-based checks. This CL adds a new lint check, a "meta" check, which actually looks for invalid @SuppressLint annotations, and warns about these. With the new lint-on-save behavior, this means you instantly get feedback if you attempt to suppress an annotation in the wrong place. (Note that the quickfix for adding annotations has always enforced this and placed annotations out at the method level, but as shown in issue 35049, developers place them there deliberately themselves.) This CL also fixes an unrelated problem (shown in issue 34198) that the add suppress annotation code could sometimes add multiple versions of the same id into the annotation. Change-Id: I5bc61c6315edfcfc20103d1e580e389dd8e6a09b
* | Merge "Make the px and sp lint checks look at style textnodes too"Tor Norbye2012-07-231-0/+83
|\ \ | |/ |/|
| * Make the px and sp lint checks look at style textnodes tooTor Norbye2012-07-171-0/+83
| | | | | | | | Change-Id: I0535f8f59e5db4087677702916b95fb06b7b67d0
* | Add basic flow analysis support to lintTor Norbye2012-07-233-1/+603
| | | | | | | | | | | | | | | | | | | | | | This changeset adds in the ASM analysis library (an optional part of the ASM package lint is already using to process bytecode). It also adds some basic flow analysis to the SecureRandom detector to detect whether a given dispatch to a field of type java.util.Random is actually pointing to a java.security.SecureRandom, in which case it flags calls on it to setSeed() where the argument is a fixed integer. Change-Id: If85ab9f8db0e801a01f1a3ea845865b4f98e259c
* | Add lint checks for wakelock and secure random problemsTor Norbye2012-07-233-1/+258
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset adds new two lint bytecode-based detectors. The WakelockDetector looks for problems with wakelocks: - Calling release() in onDestroy() rather than in onPause() - Calling acquire() but never calling release() anywhere in the app. The SecureRandomDetector looks for problems with the SecureRandom random number generator: - Calling setSeed() with a fixed number, such as a string literal, or something equivalent (such as a static field reference of this or some other class) - Calling setSeed() and passing in System.nanoTime or currentTimeMillis since these are considered predictable seeds. These are both using the new fast-dispatch mechanism for bytecode detectors in lint. In both cases, there are more complex control flow we should be checking using flow analysis; that's for an upcoming CL where we add ASM's analysis library. Change-Id: Iec2a95b042b8a3e4e976923cc62e9dccf2dfeca5
* | Add bytecode method call dispatch for lint rulesTor Norbye2012-07-238-201/+93
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This changeset adds shared dispatch for bytecode based rules. We already have this for XML and Java source trees: detectors can register interest in a particular element or attribute name, or a particular method call name, and then the source is processed in a single pass, and a quick map lookup dispatches to any detectors interested in that particular item. This has the important property that adding new detectors does not linearly slow down lint: it does not process each XML document an extra time for each newly added rule: the new rule just adds one more entry into a dispatch table, and only for the specifically interesting tag name (for example) is there an extra dispatch to the new detector. This changeset adds a similar mechanism for the ASM based bytecode detectors. Until now, each detector would be handed the class node of the outer class. This changeset adds a couple of new dispatch methods: First, a way to register interests in method calls of a particular type, and second, a way to registere interest in types of ASM nodes. In addition to the new visitor, this changeset rewrites a couple of detectors to use the new dispatch approach (there are new detectors in the pipeline which will also take advantage of this), and cleans up handling of positions a bit. Change-Id: Ib115bd3418b6c63bdcd49fec046e91a73daf38a9
* | Added a lint check that makes sure no private keys are packaged in an app.Sebastian Porst2012-07-192-1/+123
| | | | | | | | Change-Id: I65d7064efb36002713a3083378af9200331ce793
* | 35190: Lint doesn't detect illegal API usage in constructorTor Norbye2012-07-192-7/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | Constructors are not like methods: they are not inherited into subclasses. The Lint API check needed some special handling of constructors to avoid this, since it was looking up inherited constructors and treating them as accessible. In particular that meant it wouldn't flag new IOException(Throwable) as requiring API 9, since its superclass had a constructor which also took a Throwable (with API 1). Change-Id: I268752be506f12399ce4855d2cf7bec76012e4c2
* | Merge "35054: lint reports resources as unused when used in plurals"Tor Norbye2012-07-171-1/+4
|\ \ | |/ |/|
| * 35054: lint reports resources as unused when used in pluralsTor Norbye2012-07-171-1/+4
| | | | | | | | Change-Id: Id437ef30e1488c96a46ccea45459694fd23db582
* | Merge "Detect incorrect state lists"Tor Norbye2012-07-171-11/+43
|\ \
| * | Detect incorrect state listsTor Norbye2012-07-171-11/+43
| |/ | | | | | | | | | | | | | | | | | | | | Lint already had a check for <selector> lists where it detects the case where you have an empty child not in the last position; this will match everything, and hide all subsequent states. This changeset generalizes this check: It makes sure that no state is fully matched by a previous state. Change-Id: I43b80beb531e68008d82f6c620739ca179d0f8f8
* | Change field getter threshold from API 8 to API 9Tor Norbye2012-07-161-5/+5
|/ | | | | | | The Dalvik optimization to automatically inline getters was introduced in Gingerbread, not Froyo. Change-Id: If14288aa398206d4eebfa57ccc7ddfabc6dde83d
* Add code completion and API checks for theme references (?attr)Tor Norbye2012-07-161-15/+24
| | | | | | | | | | | | | This checkin improves the handling of ?attr and ?android:attr theme references, such that (1) The API check considers theme references, and for example flags usage of ?android:attr/dividerHorizontal if your minSdkVersion is lower than 11 (2) Adds theme reference completion to the XML code completion. Change-Id: I2049b828e413802ac81579294f515fb0a4faccdf
* Make API check also look at <view> tagsTor Norbye2012-07-161-0/+9
| | | | Change-Id: I3d1e4e75aef44886185521fca57bc54b0b1e7cc0
* Only report field getter issues when targeting pre-Froyo targetsTor Norbye2012-07-161-1/+10
| | | | Change-Id: Ibc8756c2580a9e263b63b3507224acdf09f264ed
* Improvements to bytecode-to-source offset computationTor Norbye2012-07-165-17/+29
| | | | | | | | This changeset improves the way lint searches for the correct source offsets (and line numbers) for symbols found in .class files. Among other improvements this also fixes issue 34686. Change-Id: I7a2f40f0d930a4786dc69a7f0e0bbf5367a30ad4
* Merge "Add lint check for usages of dp instead of sp for textSizes"Tor Norbye2012-07-022-8/+43
|\
| * Add lint check for usages of dp instead of sp for textSizesTor Norbye2012-07-022-8/+43
| | | | | | | | Change-Id: I9cc1899491b49dbc9e62287dd23efd0efa128fce
* | Merge "- Fixed a bug in the lint check for unprotected broadcast receivers ↵Tor Norbye2012-07-021-1/+18
|\ \ | | | | | | | | | to ignore unprotected receivers for default Android actions."
| * | - Fixed a bug in the lint check for unprotected broadcast receivers to ↵Sebastian Porst2012-07-021-1/+18
| |/ | | | | | | | | | | ignore unprotected receivers for default Android actions. Change-Id: I4c5c72e25d299fbfb9b13140aae9b14650166313
generated by cgit v1.1 at 2025-08-18 03:36:41 +0000