diff options
Diffstat (limited to 'libbacktrace')
-rw-r--r-- | libbacktrace/Backtrace.cpp | 52 | ||||
-rw-r--r-- | libbacktrace/Backtrace.h | 10 | ||||
-rw-r--r-- | libbacktrace/BacktraceThread.cpp | 5 | ||||
-rw-r--r-- | libbacktrace/BacktraceThread.h | 3 | ||||
-rw-r--r-- | libbacktrace/Corkscrew.cpp | 12 | ||||
-rw-r--r-- | libbacktrace/UnwindCurrent.cpp | 8 | ||||
-rw-r--r-- | libbacktrace/UnwindPtrace.cpp | 4 | ||||
-rw-r--r-- | libbacktrace/backtrace_test.cpp | 31 |
8 files changed, 73 insertions, 52 deletions
diff --git a/libbacktrace/Backtrace.cpp b/libbacktrace/Backtrace.cpp index b22d301..a7568e0 100644 --- a/libbacktrace/Backtrace.cpp +++ b/libbacktrace/Backtrace.cpp @@ -42,11 +42,18 @@ backtrace_t* BacktraceImpl::GetBacktraceData() { //------------------------------------------------------------------------- // Backtrace functions. //------------------------------------------------------------------------- -Backtrace::Backtrace(BacktraceImpl* impl) : impl_(impl), map_info_(NULL) { +Backtrace::Backtrace(BacktraceImpl* impl, pid_t pid, backtrace_map_info_t* map_info) + : impl_(impl), map_info_(map_info), map_info_requires_delete_(false) { impl_->SetParent(this); backtrace_.num_frames = 0; - backtrace_.pid = -1; + backtrace_.pid = pid; backtrace_.tid = -1; + + if (map_info_ == NULL) { + // Create the map and manage it internally. + map_info_ = backtrace_create_map_info_list(pid); + map_info_requires_delete_ = true; + } } Backtrace::~Backtrace() { @@ -57,7 +64,7 @@ Backtrace::~Backtrace() { } } - if (map_info_) { + if (map_info_ && map_info_requires_delete_) { backtrace_destroy_map_info_list(map_info_); map_info_ = NULL; } @@ -151,8 +158,8 @@ std::string Backtrace::FormatFrameData(size_t frame_num) { //------------------------------------------------------------------------- // BacktraceCurrent functions. //------------------------------------------------------------------------- -BacktraceCurrent::BacktraceCurrent(BacktraceImpl* impl) : Backtrace(impl) { - map_info_ = backtrace_create_map_info_list(-1); +BacktraceCurrent::BacktraceCurrent( + BacktraceImpl* impl, backtrace_map_info_t *map_info) : Backtrace(impl, getpid(), map_info) { backtrace_.pid = getpid(); } @@ -179,11 +186,9 @@ bool BacktraceCurrent::ReadWord(uintptr_t ptr, uint32_t* out_value) { //------------------------------------------------------------------------- // BacktracePtrace functions. //------------------------------------------------------------------------- -BacktracePtrace::BacktracePtrace(BacktraceImpl* impl, pid_t pid, pid_t tid) - : Backtrace(impl) { - map_info_ = backtrace_create_map_info_list(tid); - - backtrace_.pid = pid; +BacktracePtrace::BacktracePtrace( + BacktraceImpl* impl, pid_t pid, pid_t tid, backtrace_map_info_t* map_info) + : Backtrace(impl, pid, map_info) { backtrace_.tid = tid; } @@ -212,26 +217,27 @@ bool BacktracePtrace::ReadWord(uintptr_t ptr, uint32_t* out_value) { #endif } -Backtrace* Backtrace::Create(pid_t pid, pid_t tid) { +Backtrace* Backtrace::Create(pid_t pid, pid_t tid, backtrace_map_info_t* map_info) { if (pid == BACKTRACE_CURRENT_PROCESS || pid == getpid()) { - if (tid == BACKTRACE_NO_TID || tid == gettid()) { - return CreateCurrentObj(); + if (tid == BACKTRACE_CURRENT_THREAD || tid == gettid()) { + return CreateCurrentObj(map_info); } else { - return CreateThreadObj(tid); + return CreateThreadObj(tid, map_info); } - } else if (tid == BACKTRACE_NO_TID) { - return CreatePtraceObj(pid, pid); + } else if (tid == BACKTRACE_CURRENT_THREAD) { + return CreatePtraceObj(pid, pid, map_info); } else { - return CreatePtraceObj(pid, tid); + return CreatePtraceObj(pid, tid, map_info); } } //------------------------------------------------------------------------- // Common interface functions. //------------------------------------------------------------------------- -bool backtrace_create_context( - backtrace_context_t* context, pid_t pid, pid_t tid, size_t num_ignore_frames) { - Backtrace* backtrace = Backtrace::Create(pid, tid); +bool backtrace_create_context_with_map( + backtrace_context_t* context, pid_t pid, pid_t tid, size_t num_ignore_frames, + backtrace_map_info_t* map_info) { + Backtrace* backtrace = Backtrace::Create(pid, tid, map_info); if (!backtrace) { return false; } @@ -245,6 +251,12 @@ bool backtrace_create_context( return true; } +bool backtrace_create_context( + backtrace_context_t* context, pid_t pid, pid_t tid, size_t num_ignore_frames) { + return backtrace_create_context_with_map(context, pid, tid, num_ignore_frames, NULL); +} + + void backtrace_destroy_context(backtrace_context_t* context) { if (context->data) { Backtrace* backtrace = reinterpret_cast<Backtrace*>(context->data); diff --git a/libbacktrace/Backtrace.h b/libbacktrace/Backtrace.h index 00f0a10..d741ef1 100644 --- a/libbacktrace/Backtrace.h +++ b/libbacktrace/Backtrace.h @@ -45,7 +45,7 @@ protected: class BacktraceCurrent : public Backtrace { public: - BacktraceCurrent(BacktraceImpl* impl); + BacktraceCurrent(BacktraceImpl* impl, backtrace_map_info_t* map_info); virtual ~BacktraceCurrent(); bool ReadWord(uintptr_t ptr, uint32_t* out_value); @@ -53,14 +53,14 @@ public: class BacktracePtrace : public Backtrace { public: - BacktracePtrace(BacktraceImpl* impl, pid_t pid, pid_t tid); + BacktracePtrace(BacktraceImpl* impl, pid_t pid, pid_t tid, backtrace_map_info_t* map_info); virtual ~BacktracePtrace(); bool ReadWord(uintptr_t ptr, uint32_t* out_value); }; -Backtrace* CreateCurrentObj(); -Backtrace* CreatePtraceObj(pid_t pid, pid_t tid); -Backtrace* CreateThreadObj(pid_t tid); +Backtrace* CreateCurrentObj(backtrace_map_info_t* map_info); +Backtrace* CreatePtraceObj(pid_t pid, pid_t tid, backtrace_map_info_t* map_info); +Backtrace* CreateThreadObj(pid_t tid, backtrace_map_info_t* map_info); #endif // _LIBBACKTRACE_BACKTRACE_H diff --git a/libbacktrace/BacktraceThread.cpp b/libbacktrace/BacktraceThread.cpp index 8e664c4..70616b0 100644 --- a/libbacktrace/BacktraceThread.cpp +++ b/libbacktrace/BacktraceThread.cpp @@ -114,8 +114,9 @@ static void SignalHandler(int n __attribute__((unused)), siginfo_t* siginfo, } BacktraceThread::BacktraceThread( - BacktraceImpl* impl, BacktraceThreadInterface* thread_intf, pid_t tid) - : BacktraceCurrent(impl), thread_intf_(thread_intf) { + BacktraceImpl* impl, BacktraceThreadInterface* thread_intf, pid_t tid, + backtrace_map_info_t* map_info) + : BacktraceCurrent(impl, map_info), thread_intf_(thread_intf) { backtrace_.tid = tid; } diff --git a/libbacktrace/BacktraceThread.h b/libbacktrace/BacktraceThread.h index 8ed1122..bcb56c9 100644 --- a/libbacktrace/BacktraceThread.h +++ b/libbacktrace/BacktraceThread.h @@ -71,7 +71,8 @@ public: // the compiler to catch if an implementation does not properly // subclass both. BacktraceThread( - BacktraceImpl* impl, BacktraceThreadInterface* thread_intf, pid_t tid); + BacktraceImpl* impl, BacktraceThreadInterface* thread_intf, pid_t tid, + backtrace_map_info_t* map_info); virtual ~BacktraceThread(); virtual bool Unwind(size_t num_ignore_frames); diff --git a/libbacktrace/Corkscrew.cpp b/libbacktrace/Corkscrew.cpp index 2be5930..eae13c6 100644 --- a/libbacktrace/Corkscrew.cpp +++ b/libbacktrace/Corkscrew.cpp @@ -204,15 +204,15 @@ std::string CorkscrewPtrace::GetFunctionNameRaw(uintptr_t pc, uintptr_t* offset) //------------------------------------------------------------------------- // C++ object creation functions. //------------------------------------------------------------------------- -Backtrace* CreateCurrentObj() { - return new BacktraceCurrent(new CorkscrewCurrent()); +Backtrace* CreateCurrentObj(backtrace_map_info_t* map_info) { + return new BacktraceCurrent(new CorkscrewCurrent(), map_info); } -Backtrace* CreatePtraceObj(pid_t pid, pid_t tid) { - return new BacktracePtrace(new CorkscrewPtrace(), pid, tid); +Backtrace* CreatePtraceObj(pid_t pid, pid_t tid, backtrace_map_info_t* map_info) { + return new BacktracePtrace(new CorkscrewPtrace(), pid, tid, map_info); } -Backtrace* CreateThreadObj(pid_t tid) { +Backtrace* CreateThreadObj(pid_t tid, backtrace_map_info_t* map_info) { CorkscrewThread* thread_obj = new CorkscrewThread(); - return new BacktraceThread(thread_obj, thread_obj, tid); + return new BacktraceThread(thread_obj, thread_obj, tid, map_info); } diff --git a/libbacktrace/UnwindCurrent.cpp b/libbacktrace/UnwindCurrent.cpp index 6c0cad6..94a82fe 100644 --- a/libbacktrace/UnwindCurrent.cpp +++ b/libbacktrace/UnwindCurrent.cpp @@ -194,11 +194,11 @@ void UnwindThread::ThreadUnwind( //------------------------------------------------------------------------- // C++ object creation function. //------------------------------------------------------------------------- -Backtrace* CreateCurrentObj() { - return new BacktraceCurrent(new UnwindCurrent()); +Backtrace* CreateCurrentObj(backtrace_map_info_t* map_info) { + return new BacktraceCurrent(new UnwindCurrent(), map_info); } -Backtrace* CreateThreadObj(pid_t tid) { +Backtrace* CreateThreadObj(pid_t tid, backtrace_map_info_t* map_info) { UnwindThread* thread_obj = new UnwindThread(); - return new BacktraceThread(thread_obj, thread_obj, tid); + return new BacktraceThread(thread_obj, thread_obj, tid, map_info); } diff --git a/libbacktrace/UnwindPtrace.cpp b/libbacktrace/UnwindPtrace.cpp index a734a24..7a9bbdd 100644 --- a/libbacktrace/UnwindPtrace.cpp +++ b/libbacktrace/UnwindPtrace.cpp @@ -131,6 +131,6 @@ std::string UnwindPtrace::GetFunctionNameRaw(uintptr_t pc, uintptr_t* offset) { //------------------------------------------------------------------------- // C++ object creation function. //------------------------------------------------------------------------- -Backtrace* CreatePtraceObj(pid_t pid, pid_t tid) { - return new BacktracePtrace(new UnwindPtrace(), pid, tid); +Backtrace* CreatePtraceObj(pid_t pid, pid_t tid, backtrace_map_info_t* map_info) { + return new BacktracePtrace(new UnwindPtrace(), pid, tid, map_info); } diff --git a/libbacktrace/backtrace_test.cpp b/libbacktrace/backtrace_test.cpp index 2603e1f..b894446 100644 --- a/libbacktrace/backtrace_test.cpp +++ b/libbacktrace/backtrace_test.cpp @@ -143,7 +143,8 @@ void VerifyLevelDump(const backtrace_t* backtrace) { void VerifyLevelBacktrace(void*) { backtrace_context_t context; - ASSERT_TRUE(backtrace_create_context(&context, BACKTRACE_CURRENT_PROCESS, BACKTRACE_NO_TID, 0)); + ASSERT_TRUE(backtrace_create_context(&context, BACKTRACE_CURRENT_PROCESS, + BACKTRACE_CURRENT_THREAD, 0)); VerifyLevelDump(context.backtrace); @@ -165,7 +166,8 @@ void VerifyMaxDump(const backtrace_t* backtrace) { void VerifyMaxBacktrace(void*) { backtrace_context_t context; - ASSERT_TRUE(backtrace_create_context(&context, BACKTRACE_CURRENT_PROCESS, BACKTRACE_NO_TID, 0)); + ASSERT_TRUE(backtrace_create_context(&context, BACKTRACE_CURRENT_PROCESS, + BACKTRACE_CURRENT_THREAD, 0)); VerifyMaxDump(context.backtrace); @@ -232,15 +234,18 @@ void VerifyIgnoreFrames( void VerifyLevelIgnoreFrames(void*) { backtrace_context_t all; - ASSERT_TRUE(backtrace_create_context(&all, BACKTRACE_CURRENT_PROCESS, BACKTRACE_NO_TID, 0)); + ASSERT_TRUE(backtrace_create_context(&all, BACKTRACE_CURRENT_PROCESS, + BACKTRACE_CURRENT_THREAD, 0)); ASSERT_TRUE(all.backtrace != NULL); backtrace_context_t ign1; - ASSERT_TRUE(backtrace_create_context(&ign1, BACKTRACE_CURRENT_PROCESS, BACKTRACE_NO_TID, 1)); + ASSERT_TRUE(backtrace_create_context(&ign1, BACKTRACE_CURRENT_PROCESS, + BACKTRACE_CURRENT_THREAD, 1)); ASSERT_TRUE(ign1.backtrace != NULL); backtrace_context_t ign2; - ASSERT_TRUE(backtrace_create_context(&ign2, BACKTRACE_CURRENT_PROCESS, BACKTRACE_NO_TID, 2)); + ASSERT_TRUE(backtrace_create_context(&ign2, BACKTRACE_CURRENT_PROCESS, + BACKTRACE_CURRENT_THREAD, 2)); ASSERT_TRUE(ign2.backtrace != NULL); VerifyIgnoreFrames(all.backtrace, ign1.backtrace, ign2.backtrace, @@ -296,7 +301,7 @@ TEST(libbacktrace, ptrace_trace) { ASSERT_NE(test_level_one(1, 2, 3, 4, NULL, NULL), 0); exit(1); } - VerifyProcTest(pid, BACKTRACE_NO_TID, ReadyLevelBacktrace, VerifyLevelDump); + VerifyProcTest(pid, BACKTRACE_CURRENT_THREAD, ReadyLevelBacktrace, VerifyLevelDump); kill(pid, SIGKILL); int status; @@ -309,7 +314,7 @@ TEST(libbacktrace, ptrace_max_trace) { ASSERT_NE(test_recursive_call(MAX_BACKTRACE_FRAMES+10, NULL, NULL), 0); exit(1); } - VerifyProcTest(pid, BACKTRACE_NO_TID, ReadyMaxBacktrace, VerifyMaxDump); + VerifyProcTest(pid, BACKTRACE_CURRENT_THREAD, ReadyMaxBacktrace, VerifyMaxDump); kill(pid, SIGKILL); int status; @@ -320,11 +325,11 @@ void VerifyProcessIgnoreFrames(const backtrace_t* bt_all) { pid_t pid = bt_all->pid; backtrace_context_t ign1; - ASSERT_TRUE(backtrace_create_context(&ign1, pid, BACKTRACE_NO_TID, 1)); + ASSERT_TRUE(backtrace_create_context(&ign1, pid, BACKTRACE_CURRENT_THREAD, 1)); ASSERT_TRUE(ign1.backtrace != NULL); backtrace_context_t ign2; - ASSERT_TRUE(backtrace_create_context(&ign2, pid, BACKTRACE_NO_TID, 2)); + ASSERT_TRUE(backtrace_create_context(&ign2, pid, BACKTRACE_CURRENT_THREAD, 2)); ASSERT_TRUE(ign2.backtrace != NULL); VerifyIgnoreFrames(bt_all, ign1.backtrace, ign2.backtrace, NULL); @@ -339,7 +344,7 @@ TEST(libbacktrace, ptrace_ignore_frames) { ASSERT_NE(test_level_one(1, 2, 3, 4, NULL, NULL), 0); exit(1); } - VerifyProcTest(pid, BACKTRACE_NO_TID, ReadyLevelBacktrace, VerifyProcessIgnoreFrames); + VerifyProcTest(pid, BACKTRACE_CURRENT_THREAD, ReadyLevelBacktrace, VerifyProcessIgnoreFrames); kill(pid, SIGKILL); int status; @@ -614,10 +619,12 @@ TEST(libbacktrace, thread_multiple_dump) { TEST(libbacktrace, format_test) { backtrace_context_t context; - ASSERT_TRUE(backtrace_create_context(&context, BACKTRACE_CURRENT_PROCESS, BACKTRACE_NO_TID, 0)); + ASSERT_TRUE(backtrace_create_context(&context, BACKTRACE_CURRENT_PROCESS, + BACKTRACE_CURRENT_THREAD, 0)); ASSERT_TRUE(context.backtrace != NULL); - backtrace_frame_data_t* frame = const_cast<backtrace_frame_data_t*>(&context.backtrace->frames[1]); + backtrace_frame_data_t* frame = + const_cast<backtrace_frame_data_t*>(&context.backtrace->frames[1]); backtrace_frame_data_t save_frame = *frame; memset(frame, 0, sizeof(backtrace_frame_data_t)); |