summaryrefslogtreecommitdiffstats
path: root/adb/adb.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Add WriteFdFmt and clean up more code.Elliott Hughes2015-05-011-4/+2
| | | | | | | | Also say *which* device wasn't found. Bug: http://b/20666660 Change-Id: I50e234ad89e39ae0a8995083c0b642c61275c5a3 (cherry picked from commit ab52c181fa4c1c9891644635dc5653cda5b90e2b)
* More adb buffer fixes.Elliott Hughes2015-05-011-90/+33
| | | | | | | | | | | | | | This patch factors out a lot of the basic protocol code: sending OKAY, sending FAIL, and sending a length-prefixed string. ADB_TRACE has been non-optional for a long time, so let's just remove the #ifs. Also actually build the device tracker test tool (and remove its duplicate). Bug: http://b/20666660 Change-Id: I6c7d59f18707bdc62ca69dea45547617f9f31fc6 (cherry picked from commit e67f1f87d9b1188ec8617035db7006c37ee7b21e)
* Add missing 'else' to fix all devices showing up as "host".Elliott Hughes2015-04-291-2/+3
| | | | | | Bug: http://b/20705355 Change-Id: I4f7830278f0c2bc87d95d148d85455b8da894645 (cherry picked from commit 3ce9575af76fa6dc110506080434303b9459abf4)
* Remove strtok from adb.Elliott Hughes2015-04-281-59/+36
| | | | | | | | Also fix android::base::Split to behave like Java, Python, and google3. (cherry picked from commit 8d5fa6da44d56511b3e173bc463cbc65ff221b4a) Change-Id: I9388ae37ee8dd4a4a6c2a9a19f068b70d9a78353
* Always explain why bind(2) failed.Elliott Hughes2015-04-201-17/+16
| | | | | | | This has confused several people lately. Bug: http://b/20219978 Change-Id: I2537ceb83bff0b3166c230c728d4389a983db858
* Show $ADB_VENDOR_KEYS if authentication fails.Elliott Hughes2015-04-161-8/+8
| | | | | | | | | Incorrectly set $ADB_VENDOR_KEYS is the most likely cause of failed adb connections. Make it easier to debug such problems by including the value in use in the error message. Bug: 20165551 Change-Id: I64c1d98ae6d3fb40eea9e1f0ddcfcf4f2d9d7318
* Additional cleanup of start_device_log.Dan Albert2015-03-201-8/+5
| | | | | | | | | | | | | | | | | Addresses nnk's post commit review comments on https://android-review.googlesource.com/#/c/139381/ Remove unneeded code for creating /data/adb. Add an O_CLOEXEC. Move the closing of stdin out to main(). Append the pid of the current process to the log file to avoid clobbering the log if the process crashes and restarts within the same second. Change-Id: Ide0be86b4b33256486634c29ba02efaf10cf913d
* Use text based trace masks for adbd.Dan Albert2015-03-191-23/+83
| | | | | | | | | Previously the adbd trace mask had to be set as raw hex rather than with the colon separated list. We all have better things to do than memorize bitmasks, so make adbd use the same trace mask setting code as adb. Change-Id: I0bf0ab61c070d06d1cc2acf1ed90b2b77ccd261b
* File header cleanup.Dan Albert2015-03-191-3/+4
| | | | | | | | | * sysdeps.h should always be included first. * TRACE_TAG needs to be defined before anything is included. * Some files were missing copyright headers. * Save precious bytes on my SSD by removing useless whitespace. Change-Id: I88980e6e00b5be1093806cf286740d9e4a033b94
* Move adb to C++.Dan Albert2015-03-091-0/+955
I keep trying to clean things up and needing std::strings. Might as well just do this now. usb_linux_client.c is going to stay as C because GCC isn't smart enough to deal with the designated initializers it uses (though for some reason it is in C mode). The Darwin files are staying as C because I don't have a way to test that they build. The Windows files are staying as C because while I can actually build for them, it's slow and painful. Change-Id: I75367d29205a9049d34460032b3bb36384f43941