From 611f5b4b938f2ffcf2a2e71a847e4fd12587ca4b Mon Sep 17 00:00:00 2001 From: Rom Lemarchand Date: Mon, 14 Jan 2013 14:11:01 -0800 Subject: logwrap: fix off by 1 argument error Fix off by 1 argument parsing error in liblogwrap. Change-Id: I79832ae338a71c445f9f616d780c577826874386 --- logwrapper/logwrap.c | 4 ++-- logwrapper/logwrapper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/logwrapper/logwrap.c b/logwrapper/logwrap.c index 9cd3fe4..09f8b81 100644 --- a/logwrapper/logwrap.c +++ b/logwrapper/logwrap.c @@ -227,7 +227,7 @@ int logwrap(int argc, char* argv[], int *status) { dup2(child_ptty, 2); close(child_ptty); - child(argc - 1, &argv[1]); + child(argc, argv); fatal("This should never happen\n"); return -1; } else { @@ -268,7 +268,7 @@ int logwrap(int argc, char* argv[], int *status) { setgid(AID_LOG); setuid(AID_LOG); - rc = parent(argv[1], parent_ptty, sockets[1], pid, status); + rc = parent(argv[0], parent_ptty, sockets[1], pid, status); } close(sockets[0]); diff --git a/logwrapper/logwrapper.c b/logwrapper/logwrapper.c index 4f1bff9..e647b4d 100644 --- a/logwrapper/logwrapper.c +++ b/logwrapper/logwrapper.c @@ -59,7 +59,7 @@ int main(int argc, char* argv[]) { usage(); } - rc = logwrap(argc, argv, &status); + rc = logwrap(argc - 1, &argv[1], &status); if (!rc) { if (WIFEXITED(status)) rc = WEXITSTATUS(status); -- cgit v1.1