From 50b3995d027b53f24bbba099b3b6884d5845b614 Mon Sep 17 00:00:00 2001 From: Bruce Beare Date: Thu, 15 Jul 2010 08:52:01 -0700 Subject: Check fastboot oem command line length Change-Id: I301af09c4ec460c9049b75cc7f4d2c50cfe00ceb Signed-off-by: Bruce Beare --- fastboot/engine.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'fastboot/engine.c') diff --git a/fastboot/engine.c b/fastboot/engine.c index 6d62c6e..dc74417 100644 --- a/fastboot/engine.c +++ b/fastboot/engine.c @@ -97,14 +97,20 @@ static Action *queue_action(unsigned op, const char *fmt, ...) { Action *a; va_list ap; + size_t cmdsize; a = calloc(1, sizeof(Action)); if (a == 0) die("out of memory"); va_start(ap, fmt); - vsprintf(a->cmd, fmt, ap); + cmdsize = vsnprintf(a->cmd, sizeof(a->cmd), fmt, ap); va_end(ap); + if (cmdsize >= sizeof(a->cmd)) { + free(a); + die("Command length (%d) exceeds maximum size (%d)", cmdsize, sizeof(a->cmd)); + } + if (action_last) { action_last->next = a; } else { -- cgit v1.1