From 18a574f715b767ee8a2f02903c883d571b42409f Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Fri, 29 May 2015 17:40:25 -0700 Subject: Work around spurious epoll notifications. Sometimes it seems like we can get into a situation where we are unable to remove an fd from the epoll set but it keeps sending us events anyhow. Defensively rebuild the epoll set in this case to prevent us from spinning forever. Bug: 21271428 Change-Id: I5607e565f2e12460d7113a1f62a70d38d334e271 --- libutils/Looper.cpp | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'libutils') diff --git a/libutils/Looper.cpp b/libutils/Looper.cpp index e69784d..5b0ff3a 100644 --- a/libutils/Looper.cpp +++ b/libutils/Looper.cpp @@ -567,7 +567,12 @@ int Looper::removeFd(int fd, int seq) { #endif scheduleEpollRebuildLocked(); } else { + // Some other error occurred. This is really weird because it means + // our list of callbacks got out of sync with the epoll set somehow. + // We defensively rebuild the epoll set to avoid getting spurious + // notifications with nowhere to go. ALOGE("Error removing epoll events for fd %d, errno=%d", fd, errno); + scheduleEpollRebuildLocked(); return -1; } } -- cgit v1.1