From 27e5721860142b1b20081b535c55e7917366385f Mon Sep 17 00:00:00 2001 From: Jeff Brown Date: Thu, 26 Feb 2015 14:16:30 -0800 Subject: Rename Looper::isIdling() to isPolling() to resolve confusion. The loop isn't technically idle at this time, it's just checking whether any file descriptors have pending events. However it's still a good signal as to whether the loop is alive. Bug: 19532373 Change-Id: I555c473e70ffd8a56e1b10aa60026eb674a16de9 --- libutils/Looper.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'libutils') diff --git a/libutils/Looper.cpp b/libutils/Looper.cpp index 9a2dd6c..9ba1797 100644 --- a/libutils/Looper.cpp +++ b/libutils/Looper.cpp @@ -84,7 +84,7 @@ Looper::Looper(bool allowNonCallbacks) : LOG_ALWAYS_FATAL_IF(result != 0, "Could not make wake write pipe non-blocking. errno=%d", errno); - mIdling = false; + mPolling = false; // Allocate the epoll instance and register the wake pipe. mEpollFd = epoll_create(EPOLL_SIZE_HINT); @@ -217,13 +217,13 @@ int Looper::pollInner(int timeoutMillis) { mResponseIndex = 0; // We are about to idle. - mIdling = true; + mPolling = true; struct epoll_event eventItems[EPOLL_MAX_EVENTS]; int eventCount = epoll_wait(mEpollFd, eventItems, EPOLL_MAX_EVENTS, timeoutMillis); // No longer idling. - mIdling = false; + mPolling = false; // Acquire lock. mLock.lock(); @@ -566,8 +566,8 @@ void Looper::removeMessages(const sp& handler, int what) { } // release lock } -bool Looper::isIdling() const { - return mIdling; +bool Looper::isPolling() const { + return mPolling; } } // namespace android -- cgit v1.1