aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNick Kralevich <nnk@google.com>2010-06-24 16:11:17 -0700
committerNick Kralevich <nnk@google.com>2010-06-24 16:11:17 -0700
commit21b97ed5693d039e8b9dea57a160d3307f412682 (patch)
tree7257b5526e7f4ae33c2dea69ad86c4688e13bdda
parentdd6a0412b5d4623f63e46120c648342824029c18 (diff)
downloadbootable_recovery-21b97ed5693d039e8b9dea57a160d3307f412682.zip
bootable_recovery-21b97ed5693d039e8b9dea57a160d3307f412682.tar.gz
bootable_recovery-21b97ed5693d039e8b9dea57a160d3307f412682.tar.bz2
Add __attribute__((format(printf, a, b))) to printf like functions.
Fix potential string format bug. Change-Id: Ie05aac53b2c45a48bd68e340b76ccb21edfd28b7
-rw-r--r--common.h2
-rw-r--r--install.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/common.h b/common.h
index ff577c2..1182d77 100644
--- a/common.h
+++ b/common.h
@@ -31,7 +31,7 @@ void ui_clear_key_queue();
// Write a message to the on-screen log shown with Alt-L (also to stderr).
// The screen is small, and users may need to report these messages to support,
// so keep the output short and not too cryptic.
-void ui_print(const char *fmt, ...);
+void ui_print(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
// Display some header text followed by a menu of items, which appears
// at the top of the screen (in place of any scrolling ui_print()
diff --git a/install.c b/install.c
index 37a4f07..35ba6ca 100644
--- a/install.c
+++ b/install.c
@@ -136,7 +136,7 @@ try_update_binary(const char *path, ZipArchive *zip) {
} else if (strcmp(command, "ui_print") == 0) {
char* str = strtok(NULL, "\n");
if (str) {
- ui_print(str);
+ ui_print("%s", str);
} else {
ui_print("\n");
}