diff options
author | Sami Tolvanen <samitolvanen@google.com> | 2015-06-10 21:50:03 +0000 |
---|---|---|
committer | Android (Google) Code Review <android-gerrit@google.com> | 2015-06-10 21:50:03 +0000 |
commit | d7c9bf41daa865ca016dee12a68282ba457c31fb (patch) | |
tree | f445696802ff01a687af0ce8efc34e06dc47a927 | |
parent | 0005f89c31dfc2ca9053512900571620a0eba842 (diff) | |
parent | b65f0272c860771f2105668accd175be1ed95ae9 (diff) | |
download | bootable_recovery-d7c9bf41daa865ca016dee12a68282ba457c31fb.zip bootable_recovery-d7c9bf41daa865ca016dee12a68282ba457c31fb.tar.gz bootable_recovery-d7c9bf41daa865ca016dee12a68282ba457c31fb.tar.bz2 |
Merge "Zero blocks before BLKDISCARD" into mnc-dev
-rw-r--r-- | updater/blockimg.c | 18 |
1 files changed, 17 insertions, 1 deletions
diff --git a/updater/blockimg.c b/updater/blockimg.c index 7b8721d..e184800 100644 --- a/updater/blockimg.c +++ b/updater/blockimg.c @@ -1404,6 +1404,7 @@ pcdout: static int PerformCommandErase(CommandParameters* params) { char* range = NULL; int i; + int j; int rc = -1; RangeSet* tgt = NULL; struct stat st; @@ -1430,7 +1431,7 @@ static int PerformCommandErase(CommandParameters* params) { range = strtok_r(NULL, " ", ¶ms->cpos); if (range == NULL) { - fprintf(stderr, "missing target blocks for zero\n"); + fprintf(stderr, "missing target blocks for erase\n"); goto pceout; } @@ -1439,7 +1440,22 @@ static int PerformCommandErase(CommandParameters* params) { if (params->canwrite) { fprintf(stderr, " erasing %d blocks\n", tgt->size); + allocate(BLOCKSIZE, ¶ms->buffer, ¶ms->bufsize); + memset(params->buffer, 0, BLOCKSIZE); + for (i = 0; i < tgt->count; ++i) { + // Always zero the blocks first to work around possibly flaky BLKDISCARD + // Bug: 20881595 + if (!check_lseek(params->fd, (off64_t) tgt->pos[i * 2] * BLOCKSIZE, SEEK_SET)) { + goto pceout; + } + + for (j = tgt->pos[i * 2]; j < tgt->pos[i * 2 + 1]; ++j) { + if (write_all(params->fd, params->buffer, BLOCKSIZE) == -1) { + goto pceout; + } + } + // offset in bytes blocks[0] = tgt->pos[i * 2] * (uint64_t) BLOCKSIZE; // length in bytes |