aboutsummaryrefslogtreecommitdiffstats
path: root/recovery.cpp
diff options
context:
space:
mode:
authorTao Bao <tbao@google.com>2015-09-10 13:33:58 -0700
committerSteve Kondik <steve@cyngn.com>2015-11-07 19:21:20 -0800
commitf17456d480d102e941c6dbd3eb29a2185c4c0811 (patch)
treed48f6a2d4f9f08bf1333930577680e72f9e34562 /recovery.cpp
parentb810ee75a15f0267236873e0c66a2279dee7c737 (diff)
downloadbootable_recovery-f17456d480d102e941c6dbd3eb29a2185c4c0811.zip
bootable_recovery-f17456d480d102e941c6dbd3eb29a2185c4c0811.tar.gz
bootable_recovery-f17456d480d102e941c6dbd3eb29a2185c4c0811.tar.bz2
recovery: Remove redirect_stdio() when calling ShowFile().
When calling ScreenRecoveryUI::ShowFile(), the only thing that gets inadequately logged is the progress bar. Replace the call to ScreenRecoveryUI::Print() with ScreenRecoveryUI::PrintOnScreenOnly() for the progress bar, so we can avoid calling redirect_stdio(). Change-Id: I4d7c5d5b39bebe0d5880a99d7a72cee4f0b8f325
Diffstat (limited to 'recovery.cpp')
-rw-r--r--recovery.cpp3
1 files changed, 0 insertions, 3 deletions
diff --git a/recovery.cpp b/recovery.cpp
index a43f321..1c7fd5d 100644
--- a/recovery.cpp
+++ b/recovery.cpp
@@ -745,10 +745,7 @@ static void choose_recovery_file(Device* device) {
int chosen_item = get_menu_selection(headers, entries, 1, 0, device);
if (strcmp(entries[chosen_item], "Back") == 0) break;
- // TODO: do we need to redirect? ShowFile could just avoid writing to stdio.
- redirect_stdio("/dev/null");
ui->ShowFile(entries[chosen_item]);
- redirect_stdio(TEMPORARY_LOG_FILE);
}
for (size_t i = 0; i < (sizeof(entries) / sizeof(*entries)); i++) {