aboutsummaryrefslogtreecommitdiffstats
path: root/updater
diff options
context:
space:
mode:
authorMichael Runge <mrunge@google.com>2014-10-24 23:17:43 +0000
committerAndroid Git Automerger <android-git-automerger@android.com>2014-10-24 23:17:43 +0000
commitfe8563f4f2a6efe1eb00bb41a5037c88917becfc (patch)
treeebda3154bb85bd2dcc8d4272526a6419ff16764c /updater
parent915d661ccc64f25a533919054f487a8e5943574d (diff)
parent5ddf4293df45a051c7900eeb62fb5ec4950b6cb6 (diff)
downloadbootable_recovery-fe8563f4f2a6efe1eb00bb41a5037c88917becfc.zip
bootable_recovery-fe8563f4f2a6efe1eb00bb41a5037c88917becfc.tar.gz
bootable_recovery-fe8563f4f2a6efe1eb00bb41a5037c88917becfc.tar.bz2
am 5ddf4293: Log mount/unmount errors to UI
* commit '5ddf4293df45a051c7900eeb62fb5ec4950b6cb6': Log mount/unmount errors to UI
Diffstat (limited to 'updater')
-rw-r--r--updater/install.c14
1 files changed, 9 insertions, 5 deletions
diff --git a/updater/install.c b/updater/install.c
index db2bd32..ff7de47 100644
--- a/updater/install.c
+++ b/updater/install.c
@@ -151,13 +151,13 @@ Value* MountFn(const char* name, State* state, int argc, Expr* argv[]) {
const MtdPartition* mtd;
mtd = mtd_find_partition_by_name(location);
if (mtd == NULL) {
- printf("%s: no mtd partition named \"%s\"",
+ uiPrintf(state, "%s: no mtd partition named \"%s\"",
name, location);
result = strdup("");
goto done;
}
if (mtd_mount_partition(mtd, mount_point, fs_type, 0 /* rw */) != 0) {
- printf("mtd mount of %s failed: %s\n",
+ uiPrintf(state, "mtd mount of %s failed: %s\n",
location, strerror(errno));
result = strdup("");
goto done;
@@ -167,7 +167,7 @@ Value* MountFn(const char* name, State* state, int argc, Expr* argv[]) {
if (mount(location, mount_point, fs_type,
MS_NOATIME | MS_NODEV | MS_NODIRATIME,
has_mount_options ? mount_options : "") < 0) {
- printf("%s: failed to mount %s at %s: %s\n",
+ uiPrintf(state, "%s: failed to mount %s at %s: %s\n",
name, location, mount_point, strerror(errno));
result = strdup("");
} else {
@@ -231,10 +231,14 @@ Value* UnmountFn(const char* name, State* state, int argc, Expr* argv[]) {
scan_mounted_volumes();
const MountedVolume* vol = find_mounted_volume_by_mount_point(mount_point);
if (vol == NULL) {
- printf("unmount of %s failed; no such volume\n", mount_point);
+ uiPrintf(state, "unmount of %s failed; no such volume\n", mount_point);
result = strdup("");
} else {
- unmount_mounted_volume(vol);
+ int ret = unmount_mounted_volume(vol);
+ if (ret != 0) {
+ uiPrintf(state, "unmount of %s failed (%d): %s\n",
+ mount_point, ret, strerror(errno));
+ }
result = mount_point;
}