summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBrian Carlstrom <bdc@google.com>2014-07-30 09:53:12 -0700
committerBrian Carlstrom <bdc@google.com>2014-08-06 17:47:40 -0700
commit56ef86df84ba7d8b26b663f49ae40f8c86b4b95b (patch)
tree18c9342bc883f0446970c590e0d5b56cbfcca292
parentc6b76767193322b086caad0d3968552e0229b28f (diff)
downloadbuild-56ef86df84ba7d8b26b663f49ae40f8c86b4b95b.zip
build-56ef86df84ba7d8b26b663f49ae40f8c86b4b95b.tar.gz
build-56ef86df84ba7d8b26b663f49ae40f8c86b4b95b.tar.bz2
resolved conflicts for merge of a8138028 to lmp-dev-plus-aosp
(cherry picked from commit 4a5a11e416425689d9f37a1963ae852051b451d2) Change-Id: Ic5c2297d50f2e59ca5b1eb0c3b81328d23a48253
-rwxr-xr-xtools/post_process_props.py12
1 files changed, 9 insertions, 3 deletions
diff --git a/tools/post_process_props.py b/tools/post_process_props.py
index e43ca59..030826d 100755
--- a/tools/post_process_props.py
+++ b/tools/post_process_props.py
@@ -19,9 +19,10 @@ import sys
# Usage: post_process_props.py file.prop [blacklist_key, ...]
# Blacklisted keys are removed from the property file, if present
-# See PROP_VALUE_MAX system_properties.h.
-# PROP_VALUE_MAX in system_properties.h includes the termination NUL,
-# so we decrease it by 1 here.
+# See PROP_NAME_MAX and PROP_VALUE_MAX system_properties.h.
+# The constants in system_properties.h includes the termination NUL,
+# so we decrease the values by 1 here.
+PROP_NAME_MAX = 31
PROP_VALUE_MAX = 91
# Put the modifications that you need to make into the /system/build.prop into this
@@ -59,6 +60,11 @@ def validate(prop):
"").startswith("eng")
for key, value in buildprops.iteritems():
# Check build properties' length.
+ if len(key) > PROP_NAME_MAX:
+ check_pass = False
+ sys.stderr.write("error: %s cannot exceed %d bytes: " %
+ (key, PROP_NAME_MAX))
+ sys.stderr.write("%s (%d)\n" % (key, len(key)))
if len(value) > PROP_VALUE_MAX:
# If dev build, show a warning message, otherwise fail the
# build with error message