diff options
| author | Dmitriy Ivanov <dimitry@google.com> | 2015-04-20 20:43:18 +0000 |
|---|---|---|
| committer | Android Git Automerger <android-git-automerger@android.com> | 2015-04-20 20:43:18 +0000 |
| commit | 6cb3732d82e6a2346c00219931d0f0a3c3257f44 (patch) | |
| tree | eb220bbd7d80d6ea9f1ba7ecf179b2724b879c84 | |
| parent | bdc47592dbf4b6258b947677f38b0ef95b6ea241 (diff) | |
| parent | baca453a7d23fb2cf8a38d8aad3addbfce362afc (diff) | |
| download | build-6cb3732d82e6a2346c00219931d0f0a3c3257f44.zip build-6cb3732d82e6a2346c00219931d0f0a3c3257f44.tar.gz build-6cb3732d82e6a2346c00219931d0f0a3c3257f44.tar.bz2 | |
am baca453a: am 5beb3387: Merge "Remove unsupported *_COMPRESS_MODULE_SYMBOLS"
* commit 'baca453a7d23fb2cf8a38d8aad3addbfce362afc':
Remove unsupported *_COMPRESS_MODULE_SYMBOLS
| -rw-r--r-- | core/clear_vars.mk | 1 | ||||
| -rw-r--r-- | core/config.mk | 3 | ||||
| -rw-r--r-- | core/dynamic_binary.mk | 29 | ||||
| -rw-r--r-- | core/product.mk | 1 |
4 files changed, 2 insertions, 32 deletions
diff --git a/core/clear_vars.mk b/core/clear_vars.mk index 9975fa1..21674fe 100644 --- a/core/clear_vars.mk +++ b/core/clear_vars.mk @@ -92,7 +92,6 @@ LOCAL_COPY_HEADERS_TO:= LOCAL_COPY_HEADERS:= LOCAL_FORCE_STATIC_EXECUTABLE:= LOCAL_ADDITIONAL_DEPENDENCIES:= -LOCAL_COMPRESS_MODULE_SYMBOLS:= LOCAL_STRIP_MODULE:= LOCAL_JNI_SHARED_LIBRARIES:= LOCAL_JNI_SHARED_LIBRARIES_ABI:= diff --git a/core/config.mk b/core/config.mk index 0b76b53..60ea592 100644 --- a/core/config.mk +++ b/core/config.mk @@ -131,9 +131,6 @@ COMMON_ANDROID_PACKAGE_SUFFIX := .apk # list of flags to turn specific warnings in to errors TARGET_ERROR_FLAGS := -Werror=return-type -Werror=non-virtual-dtor -Werror=address -Werror=sequence-point -# TODO: do symbol compression -TARGET_COMPRESS_MODULE_SYMBOLS := false - # ############################################################### # Include sub-configuration files # ############################################################### diff --git a/core/dynamic_binary.mk b/core/dynamic_binary.mk index cf06a3d..7a423db 100644 --- a/core/dynamic_binary.mk +++ b/core/dynamic_binary.mk @@ -39,30 +39,6 @@ include $(BUILD_SYSTEM)/binary.mk ################################### ########################################################### -## Compress -########################################################### -compress_input := $(linked_module) - -ifeq ($(strip $(LOCAL_COMPRESS_MODULE_SYMBOLS)),) - LOCAL_COMPRESS_MODULE_SYMBOLS := $(strip $(TARGET_COMPRESS_MODULE_SYMBOLS)) -endif - -ifeq ($(LOCAL_COMPRESS_MODULE_SYMBOLS),true) -$(error Symbol compression not yet supported.) -compress_output := $(intermediates)/COMPRESSED-$(my_built_module_stem) - -#TODO: write the real $(STRIPPER) rule. -#TODO: define a rule to build TARGET_SYMBOL_FILTER_FILE, and -# make it depend on ALL_ORIGINAL_DYNAMIC_BINARIES. -$(compress_output): $(compress_input) $(TARGET_SYMBOL_FILTER_FILE) | $(ACP) - @echo "target Compress Symbols: $(PRIVATE_MODULE) ($@)" - $(copy-file-to-target) -else -# Skip this step. -compress_output := $(compress_input) -endif - -########################################################### ## Store a copy with symbols for symbolic debugging ########################################################### ifeq ($(LOCAL_UNSTRIPPED_PATH),) @@ -70,7 +46,7 @@ my_unstripped_path := $(TARGET_OUT_UNSTRIPPED)/$(patsubst $(PRODUCT_OUT)/%,%,$(m else my_unstripped_path := $(LOCAL_UNSTRIPPED_PATH) endif -symbolic_input := $(compress_output) +symbolic_input := $(linked_module) symbolic_output := $(my_unstripped_path)/$(my_installed_module_stem) $(symbolic_output) : $(symbolic_input) | $(ACP) @echo "target Symbolic: $(PRIVATE_MODULE) ($@)" @@ -134,5 +110,4 @@ endif # my_strip_module $(cleantarget): PRIVATE_CLEAN_FILES += \ $(linked_module) \ - $(symbolic_output) \ - $(compress_output) + $(symbolic_output) diff --git a/core/product.mk b/core/product.mk index d3df582..46fad89 100644 --- a/core/product.mk +++ b/core/product.mk @@ -229,7 +229,6 @@ _product_stash_var_list := $(_product_var_list) \ TARGET_DEVICE_KERNEL_HEADERS \ TARGET_PRODUCT_KERNEL_HEADERS \ TARGET_BOOTLOADER_BOARD_NAME \ - TARGET_COMPRESS_MODULE_SYMBOLS \ TARGET_NO_BOOTLOADER \ TARGET_NO_KERNEL \ TARGET_NO_RECOVERY \ |