diff options
author | Ying Wang <wangying@google.com> | 2015-02-04 23:33:19 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2015-02-04 23:33:20 +0000 |
commit | d51b0fd3e4b3b39a36019bb1cd06fe29979f4ee8 (patch) | |
tree | 11867f3f2c80c977faefd49d78fdf1b86e82f3df | |
parent | 4c178ebcc0069b6f806de4df491bc9a7e1b9d78e (diff) | |
parent | 38df101343137c3a4c1954803a52a4ea35c7f42f (diff) | |
download | build-d51b0fd3e4b3b39a36019bb1cd06fe29979f4ee8.zip build-d51b0fd3e4b3b39a36019bb1cd06fe29979f4ee8.tar.gz build-d51b0fd3e4b3b39a36019bb1cd06fe29979f4ee8.tar.bz2 |
Merge "Fail even dev build when property value exceeds length limit."
-rwxr-xr-x | tools/post_process_props.py | 19 |
1 files changed, 4 insertions, 15 deletions
diff --git a/tools/post_process_props.py b/tools/post_process_props.py index 030826d..fa6106f 100755 --- a/tools/post_process_props.py +++ b/tools/post_process_props.py @@ -56,8 +56,6 @@ def validate(prop): """ check_pass = True buildprops = prop.to_dict() - dev_build = buildprops.get("ro.build.version.incremental", - "").startswith("eng") for key, value in buildprops.iteritems(): # Check build properties' length. if len(key) > PROP_NAME_MAX: @@ -66,19 +64,10 @@ def validate(prop): (key, PROP_NAME_MAX)) sys.stderr.write("%s (%d)\n" % (key, len(key))) if len(value) > PROP_VALUE_MAX: - # If dev build, show a warning message, otherwise fail the - # build with error message - if dev_build: - sys.stderr.write("warning: %s exceeds %d bytes: " % - (key, PROP_VALUE_MAX)) - sys.stderr.write("%s (%d)\n" % (value, len(value))) - sys.stderr.write("warning: This will cause the %s " % key) - sys.stderr.write("property return as empty at runtime\n") - else: - check_pass = False - sys.stderr.write("error: %s cannot exceed %d bytes: " % - (key, PROP_VALUE_MAX)) - sys.stderr.write("%s (%d)\n" % (value, len(value))) + check_pass = False + sys.stderr.write("error: %s cannot exceed %d bytes: " % + (key, PROP_VALUE_MAX)) + sys.stderr.write("%s (%d)\n" % (value, len(value))) return check_pass class PropFile: |