summaryrefslogtreecommitdiffstats
path: root/core
diff options
context:
space:
mode:
authorYing Wang <wangying@google.com>2014-11-19 18:53:18 +0000
committerGerrit Code Review <noreply-gerritcodereview@google.com>2014-11-19 18:53:19 +0000
commit471e60d6a89ada5a9ed322d200fbe14eb07764ff (patch)
treec6d5380ca732faeb3a70e61440fc47831b942e1a /core
parent9f7c5fef0e7c00d00c67242c2a360911b53374e0 (diff)
parent634f7992f0d38c52f4b94095de7e7676eb21c97a (diff)
downloadbuild-471e60d6a89ada5a9ed322d200fbe14eb07764ff.zip
build-471e60d6a89ada5a9ed322d200fbe14eb07764ff.tar.gz
build-471e60d6a89ada5a9ed322d200fbe14eb07764ff.tar.bz2
Merge "Use ALL_MODULES.$(m).INSTALLED in modules-for-tag-list"
Diffstat (limited to 'core')
-rw-r--r--core/base_rules.mk8
-rw-r--r--core/definitions.mk2
2 files changed, 1 insertions, 9 deletions
diff --git a/core/base_rules.mk b/core/base_rules.mk
index acbecc4..38f04f1 100644
--- a/core/base_rules.mk
+++ b/core/base_rules.mk
@@ -650,14 +650,6 @@ INSTALLABLE_FILES.$(LOCAL_INSTALLED_MODULE).MODULE := $(my_register_name)
# Keep track of all the tags we've seen.
ALL_MODULE_TAGS := $(sort $(ALL_MODULE_TAGS) $(my_module_tags))
-# Add this module to the tag list of each specified tag.
-# Don't use "+=". If the variable hasn't been set with ":=",
-# it will default to recursive expansion.
-$(foreach tag,$(my_module_tags),\
- $(eval ALL_MODULE_TAGS.$(tag) := \
- $(ALL_MODULE_TAGS.$(tag)) \
- $(LOCAL_INSTALLED_MODULE)))
-
# Add this module name to the tag list of each specified tag.
$(foreach tag,$(my_module_tags),\
$(eval ALL_MODULE_NAME_TAGS.$(tag) += $(my_register_name)))
diff --git a/core/definitions.mk b/core/definitions.mk
index a5374c4..0bbdb6d 100644
--- a/core/definitions.mk
+++ b/core/definitions.mk
@@ -684,7 +684,7 @@ endef
# any of those tags.
# $(1): tag list
define modules-for-tag-list
-$(sort $(foreach tag,$(1),$(ALL_MODULE_TAGS.$(tag))))
+$(sort $(foreach tag,$(1),$(foreach m,$(ALL_MODULE_NAME_TAGS.$(tag)),$(ALL_MODULES.$(m).INSTALLED))))
endef
# Same as modules-for-tag-list, but operates on