diff options
| author | Doug Zongker <dougz@android.com> | 2011-01-23 12:57:19 -0800 |
|---|---|---|
| committer | Doug Zongker <dougz@android.com> | 2011-01-23 12:57:19 -0800 |
| commit | e128cbda075ae28dc7965455b3c047bc841228fc (patch) | |
| tree | d43976baf0abee310ec037d93ee2358a00fb9b59 /tools/event_log_tags.py | |
| parent | 7838fa6e9c51ec686062e207f98ca409a9b480f2 (diff) | |
| download | build-e128cbda075ae28dc7965455b3c047bc841228fc.zip build-e128cbda075ae28dc7965455b3c047bc841228fc.tar.gz build-e128cbda075ae28dc7965455b3c047bc841228fc.tar.bz2 | |
check syntax of description field in logtags files
EventLog.java checks that the field descriptions are bracketed by
parens, so we should to in order to avoid a runtime error from a
logtag entry with bad syntax.
Bug: 3381309
Change-Id: I1d4cbb190da6b81ec0b1f1de9b5bc3f3394d7ec1
Diffstat (limited to 'tools/event_log_tags.py')
| -rw-r--r-- | tools/event_log_tags.py | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tools/event_log_tags.py b/tools/event_log_tags.py index 81e8b39..645839e 100644 --- a/tools/event_log_tags.py +++ b/tools/event_log_tags.py @@ -90,6 +90,14 @@ class TagFile(object): else: description = None + if description: + # EventLog.java checks that the description field is + # surrounded by parens, so we should too (to avoid a runtime + # crash from badly-formatted descriptions). + if not re.match(r"\(.*\)\s*$", description): + self.AddError("tag \"%s\" has unparseable description" % (tagname,)) + continue + self.tags.append(Tag(tag, tagname, description, self.filename, self.linenum)) except (IOError, OSError), e: |