diff options
author | Brian Carlstrom <bdc@google.com> | 2010-07-19 08:49:56 -0700 |
---|---|---|
committer | Android Git Automerger <android-git-automerger@android.com> | 2010-07-19 08:49:56 -0700 |
commit | 590f81b8a680254fd2ac9d8418380fc766811791 (patch) | |
tree | e62908e97c411a5fd29e79305cbcbfb3176ae828 | |
parent | 3af52d9f93fd383c8fefb118d1b255e1880315cb (diff) | |
parent | 5648c97be2c515bdafeff3d8a4b07ea0ddc3e357 (diff) | |
download | external_apache-http-590f81b8a680254fd2ac9d8418380fc766811791.zip external_apache-http-590f81b8a680254fd2ac9d8418380fc766811791.tar.gz external_apache-http-590f81b8a680254fd2ac9d8418380fc766811791.tar.bz2 |
am 5648c97b: Remove explicit SSLSocket.startHandshake
Merge commit '5648c97be2c515bdafeff3d8a4b07ea0ddc3e357' into dalvik-dev
* commit '5648c97be2c515bdafeff3d8a4b07ea0ddc3e357':
Remove explicit SSLSocket.startHandshake
-rw-r--r-- | src/org/apache/http/conn/ssl/AbstractVerifier.java | 37 |
1 files changed, 0 insertions, 37 deletions
diff --git a/src/org/apache/http/conn/ssl/AbstractVerifier.java b/src/org/apache/http/conn/ssl/AbstractVerifier.java index 5195e58..e409db9 100644 --- a/src/org/apache/http/conn/ssl/AbstractVerifier.java +++ b/src/org/apache/http/conn/ssl/AbstractVerifier.java @@ -89,44 +89,7 @@ public abstract class AbstractVerifier implements X509HostnameVerifier { throw new NullPointerException("host to verify is null"); } - ssl.startHandshake(); SSLSession session = ssl.getSession(); - if(session == null) { - // In our experience this only happens under IBM 1.4.x when - // spurious (unrelated) certificates show up in the server' - // chain. Hopefully this will unearth the real problem: - InputStream in = ssl.getInputStream(); - in.available(); - /* - If you're looking at the 2 lines of code above because - you're running into a problem, you probably have two - options: - - #1. Clean up the certificate chain that your server - is presenting (e.g. edit "/etc/apache2/server.crt" - or wherever it is your server's certificate chain - is defined). - - OR - - #2. Upgrade to an IBM 1.5.x or greater JVM, or switch - to a non-IBM JVM. - */ - - // If ssl.getInputStream().available() didn't cause an - // exception, maybe at least now the session is available? - session = ssl.getSession(); - if(session == null) { - // If it's still null, probably a startHandshake() will - // unearth the real problem. - ssl.startHandshake(); - - // Okay, if we still haven't managed to cause an exception, - // might as well go for the NPE. Or maybe we're okay now? - session = ssl.getSession(); - } - } - Certificate[] certs = session.getPeerCertificates(); X509Certificate x509 = (X509Certificate) certs[0]; verify(host, x509); |