diff options
Diffstat (limited to 'stack/sdp')
| -rwxr-xr-x[-rw-r--r--] | stack/sdp/sdp_api.c | 0 | ||||
| -rw-r--r-- | stack/sdp/sdp_db.c | 2 | ||||
| -rw-r--r-- | stack/sdp/sdp_discovery.c | 6 | ||||
| -rw-r--r-- | stack/sdp/sdp_server.c | 4 | ||||
| -rw-r--r-- | stack/sdp/sdp_utils.c | 14 |
5 files changed, 13 insertions, 13 deletions
diff --git a/stack/sdp/sdp_api.c b/stack/sdp/sdp_api.c index ef662f6..ef662f6 100644..100755 --- a/stack/sdp/sdp_api.c +++ b/stack/sdp/sdp_api.c diff --git a/stack/sdp/sdp_db.c b/stack/sdp/sdp_db.c index e52e69c..e9a35fc 100644 --- a/stack/sdp/sdp_db.c +++ b/stack/sdp/sdp_db.c @@ -212,7 +212,7 @@ static int sdp_compose_proto_list( UINT8 *p, UINT16 num_elem, /* First, build the protocol list. This consists of a set of data element ** sequences, one for each layer. Each layer sequence consists of layer's - ** UUID and optional parameters + ** UUID and optional parameters */ for (xx = 0; xx < num_elem; xx++, p_elem_list++) { diff --git a/stack/sdp/sdp_discovery.c b/stack/sdp/sdp_discovery.c index 30ea277..1092584 100644 --- a/stack/sdp/sdp_discovery.c +++ b/stack/sdp/sdp_discovery.c @@ -372,7 +372,7 @@ static void sdp_copy_raw_data (tCONN_CB *p_ccb, UINT16 len, BOOLEAN offset) UINT8 * p_temp; UINT8 type; UINT32 delta_len = 0; - + #if (SDP_DEBUG_RAW == TRUE) UINT8 num_array[SDP_MAX_LIST_BYTE_COUNT]; UINT32 i; @@ -395,7 +395,7 @@ static void sdp_copy_raw_data (tCONN_CB *p_ccb, UINT16 len, BOOLEAN offset) type = *p++; p = sdpu_get_len_from_type (p, type, &list_len); } - if(list_len && list_len < cpy_len ) + if(list_len && list_len < cpy_len ) { cpy_len = list_len; } @@ -1003,7 +1003,7 @@ static UINT8 *add_attr (UINT8 *p, tSDP_DISCOVERY_DB *p_db, tSDP_DISC_REC *p_rec, else { /* coverity[overrun-local] */ - /* + /* Event overrun-local: Overrun of static array "p_attr->attr_value.v.array" of size 4 at position 15 with index variable "ijk" False-positive: SDP uses scratch buffer to hold the attribute value. The actual size of tSDP_DISC_ATVAL does not matter. diff --git a/stack/sdp/sdp_server.c b/stack/sdp/sdp_server.c index 463ec7e..3640dc2 100644 --- a/stack/sdp/sdp_server.c +++ b/stack/sdp/sdp_server.c @@ -217,7 +217,7 @@ static void process_service_search (tCONN_CB *p_ccb, UINT16 trans_num, /* Calculate how many handles will fit in one PDU */ cur_handles = (UINT16)((p_ccb->rem_mtu_size - SDP_MAX_SERVICE_RSPHDR_LEN) / 4); - + if (rem_handles <= cur_handles) cur_handles = rem_handles; else /* Continuation is set */ @@ -405,7 +405,7 @@ static void process_service_attr_req (tCONN_CB *p_ccb, UINT16 trans_num, /* if there is a partial attribute pending to be sent */ if (p_ccb->cont_info.attr_offset) { - p_rsp = sdpu_build_partial_attrib_entry (p_rsp, p_attr, rem_len, + p_rsp = sdpu_build_partial_attrib_entry (p_rsp, p_attr, rem_len, &p_ccb->cont_info.attr_offset); /* If the partial attrib could not been fully added yet */ diff --git a/stack/sdp/sdp_utils.c b/stack/sdp/sdp_utils.c index bba3e60..d98a30c 100644 --- a/stack/sdp/sdp_utils.c +++ b/stack/sdp/sdp_utils.c @@ -256,7 +256,7 @@ UINT8 *sdpu_build_attrib_entry (UINT8 *p_out, tSDP_ATTRIBUTE *p_attr) return (p_out); } - + /* Now, store the attribute value */ switch (p_attr->len) { @@ -347,7 +347,7 @@ void sdpu_build_n_send_error (tCONN_CB *p_ccb, UINT16 trans_num, UINT16 error_co ** Function sdpu_extract_uid_seq ** ** Description This function extracts a UUID sequence from the passed input -** buffer, and puts it into the passed output list. +** buffer, and puts it into the passed output list. ** ** Returns Pointer to next byte in the input buffer after the sequence. ** @@ -461,7 +461,7 @@ UINT8 *sdpu_extract_uid_seq (UINT8 *p, UINT16 param_len, tSDP_UUID_SEQ *p_seq) ** Function sdpu_extract_attr_seq ** ** Description This function extracts an attribute sequence from the passed -** input buffer, and puts it into the passed output list. +** input buffer, and puts it into the passed output list. ** ** Returns Pointer to next byte in the input buffer after the sequence. ** @@ -772,7 +772,7 @@ BOOLEAN sdpu_compare_uuid_with_attr (tBT_UUID *p_btuuid, tSDP_DISC_ATTR *p_attr) Event overrun-buffer-arg: Overrun of static array "&p_attr->attr_value.v.array" of size 4 bytes by passing it to a function which indexes it with argument "16U" at byte position 15 FALSE-POSITIVE error from Coverity test tool. Please do NOT remove following comment. False-positive: SDP uses scratch buffer to hold the attribute value. - The actual size of tSDP_DISC_ATVAL does not matter. + The actual size of tSDP_DISC_ATVAL does not matter. If the array size in tSDP_DISC_ATVAL is increase, we would increase the system RAM usage unnecessarily */ else if (!memcmp (p_btuuid->uu.uuid128, p_attr->attr_value.v.array, MAX_UUID_SIZE)) @@ -820,7 +820,7 @@ void sdpu_sort_attr_list( UINT16 num_attr, tSDP_DISCOVERY_DB *p_db ) } else i++; - } + } } @@ -946,7 +946,7 @@ UINT16 sdpu_get_attrib_entry_len(tSDP_ATTRIBUTE *p_attr) len += p_attr->len; return len; } - + /* Now, the attribute value */ switch (p_attr->len) { @@ -1010,7 +1010,7 @@ UINT8 *sdpu_build_partial_attrib_entry (UINT8 *p_out, tSDP_ATTRIBUTE *p_attr, UI ** Description This function converts UUID-16 to UUID-128 by including the base UUID ** ** uuid16: 2-byte UUID -** p_uuid128: Expanded 128-bit UUID +** p_uuid128: Expanded 128-bit UUID ** ** Returns None ** |