diff options
| author | David Benjamin <davidben@google.com> | 2016-08-22 22:19:01 -0700 |
|---|---|---|
| committer | Sean McCreary <mccreary@mcwest.org> | 2017-03-22 12:17:27 -0600 |
| commit | 70920e0bef6d67c9c48246347a29722af7161542 (patch) | |
| tree | 8d56a728e7dd30251707bbdba092771b850e2dd8 /mac-x86_64 | |
| parent | 1c725f9b6cce4af300ac28b902d186e8053c2f97 (diff) | |
| download | external_boringssl-70920e0bef6d67c9c48246347a29722af7161542.zip external_boringssl-70920e0bef6d67c9c48246347a29722af7161542.tar.gz external_boringssl-70920e0bef6d67c9c48246347a29722af7161542.tar.bz2 | |
Rewrite BN_bn2dec.
This is a more complete fix for CVE-2016-2182. The original commit
message was:
"If an oversize BIGNUM is presented to BN_bn2dec() it can cause
BN_div_word() to fail and not reduce the value of 't' resulting
in OOB writes to the bn_data buffer and eventually crashing.
Fix by checking return value of BN_div_word() and checking writes
don't overflow buffer.
Thanks to Shi Lei for reporting this bug."
BoringSSL's rewrite commit message:
"958aaf1ea1b481e8ef32970d5b0add80504be4b2, imported from upstream, had
an off-by-one error. Reproducing the failure is fairly easy as it can't
even serialize 1. See also upstream's
099e2968ed3c7d256cda048995626664082b1b30.
Rewrite the function completely with CBB and add a basic test.
BUG=chromium:639740"
CVE-2016-2182
Change-Id: I41a91514c4bb9e83854824ed5258ffe4e49d9491
Bug: 32096880
(cherry picked from commit 29b92ab938c1a17d4d1b3b039042a0f499f58b5d)
(cherry picked from commit 54bf62a81586d99d0a951ca3342d569b59e69b80
with adaptations from <sultanxda@gmail.com>)
Diffstat (limited to 'mac-x86_64')
0 files changed, 0 insertions, 0 deletions