diff options
| author | Daniel Dunbar <daniel@zuster.org> | 2010-03-10 02:10:29 +0000 |
|---|---|---|
| committer | Daniel Dunbar <daniel@zuster.org> | 2010-03-10 02:10:29 +0000 |
| commit | 07a9641ebf420ae90aa3667ab4df83cd1ade2117 (patch) | |
| tree | acd4573f8ade01a6ab70adf9bd312e5d2db2b2a8 | |
| parent | 9f116aa3b1ece85b863099ffa7ea1cab88ef46a8 (diff) | |
| download | external_llvm-07a9641ebf420ae90aa3667ab4df83cd1ade2117.zip external_llvm-07a9641ebf420ae90aa3667ab4df83cd1ade2117.tar.gz external_llvm-07a9641ebf420ae90aa3667ab4df83cd1ade2117.tar.bz2 | |
MC/Mach-O: Resolve a FIXME; these relocation types are no longer semanticaly different.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@98120 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/MC/MCAssembler.cpp | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/lib/MC/MCAssembler.cpp b/lib/MC/MCAssembler.cpp index b44cd1e..00b02e0 100644 --- a/lib/MC/MCAssembler.cpp +++ b/lib/MC/MCAssembler.cpp @@ -462,9 +462,11 @@ public: llvm_report_error("symbol '" + B->getName() + "' can not be undefined in a subtraction expression"); - // FIXME: This change of type based on the external bit doesn't make much - // sense, it seems to be redundant with the other information in the - // relocation entry. + // Select the appropriate difference relocation type. + // + // Note that there is no longer any semantic difference between these two + // relocation types from the linkers point of view, this is done solely + // for pedantic compatibility with 'as'. Type = A_SD->isExternal() ? RIT_Difference : RIT_LocalDifference; Value2 = B_SD->getFragment()->getAddress() + B_SD->getOffset(); } |