diff options
| author | Dan Gohman <gohman@apple.com> | 2010-11-02 22:50:10 +0000 |
|---|---|---|
| committer | Dan Gohman <gohman@apple.com> | 2010-11-02 22:50:10 +0000 |
| commit | 0803ebe0c8caa2c02be5077d607eb5b9e6609aa4 (patch) | |
| tree | 1273d3b900638f794fc9e0e77d5ebc2fe11241cc | |
| parent | d3a124db4dac3186148aaa4dc60161d30dcfce4c (diff) | |
| download | external_llvm-0803ebe0c8caa2c02be5077d607eb5b9e6609aa4.zip external_llvm-0803ebe0c8caa2c02be5077d607eb5b9e6609aa4.tar.gz external_llvm-0803ebe0c8caa2c02be5077d607eb5b9e6609aa4.tar.bz2 | |
Simplify this code.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@118102 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/System/Unix/Path.inc | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/lib/System/Unix/Path.inc b/lib/System/Unix/Path.inc index 571ecbd..c1765b8 100644 --- a/lib/System/Unix/Path.inc +++ b/lib/System/Unix/Path.inc @@ -141,8 +141,7 @@ Path::GetTemporaryDirectory(std::string *ErrMsg) { #if defined(HAVE_MKDTEMP) // The best way is with mkdtemp but that's not available on many systems, // Linux and FreeBSD have it. Others probably won't. - char pathname[MAXPATHLEN]; - strcpy(pathname,"/tmp/llvm_XXXXXX"); + char pathname[] = "/tmp/llvm_XXXXXX"; if (0 == mkdtemp(pathname)) { MakeErrMsg(ErrMsg, std::string(pathname) + ": can't create temporary directory"); @@ -158,8 +157,7 @@ Path::GetTemporaryDirectory(std::string *ErrMsg) { // mktemp because of mktemp's inherent security and threading risks. We still // have a slight race condition from the time the temporary file is created to // the time it is re-created as a directoy. - char pathname[MAXPATHLEN]; - strcpy(pathname, "/tmp/llvm_XXXXXX"); + char pathname[] = "/tmp/llvm_XXXXXX"; int fd = 0; if (-1 == (fd = mkstemp(pathname))) { MakeErrMsg(ErrMsg, @@ -183,8 +181,7 @@ Path::GetTemporaryDirectory(std::string *ErrMsg) { // implementation of mktemp(3) and doesn't follow BSD 4.3's lead of replacing // the XXXXXX with the pid of the process and a letter. That leads to only // twenty six temporary files that can be generated. - char pathname[MAXPATHLEN]; - strcpy(pathname, "/tmp/llvm_XXXXXX"); + char pathname[] = "/tmp/llvm_XXXXXX"; char *TmpName = ::mktemp(pathname); if (TmpName == 0) { MakeErrMsg(ErrMsg, |