diff options
author | Dan Gohman <gohman@apple.com> | 2010-05-26 21:46:36 +0000 |
---|---|---|
committer | Dan Gohman <gohman@apple.com> | 2010-05-26 21:46:36 +0000 |
commit | 113b3e2c6e30efd7c852d31e98b2d21778e52d1e (patch) | |
tree | c71326c36125e3458551aaccbfb383febf704c8c | |
parent | f86a619314d431ea5ccb1becb38d8a015f6c5501 (diff) | |
download | external_llvm-113b3e2c6e30efd7c852d31e98b2d21778e52d1e.zip external_llvm-113b3e2c6e30efd7c852d31e98b2d21778e52d1e.tar.gz external_llvm-113b3e2c6e30efd7c852d31e98b2d21778e52d1e.tar.bz2 |
Implement checking of the tail keyword.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@104744 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/Analysis/Lint.cpp | 10 | ||||
-rw-r--r-- | test/Other/lint.ll | 12 |
2 files changed, 21 insertions, 1 deletions
diff --git a/lib/Analysis/Lint.cpp b/lib/Analysis/Lint.cpp index 25d4f95..8b38733 100644 --- a/lib/Analysis/Lint.cpp +++ b/lib/Analysis/Lint.cpp @@ -219,7 +219,15 @@ void Lint::visitCallSite(CallSite CS) { // TODO: Check sret attribute. } - // TODO: Check the "tail" keyword constraints. + if (CS.isCall() && cast<CallInst>(CS.getInstruction())->isTailCall()) + for (CallSite::arg_iterator AI = CS.arg_begin(), AE = CS.arg_end(); + AI != AE; ++AI) { + Value *Obj = (*AI)->getUnderlyingObject(); + Assert1(!isa<AllocaInst>(Obj) && !isa<VAArgInst>(Obj), + "Undefined behavior: Call with \"tail\" keyword references " + "alloca or va_arg", &I); + } + if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(&I)) switch (II->getIntrinsicID()) { diff --git a/test/Other/lint.ll b/test/Other/lint.ll index d0db5e4..eb0b762 100644 --- a/test/Other/lint.ll +++ b/test/Other/lint.ll @@ -77,8 +77,20 @@ define void @not_vararg(i8* %p) nounwind { ret void } +; CHECK: Undefined behavior: Branch to non-blockaddress define void @use_indbr() { indirectbr i8* bitcast (i32()* @foo to i8*), [label %block] block: unreachable } + +; CHECK: Undefined behavior: Call with "tail" keyword references alloca or va_arg +; CHECK: Undefined behavior: Call with "tail" keyword references alloca or va_arg +declare void @tailcallee(i8*) +define void @use_tail(i8* %valist) { + %t = alloca i8 + tail call void @tailcallee(i8* %t) + %s = va_arg i8* %valist, i8* + tail call void @tailcallee(i8* %s) + ret void +} |