aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Lattner <sabre@nondot.org>2010-01-22 21:16:10 +0000
committerChris Lattner <sabre@nondot.org>2010-01-22 21:16:10 +0000
commit14ca177beba15e86ca410c9f6fc7f48ba245dba6 (patch)
tree1b43cda3d711d8e314879474e0450d87bc97e2d2
parent965df54254b9e73949fc5649b51c3ca1bed4b4a6 (diff)
downloadexternal_llvm-14ca177beba15e86ca410c9f6fc7f48ba245dba6.zip
external_llvm-14ca177beba15e86ca410c9f6fc7f48ba245dba6.tar.gz
external_llvm-14ca177beba15e86ca410c9f6fc7f48ba245dba6.tar.bz2
Changes to fix buffering that I forgot to commit with previous patch.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@94222 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/llvm/Support/raw_ostream.h6
-rw-r--r--lib/MC/MCAsmStreamer.cpp7
-rw-r--r--lib/Support/raw_ostream.cpp13
3 files changed, 18 insertions, 8 deletions
diff --git a/include/llvm/Support/raw_ostream.h b/include/llvm/Support/raw_ostream.h
index 05794e5..0f227cc 100644
--- a/include/llvm/Support/raw_ostream.h
+++ b/include/llvm/Support/raw_ostream.h
@@ -456,8 +456,10 @@ public:
explicit raw_svector_ostream(SmallVectorImpl<char> &O);
~raw_svector_ostream();
- /// clear - Flush the stream and clear the underlying vector.
- void clear();
+ /// resync - This is called when the SmallVector we're appending to is changed
+ /// outside of the raw_svector_ostream's control. It is only safe to do this
+ /// if the raw_svector_ostream has previously been flushed.
+ void resync();
/// str - Flushes the stream contents to the target vector and return a
/// StringRef for the vector contents.
diff --git a/lib/MC/MCAsmStreamer.cpp b/lib/MC/MCAsmStreamer.cpp
index e284e15..d4ef3ca 100644
--- a/lib/MC/MCAsmStreamer.cpp
+++ b/lib/MC/MCAsmStreamer.cpp
@@ -136,6 +136,9 @@ void MCAsmStreamer::AddComment(const Twine &T) {
T.toVector(CommentToEmit);
// Each comment goes on its own line.
CommentToEmit.push_back('\n');
+
+ // Tell the comment stream that the vector changed underneath it.
+ CommentStream.resync();
}
void MCAsmStreamer::EmitCommentsAndEOL() {
@@ -158,7 +161,9 @@ void MCAsmStreamer::EmitCommentsAndEOL() {
Comments = Comments.substr(Position+1);
} while (!Comments.empty());
- CommentStream.clear();
+ CommentToEmit.clear();
+ // Tell the comment stream that the vector changed underneath it.
+ CommentStream.resync();
}
diff --git a/lib/Support/raw_ostream.cpp b/lib/Support/raw_ostream.cpp
index 7cd16c8..10d7ec0 100644
--- a/lib/Support/raw_ostream.cpp
+++ b/lib/Support/raw_ostream.cpp
@@ -562,11 +562,14 @@ raw_svector_ostream::~raw_svector_ostream() {
flush();
}
-/// clear - Flush the stream and clear the underlying vector.
-void raw_svector_ostream::clear() {
- if (GetNumBytesInBuffer() == 0) flush();
-
- OS.clear();
+/// resync - This is called when the SmallVector we're appending to is changed
+/// outside of the raw_svector_ostream's control. It is only safe to do this
+/// if the raw_svector_ostream has previously been flushed.
+void raw_svector_ostream::resync() {
+ assert(GetNumBytesInBuffer() == 0 && "Didn't flush before mutating vector");
+
+ if (OS.capacity() - OS.size() < 64)
+ OS.reserve(OS.capacity() * 2);
SetBuffer(OS.end(), OS.capacity() - OS.size());
}