aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Lenharth <andrewl@lenharth.org>2006-11-28 19:56:02 +0000
committerAndrew Lenharth <andrewl@lenharth.org>2006-11-28 19:56:02 +0000
commit238581f2bbd5dfd064ea8eaec6f9e7b1ff42f01b (patch)
tree23370fefa6619d46e151c3c2e17d065314ab3605
parente0cf07584d097247ef5f830a64a9909001afc155 (diff)
downloadexternal_llvm-238581f2bbd5dfd064ea8eaec6f9e7b1ff42f01b.zip
external_llvm-238581f2bbd5dfd064ea8eaec6f9e7b1ff42f01b.tar.gz
external_llvm-238581f2bbd5dfd064ea8eaec6f9e7b1ff42f01b.tar.bz2
update comments
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@31975 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--lib/Target/CBackend/CBackend.cpp6
-rw-r--r--lib/Target/CBackend/Writer.cpp6
2 files changed, 8 insertions, 4 deletions
diff --git a/lib/Target/CBackend/CBackend.cpp b/lib/Target/CBackend/CBackend.cpp
index eac7526..18c4d06 100644
--- a/lib/Target/CBackend/CBackend.cpp
+++ b/lib/Target/CBackend/CBackend.cpp
@@ -2258,9 +2258,9 @@ void CWriter::visitCallInst(CallInst &I) {
//This converts the llvm constraint string to something gcc is expecting.
-//This could be broken into a bunch of peices and spread accross the
-//targets, but this information is only useful here.
//TODO: work out platform independent constraints and factor those out
+// of the per target tables
+// handle multiple constraint codes
std::string CWriter::InterpretASMConstraint(InlineAsm::ConstraintInfo& c) {
assert(c.Codes.size() == 1 && "Too many asm constraint codes to handle");
@@ -2320,6 +2320,8 @@ static std::string gccifyAsm(std::string asmstr) {
return asmstr;
}
+//TODO: assumptions about what consume arguments from the call are likely wrong
+// handle communitivity
void CWriter::visitInlineAsm(CallInst &CI) {
InlineAsm* as = cast<InlineAsm>(CI.getOperand(0));
std::vector<InlineAsm::ConstraintInfo> Constraints = as->ParseConstraints();
diff --git a/lib/Target/CBackend/Writer.cpp b/lib/Target/CBackend/Writer.cpp
index eac7526..18c4d06 100644
--- a/lib/Target/CBackend/Writer.cpp
+++ b/lib/Target/CBackend/Writer.cpp
@@ -2258,9 +2258,9 @@ void CWriter::visitCallInst(CallInst &I) {
//This converts the llvm constraint string to something gcc is expecting.
-//This could be broken into a bunch of peices and spread accross the
-//targets, but this information is only useful here.
//TODO: work out platform independent constraints and factor those out
+// of the per target tables
+// handle multiple constraint codes
std::string CWriter::InterpretASMConstraint(InlineAsm::ConstraintInfo& c) {
assert(c.Codes.size() == 1 && "Too many asm constraint codes to handle");
@@ -2320,6 +2320,8 @@ static std::string gccifyAsm(std::string asmstr) {
return asmstr;
}
+//TODO: assumptions about what consume arguments from the call are likely wrong
+// handle communitivity
void CWriter::visitInlineAsm(CallInst &CI) {
InlineAsm* as = cast<InlineAsm>(CI.getOperand(0));
std::vector<InlineAsm::ConstraintInfo> Constraints = as->ParseConstraints();