diff options
| author | Chris Lattner <sabre@nondot.org> | 2008-04-25 05:13:01 +0000 |
|---|---|---|
| committer | Chris Lattner <sabre@nondot.org> | 2008-04-25 05:13:01 +0000 |
| commit | 25453ea49e30e4e22e072153832158a6b0ee0390 (patch) | |
| tree | 4d24e2b5891cb43466a2136aa3cc13f6e0ff47e6 | |
| parent | eede65ce6cb29c8f3a701be8606e95c9a213efff (diff) | |
| download | external_llvm-25453ea49e30e4e22e072153832158a6b0ee0390.zip external_llvm-25453ea49e30e4e22e072153832158a6b0ee0390.tar.gz external_llvm-25453ea49e30e4e22e072153832158a6b0ee0390.tar.bz2 | |
Loosen up an assertion to allow intrinsics. I really have no
idea what this code (findNonImmUse) does, so I'm only guessing
that this is the right thing. It would be really really nice
if this had comments and perhaps switched to SmallPtrSet
(hint hint) :)
This fixes rdar://5886601, a crash on gcc.target/i386/sse4_1-pblendw.c
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@50252 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/Target/X86/X86ISelDAGToDAG.cpp | 5 | ||||
| -rw-r--r-- | test/CodeGen/X86/2008-04-24-pblendw-fold-crash.ll | 15 |
2 files changed, 19 insertions, 1 deletions
diff --git a/lib/Target/X86/X86ISelDAGToDAG.cpp b/lib/Target/X86/X86ISelDAGToDAG.cpp index 252a018..9bf9d12 100644 --- a/lib/Target/X86/X86ISelDAGToDAG.cpp +++ b/lib/Target/X86/X86ISelDAGToDAG.cpp @@ -252,7 +252,10 @@ static void findNonImmUse(SDNode *Use, SDNode* Def, SDNode *ImmedUse, continue; // Immediate use is ok. if (Use == Root) { assert(Use->getOpcode() == ISD::STORE || - Use->getOpcode() == X86ISD::CMP); + Use->getOpcode() == X86ISD::CMP || + Use->getOpcode() == ISD::INTRINSIC_WO_CHAIN || + Use->getOpcode() == ISD::INTRINSIC_W_CHAIN || + Use->getOpcode() == ISD::INTRINSIC_VOID); continue; } found = true; diff --git a/test/CodeGen/X86/2008-04-24-pblendw-fold-crash.ll b/test/CodeGen/X86/2008-04-24-pblendw-fold-crash.ll new file mode 100644 index 0000000..838c2ea --- /dev/null +++ b/test/CodeGen/X86/2008-04-24-pblendw-fold-crash.ll @@ -0,0 +1,15 @@ +; RUN: llvm-as < %s | llc -mattr=+sse41 +; rdar://5886601 +; gcc testsuite: gcc.target/i386/sse4_1-pblendw.c +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128" +target triple = "i386-apple-darwin8" + +define i32 @main() nounwind { +entry: + %tmp122 = load <2 x i64>* null, align 16 ; <<2 x i64>> [#uses=1] + %tmp126 = bitcast <2 x i64> %tmp122 to <8 x i16> ; <<8 x i16>> [#uses=1] + %tmp129 = call <8 x i16> @llvm.x86.sse41.pblendw( <8 x i16> zeroinitializer, <8 x i16> %tmp126, i32 2 ) nounwind ; <<8 x i16>> [#uses=0] + ret i32 0 +} + +declare <8 x i16> @llvm.x86.sse41.pblendw(<8 x i16>, <8 x i16>, i32) nounwind |