aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDevang Patel <dpatel@apple.com>2011-04-08 23:39:38 +0000
committerDevang Patel <dpatel@apple.com>2011-04-08 23:39:38 +0000
commit3f932a74be207eaad700ac7898f63c06131097ea (patch)
treecf16f7fc3d9888369b847a8e1a0bb2affa9f7f85
parent918035f802be7840177f77389d0b70415f84b06f (diff)
downloadexternal_llvm-3f932a74be207eaad700ac7898f63c06131097ea.zip
external_llvm-3f932a74be207eaad700ac7898f63c06131097ea.tar.gz
external_llvm-3f932a74be207eaad700ac7898f63c06131097ea.tar.bz2
Simplify array bound checks and clarify comments. One element array can have same non-zero number as lower bound as well as upper bound.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@129170 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--docs/SourceLevelDebugging.html3
-rw-r--r--lib/CodeGen/AsmPrinter/DwarfDebug.cpp17
2 files changed, 9 insertions, 11 deletions
diff --git a/docs/SourceLevelDebugging.html b/docs/SourceLevelDebugging.html
index 10c78f6..440f409 100644
--- a/docs/SourceLevelDebugging.html
+++ b/docs/SourceLevelDebugging.html
@@ -708,7 +708,8 @@ DW_TAG_inheritance = 28
<a href="#format_composite_type">composite type</a>. The low value defines
the lower bounds typically zero for C/C++. The high value is the upper
bounds. Values are 64 bit. High - low + 1 is the size of the array. If low
- > high the array will be unbounded.</p>
+ > high the array bounds are not included in generated debugging information.
+</p>
</div>
diff --git a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
index b9bf37b..440099f 100644
--- a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
+++ b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
@@ -1242,19 +1242,16 @@ void DwarfDebug::constructSubrangeDIE(DIE &Buffer, DISubrange SR, DIE *IndexTy){
int64_t L = SR.getLo();
int64_t H = SR.getHi();
- // The L value defines the lower bounds typically zero for C/C++. The H
- // value is the upper bounds. Values are 64 bit. H - L + 1 is the size
- // of the array. If L > H the array will be unbounded. If the L is
- // non zero and same is H then also the array will be unbounded. If L is
- // zero and H is zero then the array has one element and in such case do
- // not emit lower bound.
-
- if (L > H || (L == H && L != 0)) {
- // This is an unbounded subrange.
+ // The L value defines the lower bounds which is typically zero for C/C++. The
+ // H value is the upper bounds. Values are 64 bit. H - L + 1 is the size
+ // of the array. If L > H then do not emit DW_AT_lower_bound and
+ // DW_AT_upper_bound attributes. If L is zero and H is also zero then the
+ // array has one element and in such case do not emit lower bound.
+
+ if (L > H) {
Buffer.addChild(DW_Subrange);
return;
}
-
if (L)
addSInt(DW_Subrange, dwarf::DW_AT_lower_bound, 0, L);
addSInt(DW_Subrange, dwarf::DW_AT_upper_bound, 0, H);