aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDevang Patel <dpatel@apple.com>2009-10-22 00:10:15 +0000
committerDevang Patel <dpatel@apple.com>2009-10-22 00:10:15 +0000
commit49b63a1f2c493f6452d22cf0df4c147e0539fb2e (patch)
tree2048fe9eaf10e514374d6c9ad8fbc7dd4a32fae2
parent6d31268a7dc9854fa5a5cb9227ba9a15c5898414 (diff)
downloadexternal_llvm-49b63a1f2c493f6452d22cf0df4c147e0539fb2e.zip
external_llvm-49b63a1f2c493f6452d22cf0df4c147e0539fb2e.tar.gz
external_llvm-49b63a1f2c493f6452d22cf0df4c147e0539fb2e.tar.bz2
Remove meaningless const.
Pass StringRef by value. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@84804 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r--include/llvm/Metadata.h8
-rw-r--r--lib/VMCore/Metadata.cpp8
2 files changed, 8 insertions, 8 deletions
diff --git a/include/llvm/Metadata.h b/include/llvm/Metadata.h
index 4a19100..a24ebe6 100644
--- a/include/llvm/Metadata.h
+++ b/include/llvm/Metadata.h
@@ -61,7 +61,7 @@ protected:
: MetadataBase(Type::getMetadataTy(C), Value::MDStringVal), Str(begin, l) {}
public:
- static MDString *get(LLVMContext &Context, const StringRef &Str);
+ static MDString *get(LLVMContext &Context, StringRef Str);
StringRef getString() const { return Str; }
@@ -256,14 +256,14 @@ private:
public:
/// registerMDKind - Register a new metadata kind and return its ID.
/// A metadata kind can be registered only once.
- unsigned registerMDKind(const StringRef Name);
+ unsigned registerMDKind(StringRef Name);
/// getMDKind - Return metadata kind. If the requested metadata kind
/// is not registered then return 0.
- unsigned getMDKind(const StringRef Name) const;
+ unsigned getMDKind(StringRef Name) const;
/// isValidName - Return true if Name is a valid custom metadata handler name.
- static bool isValidName(const StringRef Name);
+ static bool isValidName(StringRef Name);
/// getMD - Get the metadata of given kind attached to an Instruction.
/// If the metadata is not found then return 0.
diff --git a/lib/VMCore/Metadata.cpp b/lib/VMCore/Metadata.cpp
index faf79fd..8b37681 100644
--- a/lib/VMCore/Metadata.cpp
+++ b/lib/VMCore/Metadata.cpp
@@ -26,7 +26,7 @@ using namespace llvm;
//===----------------------------------------------------------------------===//
// MDString implementation.
//
-MDString *MDString::get(LLVMContext &Context, const StringRef &Str) {
+MDString *MDString::get(LLVMContext &Context, StringRef Str) {
LLVMContextImpl *pImpl = Context.pImpl;
StringMapEntry<MDString *> &Entry =
pImpl->MDStringCache.GetOrCreateValue(Str);
@@ -186,7 +186,7 @@ NamedMDNode::~NamedMDNode() {
/// registerMDKind - Register a new metadata kind and return its ID.
/// A metadata kind can be registered only once.
-unsigned MetadataContext::registerMDKind(const StringRef Name) {
+unsigned MetadataContext::registerMDKind(StringRef Name) {
assert(isValidName(Name) && "Invalid custome metadata name!");
unsigned Count = MDHandlerNames.size();
assert(MDHandlerNames.count(Name) == 0 && "Already registered MDKind!");
@@ -194,7 +194,7 @@ unsigned MetadataContext::registerMDKind(const StringRef Name) {
}
/// isValidName - Return true if Name is a valid custom metadata handler name.
-bool MetadataContext::isValidName(const StringRef MDName) {
+bool MetadataContext::isValidName(StringRef MDName) {
if (MDName.empty())
return false;
@@ -211,7 +211,7 @@ bool MetadataContext::isValidName(const StringRef MDName) {
/// getMDKind - Return metadata kind. If the requested metadata kind
/// is not registered then return 0.
-unsigned MetadataContext::getMDKind(const StringRef Name) const {
+unsigned MetadataContext::getMDKind(StringRef Name) const {
StringMap<unsigned>::const_iterator I = MDHandlerNames.find(Name);
if (I == MDHandlerNames.end()) {
assert(isValidName(Name) && "Invalid custome metadata name!");