diff options
author | Torok Edwin <edwintorok@gmail.com> | 2009-04-25 10:25:12 +0000 |
---|---|---|
committer | Torok Edwin <edwintorok@gmail.com> | 2009-04-25 10:25:12 +0000 |
commit | 4cdc44c82c4415b467760065fed146f73933c67b (patch) | |
tree | 74a73bef54328444bb7d5dcba1ae39e2df115d32 | |
parent | 0adb527d169e1f557676fda35bc9abb735e5c912 (diff) | |
download | external_llvm-4cdc44c82c4415b467760065fed146f73933c67b.zip external_llvm-4cdc44c82c4415b467760065fed146f73933c67b.tar.gz external_llvm-4cdc44c82c4415b467760065fed146f73933c67b.tar.bz2 |
Fix g++-4.4.0 warning, it was causing llvm-nm to fail on wrapped BC files:
Path.cpp:59: warning: case label value exceeds maximum value for type
magic[0] is a (signed) char, but some case values are unsigned (e.g. 0xde).
When magic[0] was 0xde, the switch has taken the default branch instead of case
0xde branch.
Apparently this was the behaviour with older versions of gcc too, but not with g++.
Now g++-4.4 behaves as gcc, and ignores unsigned case values out of range signed
range.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@70038 91177308-0d34-0410-b5e6-96231b3b80d8
-rw-r--r-- | lib/System/Path.cpp | 2 | ||||
-rw-r--r-- | test/Assembler/bcwrap.ll | 9 |
2 files changed, 10 insertions, 1 deletions
diff --git a/lib/System/Path.cpp b/lib/System/Path.cpp index 4c965db..72bd7ad 100644 --- a/lib/System/Path.cpp +++ b/lib/System/Path.cpp @@ -55,7 +55,7 @@ LLVMFileType sys::IdentifyFileType(const char *magic, unsigned length) { assert(magic && "Invalid magic number string"); assert(length >=4 && "Invalid magic number length"); - switch (magic[0]) { + switch ((unsigned char)magic[0]) { case 0xDE: // 0x0B17C0DE = BC wraper if (magic[1] == (char)0xC0 && magic[2] == (char)0x17 && magic[3] == (char)0x0B) diff --git a/test/Assembler/bcwrap.ll b/test/Assembler/bcwrap.ll new file mode 100644 index 0000000..859dc4b --- /dev/null +++ b/test/Assembler/bcwrap.ll @@ -0,0 +1,9 @@ +; RUN: llvm-as < %s > %t +; RUN: llvm-nm %t | grep foo +; test for isBitcodeFile, llvm-nm must read from a file for this test +target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128" +target triple = "i686-apple-darwin9.2.2" + +define i32 @foo() { + ret i32 0 +} |