diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2010-09-28 16:19:11 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2010-09-28 16:19:11 +0000 |
| commit | 53725bc57a992e812d08f6ec62d824dfd21425bf (patch) | |
| tree | bf29e660c96490115f7beb5bb26deeab5f03e96a | |
| parent | c577c271b1e0230197bc48e991f376c52fb896a8 (diff) | |
| download | external_llvm-53725bc57a992e812d08f6ec62d824dfd21425bf.zip external_llvm-53725bc57a992e812d08f6ec62d824dfd21425bf.tar.gz external_llvm-53725bc57a992e812d08f6ec62d824dfd21425bf.tar.bz2 | |
On elf, undefined symbols can start with .L.
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@114958 91177308-0d34-0410-b5e6-96231b3b80d8
| -rw-r--r-- | lib/MC/ELFObjectWriter.cpp | 5 | ||||
| -rw-r--r-- | test/MC/ELF/undef.s | 15 |
2 files changed, 19 insertions, 1 deletions
diff --git a/lib/MC/ELFObjectWriter.cpp b/lib/MC/ELFObjectWriter.cpp index 120789b..b60271f 100644 --- a/lib/MC/ELFObjectWriter.cpp +++ b/lib/MC/ELFObjectWriter.cpp @@ -689,12 +689,15 @@ void ELFObjectWriterImpl::ComputeSymbolTable(MCAssembler &Asm) { const MCSymbol &Symbol = it->getSymbol(); // Ignore non-linker visible symbols. - if (!Asm.isSymbolLinkerVisible(Symbol)) + if (!Asm.isSymbolLinkerVisible(Symbol) && !Symbol.isUndefined()) continue; if (!it->isExternal() && !Symbol.isUndefined()) continue; + if (Symbol.isVariable()) + continue; + uint64_t &Entry = StringIndexMap[Symbol.getName()]; if (!Entry) { Entry = StringTable.size(); diff --git a/test/MC/ELF/undef.s b/test/MC/ELF/undef.s new file mode 100644 index 0000000..59bcc9f --- /dev/null +++ b/test/MC/ELF/undef.s @@ -0,0 +1,15 @@ +// RUN: llvm-mc -filetype=obj -triple x86_64-pc-linux-gnu %s -o - | elf-dump | FileCheck %s + +// Test that there is an undefined reference to .Lset0, but not .Lset1 + + .long .Lset0 +foo: +bar: +.Lset1 = foo - bar + .long .Lset1 + +// CHECK: ('_symbols', [ +// CHECK-NOT: Lset1 +// CHECK: (('st_name', 9) # '.Lset0' +// CHECK-NOT: Lset1 +// CHECK: (('sh_name', 36) # '.strtab' |